Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated package versions #461

Merged
merged 8 commits into from
Nov 4, 2019
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Nov 2, 2019

See #459 . This removes about 15 packages, the rest have non-trivial upgrade paths.

before, cargo-update would give an error about incompatible versions of
libgit2-sys
removed 8 dependencies!
removes 3 dependencies
uses the same version as cargo
this doesn't actually reduce the number of dependencies, since comrak
introduces new ones, but it does speed up compile time.

Note that removing options.safe is fine since Comrak now makes safe
enabled by default.
@pietroalbini
Copy link
Member

Yay for finally removing the Cargo dependency!

@pietroalbini pietroalbini merged commit 624a39d into rust-lang:master Nov 4, 2019
pietroalbini added a commit to pietroalbini/docs.rs that referenced this pull request Nov 4, 2019
This reverts commit 624a39d, reversing
changes made to da03812.
pietroalbini added a commit that referenced this pull request Nov 4, 2019
Revert "Merge pull request #461 from jyn514/versions"
jyn514 added a commit to jyn514/docs.rs that referenced this pull request Nov 5, 2019
Retry of rust-lang#461 with fewer
changes

Hopefully this one won't slow the prod server down to a stall.
@jyn514 jyn514 mentioned this pull request Nov 5, 2019
@jyn514 jyn514 mentioned this pull request Mar 30, 2020
jyn514 added a commit to jyn514/docs.rs that referenced this pull request Mar 30, 2020
This has just the changes to Cargo.toml from
rust-lang#461,
without running `cargo update`.

This reduces our number of dependencies from 418 to 412.
jyn514 added a commit that referenced this pull request Mar 30, 2020
This has just the changes to Cargo.toml from
#461,
without running `cargo update`.

This reduces our number of dependencies from 418 to 412.
jyn514 pushed a commit that referenced this pull request Mar 30, 2020
jyn514 pushed a commit that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants