Update some of our dependencies, with focus on removing duplicates #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has just the changes to Cargo.toml from rust-lang#461, without running `cargo update`. This reduces our number of dependencies from 418 to 412.
This gets rid of one of our 4 versions of `quote`.
This comment has been minimized.
This comment has been minimized.
jyn514
changed the title
Our dependencies still drag it in, but it makes me feel better.
jyn514
commented
Mar 30, 2020
| @@ -302,7 +302,6 @@ fn render_markdown(text: &str) -> String { | |||
|
|
|||
| let options = { | |||
| let mut options = ComrakOptions::default(); | |||
| options.safe = true; | |||
There was a problem hiding this comment.
This option is now on by default and the field is called unsafe_ instead.
jyn514
changed the title
|
This looks good to me, but let's merge only when we have someone monitoring for a few hours (maybe tomorrow). |
This was referenced Mar 30, 2020
jyn514
added a commit
to jyn514/docs.rs
that referenced
this pull request
Mar 31, 2020
Follow-up to rust-lang#664. The only crate from rust-lang#664 that hasn't been updated in `comrak`, which introduced several more transitive dependencies in later version. This gets rid of a version of quote and syn.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has just the changes to Cargo.toml from #461, without running
cargo update.This reduces our number of dependencies from 418 to 412.
Additionally, we now only compile 2 versions of quote, down from 4 🎉 😅
r? @Mark-Simulacrum