ci: Use --feature-powerset --depth 2 instead of --each-feature #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This takes about 9 minutes in CI (install 40s + check 8m). Given cargo-hack installation time can be reduced by installing from GitHub release (and Travis does not return status for an hour), this is probably okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch increases feature combinations to be checked (total of all public crates) from 69 to 210.
We have too many features to check the full powerset (1457!), so limit the max number of simultaneous feature flags by
--depthoption. I think this should be sufficient in most cases as explained in taiki-e/cargo-hack#58.It took about 8-9 minutes to run in locally, but let's see how long it takes in CI... (If it's less than 10 minutes, it's probably okay to merge as windows CI takes about 8 minutes.)
FYI: @Nemo157 @jhpratt