ci: Remove version number from release binaries #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
Build succeeded: |
This was referenced Nov 13, 2020
hawkw
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Nov 13, 2020
) ## Motivation Closes #648 ## Solution Install cargo-hack from GitHub release instead of using cache. See also taiki-e/cargo-hack#89 and taiki-e/cargo-hack#91.
hawkw
added a commit
to tower-rs/tower
that referenced
this pull request
Nov 23, 2020
CI is currently busted due to [issues with caching `cargo-hack`][1]. Currently, we cache the `cargo-hack` executable to speed up builds by avoiding the overhead of compiling it from source in every build. Recently, `cargo-hack` has started publishing binaries on GitHub Releases. Rather than compiling it on CI and caching it, we can just download the binary instead. This ought to fix the build. See also taiki-e/cargo-hack#89 and taiki-e/cargo-hack#91. [1]: https://github.com/tower-rs/tower/runs/1425940763
hawkw
added a commit
to tower-rs/tower
that referenced
this pull request
Nov 23, 2020
CI is currently busted due to [issues with caching `cargo-hack`][1]. Currently, we cache the `cargo-hack` executable to speed up builds by avoiding the overhead of compiling it from source in every build. Recently, `cargo-hack` has started publishing binaries on GitHub Releases. Rather than compiling it on CI and caching it, we can just download the binary instead. This ought to fix the build. See also taiki-e/cargo-hack#89 and taiki-e/cargo-hack#91. [1]: https://github.com/tower-rs/tower/runs/1425940763
hawkw
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Nov 23, 2020
) Closes #648 Install cargo-hack from GitHub release instead of using cache. See also taiki-e/cargo-hack#89 and taiki-e/cargo-hack#91.
hawkw
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Nov 23, 2020
) Closes #648 Install cargo-hack from GitHub release instead of using cache. See also taiki-e/cargo-hack#89 and taiki-e/cargo-hack#91.
This was referenced Dec 1, 2020
hawkw
added a commit
to tower-rs/tower
that referenced
this pull request
Dec 23, 2020
CI is currently busted due to [issues with caching `cargo-hack`][1]. Currently, we cache the `cargo-hack` executable to speed up builds by avoiding the overhead of compiling it from source in every build. Recently, `cargo-hack` has started publishing binaries on GitHub Releases. Rather than compiling it on CI and caching it, we can just download the binary instead. This ought to fix the build. See also taiki-e/cargo-hack#89 and taiki-e/cargo-hack#91. [1]: https://github.com/tower-rs/tower/runs/1425940763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #89 (comment)
This allows installing cargo-hack with one command if you know the host os.
before(current):
after:
Script for cross-platform installing to be also a bit simpler.
before(current): #89 (comment)
after:
EDIT: See #98 for the latest version.
To prevent breaking the CI that depends on the current URL, we will distribute under both names until the next major version (0.5).