Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: install cargo-hack from GitHub release instead of using cache #1100

Merged
merged 1 commit into from
Nov 13, 2020
Merged

ci: install cargo-hack from GitHub release instead of using cache #1100

merged 1 commit into from
Nov 13, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Nov 13, 2020 •
edited
Loading

Motivation

Closes #648

Solution

Install cargo-hack from GitHub release instead of using cache.
See also taiki-e/cargo-hack#89 and taiki-e/cargo-hack#91.

@taiki-e taiki-e requested review from hawkw and a team as code owners November 13, 2020 10:57
@taiki-e
Copy link
Member Author

taiki-e commented Nov 13, 2020

tracing/.github/workflows/CI.yml

Lines 65 to 68 in 4f73561

# tracing and tracing-subscriber have too many features to be checked by
# cargo-hack --feature-powerset, combinatorics there is exploding.
#- tracing
#- tracing-subscriber

BTW, I think this can probably be solved by using --depth flag (taiki-e/cargo-hack#58) or unreleased taiki-e/cargo-hack#85.

hawkw
hawkw approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, this is great!

@hawkw hawkw merged commit fa105b6 into tokio-rs:master Nov 13, 2020
@taiki-e taiki-e deleted the cargo-hack branch November 14, 2020 05:38
hawkw pushed a commit that referenced this pull request Nov 23, 2020
@taiki-e @hawkw
ci: install cargo-hack from GitHub release instead of using cache (#1100
6ab9159 
)

Closes #648

Install cargo-hack from GitHub release instead of using cache.
See also taiki-e/cargo-hack#89 and
taiki-e/cargo-hack#91.
@hawkw hawkw mentioned this pull request Nov 23, 2020
Merged
hawkw pushed a commit that referenced this pull request Nov 23, 2020
@taiki-e @hawkw
ci: install cargo-hack from GitHub release instead of using cache (#1100
50e1fad 
)

Closes #648

Install cargo-hack from GitHub release instead of using cache.
See also taiki-e/cargo-hack#89 and
taiki-e/cargo-hack#91.
@taiki-e taiki-e mentioned this pull request Aug 23, 2021
Closed
@davidbarsky davidbarsky mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: cargo hack not always present in the cache
2 participants
@taiki-e @hawkw