Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude feature combinations by detecting dependencies of features #85

Merged
merged 1 commit into from
Nov 28, 2020
Merged

Exclude feature combinations by detecting dependencies of features #85

merged 1 commit into from
Nov 28, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Nov 2, 2020

Closes #81

@taiki-e taiki-e changed the title [wip] Initial implementation of deduplication by detecting dependencies of features [wip] Initial implementation of feature exclusion based on detecting dependencies of features Nov 2, 2020
@taiki-e taiki-e added A-features Area: features (--feature-powerset, --each-feature, etc.) C-enhancement Category: A new feature or an improvement for an existing one labels Nov 2, 2020
taiki-e
taiki-e commented Nov 3, 2020
View reviewed changes
tests/test.rs Outdated Show resolved Hide resolved
@taiki-e taiki-e changed the title [wip] Initial implementation of feature exclusion based on detecting dependencies of features Initial implementation of feature exclusion based on detecting dependencies of features Nov 8, 2020
@taiki-e taiki-e changed the title Initial implementation of feature exclusion based on detecting dependencies of features Exclude feature combinations by detecting dependencies of features Nov 8, 2020
@taiki-e taiki-e force-pushed the deduplication branch 4 times, most recently from 2cd4389 to 5b1a9a8 Compare November 8, 2020 03:36
@taiki-e taiki-e mentioned this pull request Nov 13, 2020
Merged
@taiki-e taiki-e force-pushed the deduplication branch 2 times, most recently from ef21f4b to f1816f6 Compare November 28, 2020 01:16
@taiki-e
Copy link
Owner Author

taiki-e commented Nov 28, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 28, 2020

Build succeeded:

@bors bors bot merged commit 9453db9 into master Nov 28, 2020
@bors bors bot deleted the deduplication branch November 28, 2020 01:30
@taiki-e taiki-e mentioned this pull request Dec 1, 2020
Closed
@taiki-e taiki-e removed the C-enhancement Category: A new feature or an improvement for an existing one label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpratt jhpratt jhpratt left review comments

Assignees
No one assigned
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intelligently exclude redundant items in powerset
2 participants
@taiki-e @jhpratt