Add if_xdp.h structs and constants and add SOL_XDP to musl
#3453
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
arctic-alpaca
force-pushed
the
main
branch
2 times, most recently
from
f783c81
to
988dbf9
Compare
|
@bors r+ |
Add `if_xdp.h` structs and constants and add `SOL_XDP` to musl Hi, this PR adds constants and structs from `if_xdp.h` for use with [`AF_XDP`](https://www.kernel.org/doc/html/latest/networking/af_xdp.html). It also adds `SOL_XDP` to musl which was missing before. I'm not sure whether the location I added the code is correct, I just edited the files where the `AF_XDP` constant was defined. Some of the structs were changed between their initial release in the kernel and the current version. For those, `_v1` structs have been added for backwards compatibility.
|
💔 Test failed - checks-actions |
|
@bors retry |
Add `if_xdp.h` structs and constants and add `SOL_XDP` to musl Hi, this PR adds constants and structs from `if_xdp.h` for use with [`AF_XDP`](https://www.kernel.org/doc/html/latest/networking/af_xdp.html). It also adds `SOL_XDP` to musl which was missing before. I'm not sure whether the location I added the code is correct, I just edited the files where the `AF_XDP` constant was defined. Some of the structs were changed between their initial release in the kernel and the current version. For those, `_v1` structs have been added for backwards compatibility.
|
💔 Test failed - checks-actions |
|
The errors seem to indicate the musl tests are using a kernel version before 5.3 and thus the additions and changes with and after 5.3 lead to issues. Is there a way to work around this? |
|
I somehow blanked on the |
|
Thanks! @bors r+ |
Add `if_xdp.h` structs and constants and add `SOL_XDP` to musl Hi, this PR adds constants and structs from `if_xdp.h` for use with [`AF_XDP`](https://www.kernel.org/doc/html/latest/networking/af_xdp.html). It also adds `SOL_XDP` to musl which was missing before. I'm not sure whether the location I added the code is correct, I just edited the files where the `AF_XDP` constant was defined. Some of the structs were changed between their initial release in the kernel and the current version. For those, `_v1` structs have been added for backwards compatibility.
|
💔 Test failed - checks-actions |
Also adds _v1 versions for backwards compatibility
|
I moved the semver changes to the correct file, I hope this is the last fix needed. |
|
Let's see if it works fine! @bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
|
@JohnTitor Thanks for your patience! Is there any timeline for the next planned release? |
|
I'm going to make a new release, one sec! |
|
Thank you very much! |
Hi,
this PR adds constants and structs from
if_xdp.hfor use withAF_XDP. It also addsSOL_XDPto musl which was missing before.I'm not sure whether the location I added the code is correct, I just edited the files where the
AF_XDPconstant was defined.Some of the structs were changed between their initial release in the kernel and the current version. For those,
_v1structs have been added for backwards compatibility.