Move common Linux ptrace definitions to linux_like/mod.rs #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
JohnTitor
approved these changes
Dec 9, 2023
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Dec 9, 2023
Move common Linux ptrace definitions to linux_like/mod.rs Move common Linux ptrace definitions to linux_like/mod.rs.
|
💔 Test failed - checks-actions |
|
☔ The latest upstream changes (presumably #3453) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Could you check the test failure? |
|
@mbyzhang are you able to rebase this so we can figure out the CI and get it merged? |
|
@mbyzhang ping, this just needs a rebase |
tgross35
reviewed
Nov 13, 2024
| pub arch: ::__u32, | ||
| pub instruction_pointer: ::__u64, | ||
| pub stack_pointer: ::__u64, | ||
| #[cfg(libc_union)] |
There was a problem hiding this comment.
This cfg can be removed since it isn't relevant on main anymore
tgross35
reviewed
Nov 13, 2024
Comment on lines
+305
to
+306
| cfg_if! { | ||
| if #[cfg(libc_union)] { |
There was a problem hiding this comment.
These types can be moved out of the cfg (same reason as above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move common Linux ptrace definitions to linux_like/mod.rs.