Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for hppa-unknown-linux-gnu #3539

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

hdeller
Copy link
Contributor

@hdeller hdeller commented Jan 12, 2024

This is the followup pull-request from:
#3032

Add libc-files to allow rust to be used on the hppa/parisc platform.

Signed-off-by: Helge Deller <deller@gmx.de>
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall LGTM with one comment

src/unix/linux_like/linux/gnu/b32/hppa/mod.rs Outdated Show resolved Hide resolved
@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 12, 2024

📌 Commit 386afa6 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 12, 2024

⌛ Testing commit 386afa6 with merge d361e08...

bors added a commit that referenced this pull request Jan 12, 2024
Add initial support for hppa-unknown-linux-gnu

This is the followup pull-request from:
#3032
@bors
Copy link
Contributor

bors commented Jan 12, 2024

☀️ Test successful - checks-actions, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing d361e08 to main...

@bors
Copy link
Contributor

bors commented Jan 12, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through the merge queue

@JohnTitor JohnTitor added this pull request to the merge queue Jan 13, 2024
Merged via the queue into rust-lang:main with commit 4475699 Jan 13, 2024
11 of 12 checks passed
@glaubitz
Copy link
Contributor

I guess, we could start sending such PRs for alpha and sh4 as well. No need to do it for ia64 which has already been removed from the kernel and glibc as it's on its way out.

@JohnTitor
Copy link
Member

Oh, sorry I thought this target had been already added but seems not.
We have to revert this to make CI green, could you re-submit this once the target is added on the rustc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants