Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add initial support for hppa-unknown-linux-gnu" #3542

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

JohnTitor
Copy link
Member

Reverts #3539
This target doesn't exist on rustc yet.

@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2024

@JohnTitor: no appropriate reviewer found, use r? to override

@JohnTitor JohnTitor added this pull request to the merge queue Jan 13, 2024
Merged via the queue into main with commit 1c5007c Jan 13, 2024
42 checks passed
@JohnTitor JohnTitor deleted the revert-3539-hppa-devel3 branch January 13, 2024 14:00
@hdeller
Copy link
Contributor

hdeller commented Jan 13, 2024

Reverts #3539 This target doesn't exist on rustc yet.

Yes, sorry. We will fix that. I didn't know that you test all cases, and as I said in the initial pull request it's somehow a chicken/egg problem.
Thanks anyway for your initial acceptance so far !!!!!

@antoyo
Copy link

antoyo commented Jan 16, 2024

@hdeller: Thanks for your work.

I was wondering what's the plan here? Do we have a PR to add HPPA on rust-lang/rust?
What is blocking you? Is there anything that would help unblock you?

@hdeller
Copy link
Contributor

hdeller commented Jan 17, 2024

Hallo @antoyo,
I'm currently busy with work on qemu and Linux kernel for hppa, so I haven't had any time for rust-lang/rust yet.
So, what's blocking me is purely time. Do you have interest to add this for hppa? Machines/access/help is no problem.

@antoyo
Copy link

antoyo commented Jan 17, 2024

No, I was just checking if there was anything blocking you and if I could help unblock it.

@thesamesam
Copy link

Can someone explain how we actually add HPPA support to rust-lang/rust? Is there an example somewhere?

I was under the impression (hopefully wrongly) that it required LLVM support or for it to be a "proper" target. Is there any precedence for a rustc_codegen-only target getting support in rust-lang/rust? Thanks.

@riking
Copy link

riking commented Apr 2, 2024

@thesamesam You can propose it as a Tier 3 target, and in the target specification the target can declare that it requires the "gcc" codegen backend.

@thesamesam
Copy link

@riking Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants