Update Arm c_char to u8 for Solid
#4197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [1], `core::ffi::c_char` was changed from `i8` to `u8` for Solid Arm targets. Make the corresponding change to `libc` here. Link: rust-lang/rust#132975 [1]
tgross35
added
the
stable-nominated
|
@tgross35: no appropriate reviewer found, use |
|
@kawadakk could you review this? I can merge it either immediately to sync with nightly or wait for the rust 1.85 release that includes the updates to |
3 tasks
|
This was fixed in #4199 |
tgross35
removed
the
stable-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In [1],
core::ffi::c_charwas changed fromi8tou8for Solid Arm targets. Make the corresponding change tolibchere.Link: rust-lang/rust#132975 [1]