-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix c_char on various targets #4199
Conversation
- aarch64-kmc-solid_asp3 - armv7a-kmc-solid_asp3-eabi - armv7a-kmc-solid_asp3-eabihf - riscv64-linux-android - x86_64-unknown-l4re-uclibc - armv7-sony-vita-newlibeabihf - riscv32imac-unknown-nuttx-elf - riscv32imafc-unknown-nuttx-elf - riscv32imc-unknown-nuttx-elf - riscv64gc-unknown-nuttx-elf - riscv64imac-unknown-nuttx-elf - thumbv6m-nuttx-eabi - thumbv7em-nuttx-eabi - thumbv7em-nuttx-eabihf - thumbv7m-nuttx-eabi - thumbv8m.base-nuttx-eabi - thumbv8m.main-nuttx-eabi - thumbv8m.main-nuttx-eabihf - aarch64-unknown-redox - aarch64-unknown-illumos - riscv32-wrs-vxworks - riscv64-wrs-vxworks
Ideally we should have a top-level c_char definition, but I'm not sure if that is backport friendly. |
I have #4198 in the queue, after which it should be possible to just |
I'm fine with it, but I think it would be ideal to provide c_char at top-level and reference it via prelude from other files (may not be backport friendly though). Like c_void does: Line 39 in 39a6799
|
We can't use |
I meant to define c_char at the top-level instead of re-exporting. |
How would that be different from making #4198 public (without |
It should mean the same thing (assuming “making #4198 public” means “making c_char_def public as c_char at top-level, remove per-target c_char definitions, and import top-level c_char as needed). |
Closing in favor of #4202, which is doing the approach I said I think is ideal in #4199 (comment). |
Re-opening -- Since this is a non-aggressive change, we might merge this before #4202, as mentioned in #4201 (comment). |
- aarch64-kmc-solid_asp3 - armv7a-kmc-solid_asp3-eabi - armv7a-kmc-solid_asp3-eabihf - riscv64-linux-android - x86_64-unknown-l4re-uclibc - armv7-sony-vita-newlibeabihf - riscv32imac-unknown-nuttx-elf - riscv32imafc-unknown-nuttx-elf - riscv32imc-unknown-nuttx-elf - riscv64gc-unknown-nuttx-elf - riscv64imac-unknown-nuttx-elf - thumbv6m-nuttx-eabi - thumbv7em-nuttx-eabi - thumbv7em-nuttx-eabihf - thumbv7m-nuttx-eabi - thumbv8m.base-nuttx-eabi - thumbv8m.main-nuttx-eabi - thumbv8m.main-nuttx-eabihf - aarch64-unknown-redox - aarch64-unknown-illumos - riscv32-wrs-vxworks - riscv64-wrs-vxworks (backport <rust-lang#4199>) (cherry picked from commit 0344a78)
Description
This was originally included in the list as a TODO for rust-lang/rust#131319 and should have been done at the same time the c_char definition was updated, just as it was done for rust-lang/rust#122986.
Fixes the following targets:
Link: rust-lang/rust#132975
Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI