Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unsilenceable warnings on GCC 9 #41

Merged
merged 1 commit into from
Feb 25, 2020

Commits on Feb 25, 2020

  1. fix unsilenceable warnings on GCC 9

    See issue rust-lang/rust#69078 for details
    
    ---
    
    [cmake] Disable GCC 9's -Winit-list-lifetime warning in ArrayRef
    
    Summary:
    This is a new warning which fires when one stores a reference to the
    initializer_list contents in a way which may outlive the
    initializer_list which it came from. In llvm this warning is triggered
    whenever someone uses the initializer_list ArrayRef constructor.
    
    This is indeed a dangerous thing to do (I myself was bitten by that at
    least once), but it is not more dangerous than calling other ArrayRef
    constructors with temporary objects -- something which we are used to
    and have accepted as a tradeoff for ArrayRef's efficiency.
    
    Currently, this warnings generates so much output that it completely
    obscures any actionable warnings, so this patch disables it.
    
    Reviewers: rnk, aaron.ballman
    
    Subscribers: mgorny, llvm-commits
    
    Tags: #llvm
    
    Differential Revision: https://reviews.llvm.org/D70122
    
    (cherry picked from commit 6c2151b)
    labath authored and contrun committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    89ad54f View commit details
    Browse the repository at this point in the history