Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default table header padding #823

Closed
sdruskat opened this issue Nov 15, 2018 · 0 comments · Fixed by #824
Closed

Fix default table header padding #823

sdruskat opened this issue Nov 15, 2018 · 0 comments · Fixed by #824
Labels
A-Style Area: Style (CSS, etc.)

Comments

@sdruskat
Copy link
Contributor

When rendering the following table without any modifications to theme, the header contents aren't padded.

| Right | Left |
|------:|:-----|
| Value | One  |
| Value | Two  |

grafik

I guess Markdown parsing has changed at some point, or this corner case wasn't tested?
@sdruskat sdruskat mentioned this issue Nov 15, 2018
Merged
@ehuss ehuss added the A-Style Area: Style (CSS, etc.) label May 17, 2019
@ehuss ehuss closed this as completed in #824 Aug 9, 2019
ehuss added a commit that referenced this issue Aug 9, 2019
@ehuss
Merge pull request #824 from sdruskat/patch-1
0c37b91 
Fix #823: Apply default padding to table headers
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this issue Aug 30, 2020
@sdruskat @ehuss
Fix rust-lang#823: Apply default padding to table headers
6a5211b 
This PR fixes rust-lang#823 by applying the default padding for table cells (`padding: 3px 20px;`) to header cells.
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this issue Aug 30, 2020
@ehuss
Merge pull request rust-lang#824 from sdruskat/patch-1
c2a025d 
Fix rust-lang#823: Apply default padding to table headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Style Area: Style (CSS, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #823: Apply default padding to table headers
2 participants
@ehuss @sdruskat