Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #823: Apply default padding to table headers #824

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Fix #823: Apply default padding to table headers #824

merged 1 commit into from
Aug 9, 2019

Conversation

sdruskat
Copy link
Contributor

This PR fixes #823 by applying the default padding for table cells (padding: 3px 20px;) to header cells.

@sdruskat
Copy link
Contributor Author

This could probably use a test case, but I don't speak any Rust yet (and at the moment lack the time to learn).

@sdruskat
Copy link
Contributor Author

sdruskat commented Nov 15, 2018

Before the change:

grafik

After the change:

grafik

Copy link
Contributor

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build error is caused by a network error.
The conflict is probably caused by the newline at the end of the file.

@Dylan-DPC-zz
Copy link

@sdruksat can you resolve the conflicts? Thanks

This PR fixes #823 by applying the default padding for table cells (`padding: 3px 20px;`) to header cells.
@ehuss
Copy link
Contributor

ehuss commented Aug 9, 2019

I went ahead and rebased this, thanks!

@ehuss ehuss merged commit 0c37b91 into rust-lang:master Aug 9, 2019
@sdruskat
Copy link
Contributor Author

Great, thanks, and sorry for being unresponsive. Holiday times :).

Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
Fix rust-lang#823: Apply default padding to table headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix default table header padding
4 participants