Continued work on "Support right-to-left languages" #1641

cN3rd · 2021-09-03T15:37:03Z

Build on top of the work done by #1489, by:

Add a text_direction attribute to config.
Derive the actual direction via said attribute, or by deriving it from the language.
Expose and use it in the HTML output.
Fix the arrows in the theme with local overrides.

AFAIK the sidebar seems to be fine even with the code.

Feedback welcome, especially on names.

XVilka · 2021-10-12T06:47:09Z

Probably worth to wait for #1662 to be merged first, to autotest these changes.

ivilata · 2022-02-24T11:03:33Z

I did the same test as for #1489, and without needing to manually add dir="rtl" to HTML pages, just by adding text_direction = "rtl" under the [book] section of the TOML file, the output is properly formatted, including the prev/next arrows. Update: text_direction isn't actually needed with a proper language under [book].

@cN3rd, please note that a few changes happened to #1489 a few days ago, you may want to rebase your changes. Thanks a lot!

It fixes rendering issues with prev/next arrows, and it does not need altering HTML after rendering.

jnny · 2022-06-10T22:32:07Z

Adding my support for merging this PR, please! Thanks for your work @cN3rd :)

cN3rd · 2022-06-24T15:11:09Z

Hi @ivilata, finally got to rebase on the changes and even fixed a small bug. The author information got kinda fudged around in the newer commits, but I don't personally mind it.

I think the next step would be to either test this or wait upon the multi-language support. See #5 and #1306.

ivilata · 2022-06-28T09:29:00Z

Thanks a lot @cN3rd! I did a cursory test comparing output from 0411d62 and the newest 304a0df, and nothing seems to have broken in the process, the output looks just as correct. 👍

I'll check #5 and #1306, but in my opinion this PR would already represent a big gain for multi-language support in mdBook. 👏

ywmaa · 2022-12-11T08:37:11Z

how is it going with this pull request ?
I would like to have right to left functionality even if it is not perfect.

mgeisler · 2023-07-31T13:53:08Z

Hey all, we're also starting to need this over in Comprehensive Rust: google/comprehensive-rust#671. I would love to see this merged 😄 Let me add a few comments in case that helps with the review.

mgeisler · 2023-07-31T13:54:49Z

guide/src/format/configuration/general.md

@@ -46,6 +46,9 @@ This is general information about your book.
  `src` directly under the root folder. But this is configurable with the `src`
  key in the configuration file.
 - **language:** The main language of the book, which is used as a language attribute `<html lang="en">` for example.
+  This is also used to derive the direction of text (RTL, LTR) within the book.
+- **text_direction**: The direction of text in the book: Left-to-right (LTR) or Right-to-left (RTL). Possible values: `ltr`, `rtl`.
+  When not specified, the correct text direction is derived from the book's `language` attribute.


I would avoid the word "correct" here since I see text_direction as the "correct" value vs the derived value which is more like a guess:

Suggested change

When not specified, the correct text direction is derived from the book's `language` attribute.

When not specified, the text direction is derived from the book's `language` attribute.

mgeisler · 2023-07-31T13:55:10Z

src/config.rs

@@ -417,6 +417,9 @@ pub struct BookConfig {
    pub multilingual: bool,
    /// The main language of the book.
    pub language: Option<String>,
+    /// The direction of text in the book: Left-to-right (LTR) or Right-to-left (RTL).
+    /// When not specified, the correct text direction is derived from [BookConfig::language].


Suggested change

/// When not specified, the correct text direction is derived from [BookConfig::language].

/// When not specified, the text direction is derived from [BookConfig::language].

mgeisler · 2023-07-31T13:59:18Z

src/config.rs

+        if let Some(direction) = self.text_direction {
+            direction
+        } else {
+            TextDirection::from_lang_code(&self.language.clone().unwrap_or_default())


I believe you can use as_deref instead and avoid the extra clone here. That way you to from Option<String> to Option<&str> to &str without extre allocations:

Suggested change

TextDirection::from_lang_code(&self.language.clone().unwrap_or_default())

TextDirection::from_lang_code(self.language.as_deref().unwrap_or_default())

mgeisler · 2023-07-31T14:04:02Z

src/config.rs

+
+    #[test]
+    fn text_drection_from_lang_code() {
+        // test all right-to-left languages


I would remove these tests: after you've tested both cases (nicely tested above!), the business logic is fully covered.

The tests here don't test anything new. Instead, the tests here end up testing that the list of language codes above match the list of language codes mentioned here.

jnny · 2023-09-01T19:20:31Z

Thanks for resurfacing this PR, @mgeisler! Begging mdbook devs once again to please merge this absolutely necessary PR! As it stands we continue to use @cN3rd's branch as we have a significant Persian userbase.

Manishearth

overall looks like the right approach!

There may need to be some bidi isolation used in a couple places but the best way to discover that is to start using this IMO.

Manishearth · 2023-09-01T19:34:24Z

src/config.rs

+    pub fn from_lang_code(code: &str) -> Self {
+        match code {
+            // list sourced from here: https://github.com/abarrak/rtl/blob/master/lib/rtl/core.rb#L16
+            "ar" | "ara" | "arc" | "ae" | "ave" | "egy" | "he" | "heb" | "nqo" | "pal" | "phn"


not a huge fan; would ideally be based on script tags but for that you need locale canonicalization. Fine for now i guess

Replace phyiscal properties (top/bottom/left/right) with logical properties (start/end) that can be used in non-LTR contexts (e.g., content in Arabic or Hebrew). Based on the CSS Logical Properties and Values Level 1 specification, currently an Editor's Draft [1]. Referencing MDN, all major browsers except Internet Explorer support the margin, padding, and border properties. [1]: https://drafts.csswg.org/css-logical/ Signed-off-by: Tim Crawford <crawfxrd@gmail.com>

This will be necessary for using CSS selectors on root attributes. Signed-off-by: Tim Crawford <crawfxrd@gmail.com>

Fix behavior of some elements when displaying page in RTL. Signed-off-by: Tim Crawford <crawfxrd@gmail.com>

Text direction can selected in the config via the `text_direction` attribute in `book.toml`, or be derived from the book's language.

The test above should cover this sufficiently.

At least to my understanding, the pages will flip in the opposite direction.

ehuss · 2023-09-02T23:57:51Z

I pushed some changes to rebase on master and fix some issues, particularly with some recent CSS changes. I also changed it so that the arrow keys switch direction based on the text direction, since I assume pages flip in the opposite direction.

I suspect there are still a number of issues where it isn't rendering correctly, but I don't know exactly what should be changed.

Thanks everyone! I'm going to go ahead and merge. @mgeisler (or anyone) would be able to check out the latest master and test things out, particularly with different browsers and different OS's and devices?

mgeisler · 2023-09-04T12:14:07Z

Thanks everyone! I'm going to go ahead and merge. @mgeisler (or anyone) would be able to check out the latest master and test things out, particularly with different browsers and different OS's and devices?

Thanks @ehuss! I'll get this set up for one of our in-progress translations for a right-to-left language: google/comprehensive-rust#1164. Then we should be able to quietly test this and hopefully find any major blockers that way.

This updates our `mdbook` version to the latest version in Git. I copied the `index.hbs` file from that version and back-ported our changes into it. I checked English and Danish locally and they both look fine. The new version has support for right-to-left languages: rust-lang/mdBook#1641. We have an in-progress Persian translation. Download the `fa.zip` artifact after building the PR to check how it looks. I checked Persian locally and it looks mirrored like I expect (but we will need someone who can read Persian to actually verify this).

This updates our `mdbook` version to the latest version in Git. I copied the `index.hbs` file from that version and back-ported our changes into it. I checked English and Danish locally and they both look fine. The new version has support for right-to-left languages: rust-lang/mdBook#1641. We have an in-progress Persian translation. Download the `fa.zip` artifact after building the PR to check how it looks. I checked Persian locally and it looks mirrored like I expect (but we will need someone who can read Persian to actually verify this). Fixes #1164.

mgeisler · 2023-09-05T09:53:31Z

Thanks @ehuss! I'll get this set up for one of our in-progress translations for a right-to-left language: google/comprehensive-rust#1164. Then we should be able to quietly test this and hopefully find any major blockers that way.

The message in google/comprehensive-rust#1165 is that the RTL looks good. We'll merge this later today or tomorrow and start using it in our translations.

Thanks @cN3rd for creating this PR and thanks @Manishearth and @ehuss for helping getting it across the finishing line!

Manishearth · 2023-09-05T15:26:46Z

Oh, btw, ICU4X will have LocaleDirectionality APIs in 1.3 (hopefully to be released soon). It's going to be experimental until 1.4 so you need to use an = dep, but it may replace the manual locale matching.

This updates our `mdbook` version to the latest version in Git. I copied the `index.hbs` file from that version and back-ported our changes into it. I checked English and Danish locally and they both look fine. The new version has support for right-to-left languages: rust-lang/mdBook#1641. We have an in-progress Persian translation. Download the `fa.zip` artifact after building the PR to check how it looks. I checked Persian locally and it looks mirrored like I expect (but we will need someone who can read Persian to actually verify this). Fixes #1164.

mgeisler · 2023-09-08T09:05:16Z

We now publish the Persian translation of Comprehensive Rust at https://google.github.io/comprehensive-rust/fa/!

@jnny, this is a small demo of mdbook-i18n-helpers in action on a right-to-left language 🙂

This updates our `mdbook` version to the latest version in Git. I copied the `index.hbs` file from that version and back-ported our changes into it. I checked English and Danish locally and they both look fine. The new version has support for right-to-left languages: rust-lang/mdBook#1641. We have an in-progress Persian translation. Download the `fa.zip` artifact after building the PR to check how it looks. I checked Persian locally and it looks mirrored like I expect (but we will need someone who can read Persian to actually verify this). Fixes google#1164.

moaminsharifi · 2023-10-23T17:04:57Z

Were we supposed to say that we supported RTL? The simplest way to do it is to add dir=rtl to the <html> tag, but where is bi-directional text rendering?

Normally with adding dir=rtl all direction of html page will be right to left but what about english (or any ltr) text? for example:

Neither RTL support nor bidi were available when we started translating the book into Persian (farsi), making it difficult to read.

As mentioned earlier by @mgeisler we added dir=rtl to<html> tag is first step to supporting rtl but bidi is still a thing.
I proposed a simple way to handle it with theme but not the best way:
google/comprehensive-rust#1413

It might be better to also discuss it here.

Manishearth · 2023-10-23T17:21:55Z

I believe bidirectional text is already supported by using more dir attributes on mixed language content. Careful sprinkling of unicode-bidi: embed on things like blockquotes and maybe code blocks is also probably good.

commit b7f46213c7df8f499eca0c82e7b41804cc15e369 Merge: 14826db aa8982b Author: Eric Huss <eric@huss.org> Date: Wed Nov 29 22:54:44 2023 +0000 Merge pull request #2253 from ehuss/bump-version Update to 0.4.36 commit aa8982bdb465c7a25d772700ffc8c68b7bf4eaa7 Author: Eric Huss <eric@huss.org> Date: Wed Nov 29 14:38:18 2023 -0800 Update to 0.4.36 commit 14826db606acc20fb9c2f9747b1ca24ee32a3a05 Merge: 8d4193f 847a582 Author: Eric Huss <eric@huss.org> Date: Wed Nov 29 22:44:41 2023 +0000 Merge pull request #2252 from ehuss/update-lockfile Update dependencies commit 847a5820220024a17cb76115a7393e1b1a698b27 Author: Eric Huss <eric@huss.org> Date: Wed Nov 29 14:36:39 2023 -0800 Update msrv to 1.70 commit 97cd00faebdd856797784b0e1caae9b8c159d6fe Author: Eric Huss <eric@huss.org> Date: Wed Nov 29 14:29:31 2023 -0800 Update dependencies commit 8d4193fb4651bcb9dd0c40a62da72c9cea379d5d Merge: 208d5ea 8d4ae38 Author: Eric Huss <eric@huss.org> Date: Wed Nov 29 22:16:39 2023 +0000 Merge pull request #2229 from leonzchang/fix/normalize-path Fix `mdbook serve` unexpected panic commit 8d4ae388fa237f2406e57b9ea37f449a95884b43 Author: leonzchang <bellerophon00530@gmail.com> Date: Wed Nov 29 11:51:23 2023 +0800 update comment commit 70826898663ee3ccd6b39b982fb197cf99fa31a5 Author: leonzchang <bellerophon00530@gmail.com> Date: Wed Nov 29 11:50:07 2023 +0800 add comment commit 40c034ed3f0282ec7aee794e041ea600936e29b4 Author: leonzchang <bellerophon00530@gmail.com> Date: Wed Nov 29 11:34:08 2023 +0800 apply suggest changes commit 208d5ea7abc19ca47b22032ba2a4a4046ffe0902 Merge: 49fce66 ed51438 Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Sun Nov 26 09:42:25 2023 +0000 Merge pull request #2250 from DuckDuckWhale/master Dep: fix Tungstenite DoS (RUSTSEC-2023-0065) commit ed51438c8bb4421c8bd0e2944589bd3cf51624d9 Author: DuckDuckWhale <software@duckduckwhale.com> Date: Sun Nov 26 01:02:54 2023 -0800 Dep: fix Tungstenite DoS (RUSTSEC-2023-0065) commit 49fce6673aa0386750ddd20e1c136c6288644834 Merge: a016ac0 80d3a86 Author: Eric Huss <eric@huss.org> Date: Fri Nov 24 20:31:14 2023 +0000 Merge pull request #2209 from cyevgeniy/feat/sidebar-resize-indicator Add resize indicator to the sidebar commit a016ac0d2b9d0a1fe2cdcbd7cfdceb6c0212d3a3 Merge: ad55f53 079f52a Author: Eric Huss <eric@huss.org> Date: Fri Nov 24 20:05:37 2023 +0000 Merge pull request #2173 from 0xpr03/master upgrade to notify 6.1.1 and watcher-mini 4.1 commit ad55f5367e536e9fe31ce5b0bab3d41d148c99a3 Merge: 660cbfa 9bc68bd Author: Eric Huss <eric@huss.org> Date: Fri Nov 24 19:59:55 2023 +0000 Merge pull request #2162 from ISSOtm/padding-hljs Fix code blocks "indent" without highlight.js commit 660cbfa6ce5af128106789397b406e3b19ce1447 Merge: 6f6de2c 9826082 Author: Eric Huss <eric@huss.org> Date: Sun Nov 19 13:53:15 2023 +0000 Merge pull request #2243 from wyfo/patch-1 fix typo commit 982608246e6ab34a59509f0e2457bd44ffe1bbde Author: Joseph Perez <joperez@hotmail.fr> Date: Sun Nov 19 14:46:50 2023 +0100 fix typo commit 6f6de2cf056d3ce35d50ad25110dbad60b6b9b58 Merge: dc21f14 ae3e3f8 Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Thu Nov 16 13:44:27 2023 +0000 Merge pull request #2235 from ardcore/improvement/fix-print-margin Make sure page wrapper transform is removed in print mode commit ae3e3f82691164787d00dee9894dc6219425a26f Author: Szymon Pilkowski <szymon.pilkowski@gmail.com> Date: Fri Nov 10 21:51:00 2023 +0100 Make sure page wrapper transform is removed in print mode commit dc21f1497bed2085249ad6fd8537f906ad398ccf Merge: 94e0a44 5c8941b Author: Eric Huss <eric@huss.org> Date: Thu Nov 9 03:32:44 2023 +0000 Merge pull request #2232 from arnetheduck/add-nim Add Nim to default languages commit 5c8941ba167ea647e0635c4b02766ee911ab69ea Author: Jacek Sieka <arnetheduck@gmail.com> Date: Wed Nov 8 15:34:35 2023 +0100 Add Nim to default languages Nim is a systems programming language (included in the highlight.js `system` group), and we're quite happily using `mdBook` in several of our documentation projects starting with our [style guide](https://status-im.github.io/nim-style-guide/). While we can maintain our own highlight.js, including `Nim` in the default distribution would allow us to promote more mdBook usage in the Nim community at the cost of a ~2kb increase in the `highlight.js` size. commit b0a001c6a4c8e170ee291ab7effd027f69e959e1 Author: leonzchang <bellerophon00530@gmail.com> Date: Wed Nov 8 13:35:35 2023 +0800 create relative path through ignore root and path commit 722c55f85f2f258c93ddafd8dc7f13e50377619a Author: leonzchang <bellerophon00530@gmail.com> Date: Wed Nov 1 12:33:13 2023 +0800 normalize path to relative commit 3ab19f32956d71d4435dd37c78ff233a7e0096e4 Author: leonzchang <bellerophon00530@gmail.com> Date: Tue Oct 31 12:22:08 2023 +0800 Revert "bump version v0.4.36" This reverts commit 621ffc46c053147176e9e1589c7131f3b6ac2f57. commit 621ffc46c053147176e9e1589c7131f3b6ac2f57 Author: leonzchang <bellerophon00530@gmail.com> Date: Tue Oct 31 12:14:28 2023 +0800 bump version v0.4.36 commit fbb629c02e78821a24ccf9c1a6afb82057da4bf6 Author: leonzchang <bellerophon00530@gmail.com> Date: Tue Oct 31 12:13:25 2023 +0800 normalize path in watch cmd commit 80d3a86468c8f6b0be720e9fa7aaf629bd9e0f44 Author: Evgeny Chaban <ychbn@ychbn.com> Date: Wed Oct 4 01:55:20 2023 +0300 fix: hide resize indicator on devices with limited accuracy commit 8e8fd2717ed72739eb5b40601e311c022ba4c99e Author: Evgeny Chaban <ychbn@ychbn.com> Date: Wed Oct 4 01:40:16 2023 +0300 fix(style): use calc function commit f92d24e89c3f7abd3d8fff6ba681f94d3188e01f Author: Evgeny Chaban <ychbn@ychbn.com> Date: Mon Oct 2 18:24:55 2023 +0300 feat(sidebar): add sidebar indicator commit 94e0a44e152d8d7c62620e83e0632160977b1dd5 Merge: 0583119 f25181f Author: Eric Huss <eric@huss.org> Date: Fri Sep 29 22:43:05 2023 +0000 Merge pull request #2206 from ehuss/bump-version Update to 0.4.35 commit f25181f68dee2d72266f3ca1ff84753ec3d8d64f Author: Eric Huss <eric@huss.org> Date: Fri Sep 29 14:33:45 2023 -0700 Update to 0.4.35 commit cf19eb13866cf4a9322fd14cb4c0cf34c3706c19 Author: Eric Huss <eric@huss.org> Date: Fri Sep 29 14:33:20 2023 -0700 Fix `text-direction` in documentation. commit 0583119698c379fbd99497006a536d30288f1067 Merge: c642f5f 3389f3d Author: Eric Huss <eric@huss.org> Date: Fri Sep 22 17:26:27 2023 +0000 Merge pull request #2197 from dluschan/patch-1 Update index.hbs commit 3389f3db7f6ac6f6ca1ff36e5eafe7abdb5798e4 Author: Dmitry Luschan <dluschan@gmail.com> Date: Tue Sep 19 20:44:39 2023 +0600 Update index.hbs Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. commit c642f5f8a331c68166c363c51762057d21c44fb9 Merge: d5b1676 ceb8b50 Author: Eric Huss <eric@huss.org> Date: Sat Sep 9 20:13:10 2023 +0000 Merge pull request #2187 from notriddle/notriddle/warning-block Add `.warning` class for doc author use commit ceb8b509e2ce0646f94a5e3e910508fdef1cfc00 Author: Michael Howell <michael@notriddle.com> Date: Fri Sep 8 13:27:02 2023 -0700 Add more guides to stock CSS classes commit 65dae11e470450bddbe8451e7c3b5d27ca01f30a Author: Michael Howell <michael@notriddle.com> Date: Fri Sep 8 13:14:54 2023 -0700 Add `.warning` class for doc author use This is designed to be compatible with rustdoc's version, in https://github.com/rust-lang/rust/pull/106561 commit d5b1676216229e176a4a7efcca048e340a0c96ad Merge: 09f222b c9f1d01 Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Mon Sep 4 18:03:38 2023 +0000 Merge pull request #2168 from pickfire/prefetch Add prefetch to next link commit 09f222baf7d6c05caa48354b3472a09ebb2ae296 Merge: 25aaff0 802e7bf Author: Eric Huss <eric@huss.org> Date: Sat Sep 2 23:57:48 2023 +0000 Merge pull request #1641 from cN3rd/rtl Continued work on "Support right-to-left languages" commit 802e7bffc3d81b868ede46fa0cb91e68009f6c96 Author: Eric Huss <eric@huss.org> Date: Sat Sep 2 16:44:47 2023 -0700 Make the arrow keys honor RTL. At least to my understanding, the pages will flip in the opposite direction. commit fb272d1afa7761a3b9c7da34cb861f030294ac06 Author: Eric Huss <eric@huss.org> Date: Sat Sep 2 16:43:21 2023 -0700 Fix theme selector for RTL. commit b871676def4bda9be5f280ab6b6e80a59db5628c Author: Eric Huss <eric@huss.org> Date: Sat Sep 2 16:43:13 2023 -0700 Fix sidebar behavior with RTL. commit 869fe2f50d372b25f7ef8ccd9a10db22a8bc8de6 Author: Eric Huss <eric@huss.org> Date: Sat Sep 2 16:42:53 2023 -0700 Remove text_drection_from_lang_code The test above should cover this sufficiently. commit db877b1c9bdff545b97b94fa244e9f920ecee3e6 Author: Eric Huss <eric@huss.org> Date: Sat Sep 2 16:42:14 2023 -0700 Update language list to include missing rtl languages. commit 4749f9d97a7a9bc7b489cfccc342f110544ec458 Author: Eric Huss <eric@huss.org> Date: Sat Sep 2 16:41:59 2023 -0700 Some minor corrections from code review. commit 8564a7fb51f83f39b01618ec14d3e68d98e7ac48 Author: cN3rd <sub.in.tokyo@gmail.com> Date: Fri Jun 24 15:00:46 2022 +0000 Add proper test to inline code within the book. commit 6be98e0bbd2cfd0d8f016823ea026afa704d3119 Author: cN3rd <sub.in.tokyo@gmail.com> Date: Fri Jun 24 15:00:02 2022 +0000 Ensure code segments always render in LTR commit 5e0c68c45e07e3dfa943558539a6d7e2819437bc Author: cN3rd <subs.in.tokyo@gmail.com> Date: Fri Sep 3 17:53:49 2021 +0300 Fix icons when using RTL commit 7717b9dcf26a1250f859c17101affc9e00c126c0 Author: cN3rd <subs.in.tokyo@gmail.com> Date: Fri Sep 3 18:33:04 2021 +0300 Support `text_direction` attribute in HTML output commit 819a108f073c84d835407ea0fe1ff322bd1cf238 Author: cN3rd <subs.in.tokyo@gmail.com> Date: Fri Sep 3 18:31:39 2021 +0300 Add `text_direction` property in general book metadata Text direction can selected in the config via the `text_direction` attribute in `book.toml`, or be derived from the book's language. commit 3a998991141417e4b4d1671c90c8ff9a9398788b Author: Tim Crawford <crawfxrd@gmail.com> Date: Tue Mar 16 23:23:13 2021 -0600 Use CSS selectors to override properties for RTL Fix behavior of some elements when displaying page in RTL. Signed-off-by: Tim Crawford <crawfxrd@gmail.com> commit 1088066c69e9a63ead7a8e798be22752e35d22ae Author: Tim Crawford <crawfxrd@gmail.com> Date: Tue Mar 16 23:21:40 2021 -0600 Move sidebar, js classes from html to body element This will be necessary for using CSS selectors on root attributes. Signed-off-by: Tim Crawford <crawfxrd@gmail.com> commit 73d44503fdcb2210796ed43e45748798ac443596 Author: Tim Crawford <crawfxrd@gmail.com> Date: Mon Mar 15 17:42:44 2021 -0600 Use logical CSS properties Replace phyiscal properties (top/bottom/left/right) with logical properties (start/end) that can be used in non-LTR contexts (e.g., content in Arabic or Hebrew). Based on the CSS Logical Properties and Values Level 1 specification, currently an Editor's Draft [1]. Referencing MDN, all major browsers except Internet Explorer support the margin, padding, and border properties. [1]: https://drafts.csswg.org/css-logical/ Signed-off-by: Tim Crawford <crawfxrd@gmail.com> commit 25aaff0bd656c251d4e6cccf3970f066ea55641e Merge: a74e4dc 2969146 Author: Eric Huss <eric@huss.org> Date: Sat Sep 2 13:41:15 2023 +0000 Merge pull request #2182 from cuishuang/master remove the repetitive word commit 29691461c5da85cd659c2c634586045c7381e1ac Author: cui fliter <imcusg@gmail.com> Date: Sat Sep 2 14:04:32 2023 +0800 remove the repetitive word Signed-off-by: cui fliter <imcusg@gmail.com> commit a74e4dcec86ad3519e9fda248d0a85f4e7e86acc Merge: 02f3823 0b0b548 Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Fri Sep 1 08:55:38 2023 +0000 Merge pull request #2181 from tshepang/patch-1 docs: future expansion to non-Rust testing already implied commit 0b0b548d7ae7f6aa9fdcd8d17bbc03e0daf62c61 Author: Tshepang Mbambo <tshepang@gmail.com> Date: Fri Sep 1 05:11:18 2023 +0200 docs: future expansion to non-Rust testing already implied commit 02f3823e4caae28cc0b1ceac284f81743f8fd29b Merge: 56c225b 36327ef Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Thu Aug 24 13:11:14 2023 +0000 Merge pull request #2175 from qaqland/sidebar-pure-css Sidebar but Pure CSS, fix rust-lang/mdBook#859 commit 36327efe9d8f2f118c4d200b09ff3a080118d57b Author: qaqland <qaq@qaq.land> Date: Thu Aug 24 16:44:25 2023 +0800 Sidebar but Pure CSS, fix rust-lang/mdBook#859 * change sidebar-toggle button by input:checked and label * change nav-wrappers' CSS selectors * remove loading animation when page opens with z-index commit 079f52a19125d1dae78272f1a235c4d5823611e8 Author: Aron Heinecke <Ox0p54r36@t-online.de> Date: Mon Aug 21 19:29:59 2023 +0200 upgrade to notify 6.1.1 and watcher-mini 4.1 commit c9f1d0134661a71bdd48cfdf984edfa8780da13f Author: Ivan Tham <pickfire@riseup.net> Date: Thu Aug 17 00:50:47 2023 +0800 Add prefetch to next link Fix #1975 commit 9bc68bdd93accbc21ae65077f2e4e61e3748e4b8 Author: Eldred Habert <eldredhabert0@gmail.com> Date: Tue Aug 8 12:31:55 2023 +0200 Fix code blocks "indent" without highlight.js The `.hljs` class added by highlight.js adds a `display: block` rule which makes `padding` apply correctly (left padding on all lines, not just the first one). Make sure that rule is applied even if highlight.js isn't run. commit 56c225bd34760eb6de024b67b42729e4a55b6302 Merge: 7849d55 55c017c Author: Eric Huss <eric@huss.org> Date: Sat Aug 5 21:54:12 2023 +0000 Merge pull request #2158 from ehuss/bump-version Update to 0.4.34 commit 55c017cad19239976250af4d7771daa9fa140dc2 Author: Eric Huss <eric@huss.org> Date: Sat Aug 5 14:34:42 2023 -0700 Update to 0.4.34 commit 7849d55b99118d1df4bdebb58c12ba45f4a31f7a Merge: 57b487e c903cc8 Author: Eric Huss <eric@huss.org> Date: Sat Aug 5 20:35:33 2023 +0000 Merge pull request #2157 from ehuss/macos-notify-copy Add workaround for macOS notify problem. commit c903cc88278d66e4e9e2118985ba5cb4c9b6aa94 Author: Eric Huss <eric@huss.org> Date: Sat Aug 5 13:17:23 2023 -0700 Add workaround for macOS notify problem. commit 4a797b956590bdeaba0ae637da5a02dac1a94ec6 Author: Eric Huss <eric@huss.org> Date: Sat Aug 5 12:53:23 2023 -0700 Revert "Merge pull request #2152 from ehuss/macos-notify-kqueue" This reverts commit 347e7886e117dacdd1cb8bcc0e269dfed50d80ff, reversing changes made to a8fd6038f16ddb5ed0dd1ba5502cebcf18cd6428. commit 57b487eaa3772a2f7ba55084996fd802d31f7b73 Merge: f7e212e 891b7c0 Author: Eric Huss <eric@huss.org> Date: Fri Aug 4 00:11:45 2023 +0000 Merge pull request #2154 from ehuss/bump-version Update to 0.4.33 commit 891b7c06f26662b3e9ceccb783f5517a90d52d6b Author: Eric Huss <eric@huss.org> Date: Thu Aug 3 17:03:40 2023 -0700 Update to 0.4.33 commit f7e212ec9c743bb78ad95ce6fd73d16495307d45 Merge: 347e788 228538e Author: Eric Huss <eric@huss.org> Date: Thu Aug 3 22:46:50 2023 +0000 Merge pull request #2150 from proski/header-code-background Don't use distinct background for code in headers when printing commit 228538ea628232e1f4a943424758284065755819 Author: Pavel Roskin <plroskin@gmail.com> Date: Tue Aug 1 09:49:09 2023 -0700 Don't use distinct background for code in headers when printing Fixes #1933 commit 347e7886e117dacdd1cb8bcc0e269dfed50d80ff Merge: a8fd603 bfa5fb8 Author: Eric Huss <eric@huss.org> Date: Wed Aug 2 22:13:09 2023 +0000 Merge pull request #2152 from ehuss/macos-notify-kqueue Switch macOS notify to kqueue. commit bfa5fb884411dcd9c663f7ac5d9194050a71a361 Author: Eric Huss <eric@huss.org> Date: Wed Aug 2 09:21:25 2023 -0700 Switch macOS notify to kqueue. commit a8fd6038f16ddb5ed0dd1ba5502cebcf18cd6428 Merge: ab2cb71 fbfe887 Author: Eric Huss <eric@huss.org> Date: Wed Aug 2 15:49:44 2023 +0000 Merge pull request #2151 from ehuss/revert-toml Revert toml update commit fbfe887084b12d19b4c77e4d454b6708dc0b6b8d Author: Eric Huss <eric@huss.org> Date: Wed Aug 2 08:39:17 2023 -0700 Add note to not update toml. commit aed991f75fa5e5c2bd15d717d6e7084a0f0a6b9c Author: Eric Huss <eric@huss.org> Date: Wed Aug 2 08:32:44 2023 -0700 Revert "Merge pull request #2125 from ehuss/update-toml" This reverts commit 89797064b85b775c1b5e2d7d4980bc18bd010df4, reversing changes made to 7824aed878aa11046ad72dc7222efd666dce48e9. commit ab2cb71c00b1556f83f69c494f176019b8863c20 Merge: 4614a36 fcfde08 Author: Eric Huss <eric@huss.org> Date: Sun Jul 30 22:50:08 2023 +0000 Merge pull request #2134 from GiorgioReale/master Enhancing themes with `color-scheme: light | dark;` implementation in CSS commit fcfde083e7d67af9feb6cf4ecca71d90d9d97215 Author: Giorgio Reale <accounts@giorgioreale.xyz> Date: Tue Jul 18 22:50:45 2023 +0200 Enhancing themes with `color-scheme: light | dark;` implementation in CSS commit 4614a3637a70ca2fd5a8f558673470cbc0d0f0d3 Merge: d450544 e00b883 Author: Eric Huss <eric@huss.org> Date: Sun Jul 30 17:08:46 2023 +0000 Merge pull request #2146 from riverbl/fix-extra-watch-dirs Fix issues with extra-watch-dirs commit d450544d6be71c1ef4b4baa98ddbd68f3d73578b Merge: 429ca06 9340e6a Author: Eric Huss <eric@huss.org> Date: Sat Jul 29 16:23:04 2023 +0000 Merge pull request #2148 from ehuss/fix-merge-queue Use a better merge-queue success check. commit 9340e6a78d1f43b9a1295f1ca2848c7ab5f2fb07 Author: Eric Huss <eric@huss.org> Date: Sat Jul 29 09:13:55 2023 -0700 Use a better merge-queue success check. commit e00b8835cca59da9f3aca9e267eaa65ff877078f Author: riverbl <94326797+riverbl@users.noreply.github.com> Date: Fri Jul 28 18:19:56 2023 +0100 Fix issues with extra-watch-dirs Fix paths specified in extra-watch-dirs being relative to the current working directory rather than the book root If there is an error canonicalising paths in extra-watch-dirs, log the error and exit rather than panicking commit 429ca0628994c11962c1211fec06f31d1e174101 Merge: 581e502 0fbfc90 Author: Eric Huss <eric@huss.org> Date: Mon Jul 24 20:35:16 2023 -0700 Merge pull request #2140 from ehuss/merge-queue-workflow Prepare CI workflows to support merge queues. commit 0fbfc90bead9473bfd3a06c34ae4b9188035822c Author: Eric Huss <eric@huss.org> Date: Mon Jul 24 20:16:07 2023 -0700 Prepare CI workflows to support merge queues. commit 581e5025a2342353a69a23152b255fd7819f8f10 Merge: d5a3682 e57fce2 Author: Eric Huss <eric@huss.org> Date: Fri Jul 21 07:32:56 2023 -0700 Merge pull request #2139 from tshepang/patch-1 misplaced bracket commit e57fce290bb27ea2bdaaf2b75024e99a12ede406 Author: Tshepang Mbambo <tshepang@gmail.com> Date: Fri Jul 21 15:29:56 2023 +0200 misplaced bracket commit d5a3682de95c72bfa09e29086d51db24b5af79c5 Merge: aed518f 75f5862 Author: Eric Huss <eric@huss.org> Date: Wed Jul 19 08:06:35 2023 -0700 Merge pull request #2137 from ehuss/mdbook-case-link Fix link on case-sensitive filesystems. commit 75f5862218aac807ca9848eb39bfc74491411429 Author: Eric Huss <eric@huss.org> Date: Wed Jul 19 07:54:39 2023 -0700 Fix link on case-sensitive filesystems. commit aed518f945bb5729feee2301f02123e3284c74ed Merge: e942d41 38fcfd8 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 17:43:49 2023 -0700 Merge pull request #2129 from ehuss/bump-version Update to 0.4.32 commit e942d41c1d97a0992b333c6ac465481da410201c Merge: 82ec681 9497354 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 17:38:21 2023 -0700 Merge pull request #2128 from ehuss/release-token-perms deploy: Rewrite and update permissions commit 38fcfd8732d513eaf36cc91da53989bb6cb8db11 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 17:35:51 2023 -0700 Update to 0.4.32 commit 82ec68128dc66629da3f6bc2e8f27f4b23db9dbd Merge: 49ba919 0f25db6 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 17:28:50 2023 -0700 Merge pull request #2127 from ehuss/auto-publish Automatically publish to crates.io on new release commit 9497354cfde664e46540fa2436ba79c0ea3b3d90 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 17:16:15 2023 -0700 Rewrite asset deploy. This switches to `gh` which is the more modern CLI, and also available by default which removes the old installer script. This also tightens the scope where GITHUB_TOKEN is exposed to just the step where `gh` is executed. Finally, it tightens the permissions on the GITHUB_TOKEN (though `contents: write` is extremely permissive, since that allows writing to almost anything in the repo). commit baa936439df48fc6f42925a5efc62bb0fc797d46 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 16:40:11 2023 -0700 deploy: Set the default shell so it doesn't need to be repeated. commit 394061d28dcc78206a4f27aff6cc097149bd8132 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 16:39:11 2023 -0700 Rename make-release.sh to make-release-asset.sh This is to better reflect what the script does. commit 0f25db67dc99edf06d52e077b89e02961d7e43aa Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 15:56:04 2023 -0700 Automatically publish to crates.io on new release commit 49ba91961f361d9437eb71481cfd39a7547e3666 Merge: 8979706 28ce772 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 13:32:55 2023 -0700 Merge pull request #2126 from ehuss/update-deps Update dependencies commit 28ce772ae9dc5d5d959374048047e21c221de7a1 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 13:21:45 2023 -0700 Update msrv to 1.66. commit 424c2d9f6be0bbe3721a358b61addc73433ee3b3 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 13:09:52 2023 -0700 Update dependencies commit 89797064b85b775c1b5e2d7d4980bc18bd010df4 Merge: 7824aed b423bf7 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 13:08:40 2023 -0700 Merge pull request #2125 from ehuss/update-toml Update toml to 0.7.6 commit 7824aed878aa11046ad72dc7222efd666dce48e9 Merge: 8236c43 db45052 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 12:51:51 2023 -0700 Merge pull request #2124 from ehuss/update-predicates Update predicates to 3.0.3 commit 8236c43c90162504e5fcbf82a0a0f0ad66335bc3 Merge: 6df89fb 804bbf6 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 12:50:17 2023 -0700 Merge pull request #2123 from ehuss/update-notify Update notify to 6.0.1 commit 6df89fbe94a9bb01ab64d0e62600608d2770344f Merge: cdbdb82 bd3b9ba Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 12:50:10 2023 -0700 Merge pull request #2122 from ehuss/update-opener Update opener to 0.6.1 commit b423bf7ddd5f0371e2ebedb6c1c93b0ade508862 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 12:48:01 2023 -0700 Update toml to 0.7.6 commit cdbdb8248c4dab229298089c2cf577b883fec050 Merge: cf88c4e 5505d57 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 12:43:44 2023 -0700 Merge pull request #2121 from ehuss/update-clap Update to clap 4.3.12 commit db45052d7e090b38616290280035b59907474925 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 12:42:44 2023 -0700 Update predicates to 3.0.3 commit 804bbf6564c8b2789c54af1185e12dac4e951ec5 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 12:40:45 2023 -0700 Update notify to 6.0.1 commit bd3b9bacf64febb0ad0c07992955f175431f3297 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 12:37:23 2023 -0700 Update opener to 0.6.1 commit 5505d57066f1c9c4f55a0853edfaa0586a29091a Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 12:33:53 2023 -0700 Update to clap 4.3.12 commit cf88c4e720f5ac6be5a133a7303f872edb4edcd5 Merge: 9911e86 6d265c1 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 10:59:37 2023 -0700 Merge pull request #2116 from Stargateur/patch-1 Add oh-my-zsh quick exemple to shell completions commit 9911e86039f5b58b4ef9960d041963681e398ff4 Merge: 904aa53 9eba0f6 Author: Eric Huss <eric@huss.org> Date: Sun Jul 16 10:55:53 2023 -0700 Merge pull request #2118 from zica87/zica87-patch-1 Fix theme-color meta tag not syncing with the theme commit 9eba0f6ab2c41daca5c57f9b8f727741602e9212 Author: zica <59327276+zica87@users.noreply.github.com> Date: Sun Jul 9 08:57:46 2023 +0800 Fix theme-color meta tag not syncing with the theme commit 6d265c1ccee5dafbb97b7167c0a1a6ed9fd4fd02 Author: Antoine <plaskowski.stanislas@gmail.com> Date: Sat Jul 8 13:48:51 2023 +0200 Add oh-my-zsh quick exemple to shell completions I have trouble to find this information, doesn't cost must to add it here. commit 904aa530b5f59387f19feb0dbe0e959de3f247d2 Merge: 41d19e7 fa316f3 Author: Eric Huss <eric@huss.org> Date: Thu Jun 29 13:10:11 2023 -0700 Merge pull request #2111 from ehuss/bump-version Update to 0.4.31 commit fa316f3edcd4945c656651dcc6ce5256448934b9 Author: Eric Huss <eric@huss.org> Date: Thu Jun 29 12:33:55 2023 -0700 Update to 0.4.31 commit 41d19e7338e671964a4daae2d0c37f3d5b941ea2 Merge: 222166c 4f15a3f Author: Eric Huss <eric@huss.org> Date: Thu Jun 29 12:31:38 2023 -0700 Merge pull request #2110 from ehuss/strikethrough-single Document that strikethrough can also use a single tilde. commit 4f15a3f85c811c7125be28c9eb88768324f695f3 Author: Eric Huss <eric@huss.org> Date: Thu Jun 29 12:27:06 2023 -0700 Document that strikethrough can also use a single tilde. commit 222166ca5a712899ed2f2cab7a0f74f5a8d37155 Merge: f37486a ab3eb81 Author: Eric Huss <eric@huss.org> Date: Thu Jun 29 12:22:50 2023 -0700 Merge pull request #2109 from ehuss/update-proc-macro2 Update proc-macro2 commit ab3eb81e5270dc9a39d17221a09786aa322ceab3 Author: Eric Huss <eric@huss.org> Date: Thu Jun 29 10:57:45 2023 -0700 Update proc-macro2 commit f37486a74fd6a4453ea00f6f9c0ab40d5eb2e211 Merge: e18113a a38b854 Author: Eric Huss <eric@huss.org> Date: Sun Jun 25 11:54:23 2023 -0700 Merge pull request #2106 from ehuss/spelling Fix some spellings commit a38b85433830230478a94172f36728b0e6c40b0f Author: Eric Huss <eric@huss.org> Date: Sun Jun 25 11:37:53 2023 -0700 Fix some spellings commit e18113a746df4287fd6feb944a84c928dfa63593 Merge: d4edbd1 72b3227 Author: Eric Huss <eric@huss.org> Date: Sun Jun 25 11:29:27 2023 -0700 Merge pull request #2104 from zqianem/gh-443/sidebar-scroll Fix flicker when setting sidebar scroll position commit d4edbd1acfb683e5e52a9d5717b5ea839ba813ab Merge: a51f8a6 056e45a Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Sat Jun 24 20:38:35 2023 +0530 Merge pull request #2105 from Spartan2909/patch-1 Fix typo commit 056e45a0039a5ca4630a57a9c15cee6dc2f8f866 Author: Caleb Robson <94545082+Spartan2909@users.noreply.github.com> Date: Sat Jun 24 15:35:40 2023 +0100 Fix typo commit 72b3227824712e57a2a03f44174aabd768f9c1ea Author: Em Zhan <zqianem@gmail.com> Date: Wed Jun 21 19:18:54 2023 -0500 Fix flicker when setting sidebar scroll position Previously, sidebar scroll was set in an external script which caused a flicker as the sidebar is initially rendered without any scroll before being scrolled to the desired location. Switching to an inline script right after the HTML tags for the sidebar seems to avoid the flicker in most cases. In addition, logic is added to avoid scrolling jumps when navigating via links within the sidebar. commit a51f8a6b8e9aa609e1a54ea8865395cbf738d8ee Merge: a204946 1ef8d70 Author: Eric Huss <eric@huss.org> Date: Mon Jun 19 13:21:08 2023 -0700 Merge pull request #2101 from zqianem/gh-443/menu-border Avoid menu border flash during page navigation commit 1ef8d70ac466cf12772eb0cb74d6b2feed4b64f1 Author: Em Zhan <zqianem@gmail.com> Date: Sat Jun 17 21:40:39 2023 -0500 Avoid menu border flash during page navigation Partially addresses #443 commit a204946d39db89db242783afb3f27a0f75189589 Merge: 9349204 3c7795c Author: Eric Huss <eric@huss.org> Date: Wed Jun 7 10:01:06 2023 -0700 Merge pull request #2096 from tshepang/patch-1 main branch is not always "master" these days commit 3c7795cf44d4845bb2a944d1cf9c63d6e3e5a118 Author: Tshepang Mbambo <tshepang@gmail.com> Date: Wed Jun 7 18:47:15 2023 +0200 main branch is not always "master" these days commit 9349204636744ef5100abcf8ebc7a2c4675284fc Merge: 61708ad d2bcd04 Author: Eric Huss <eric@huss.org> Date: Sun May 28 15:06:19 2023 -0700 Merge pull request #2094 from ehuss/bump-version Update to 0.4.30 commit d2bcd04133b9c7768a5b9afb06e7d474c1c278ee Author: Eric Huss <eric@huss.org> Date: Sun May 28 14:54:05 2023 -0700 Update to 0.4.30 commit 61708ad0bd733910aac382accfc4d1b4e176d055 Merge: 3a51abf c9cfe22 Author: Eric Huss <eric@huss.org> Date: Sun May 28 14:21:54 2023 -0700 Merge pull request #2093 from ehuss/hiddenlines Support hidden lines in languages other than Rust commit c9cfe22fd60462726db58bde8266be052aaa5de7 Author: Eric Huss <eric@huss.org> Date: Sun May 28 13:51:30 2023 -0700 Apply some code style changes. commit 5572d3d4de1870968bff55c2ee8ca81839f1255e Author: Eric Huss <eric@huss.org> Date: Sun May 28 13:50:34 2023 -0700 Expand on hidelines documentation. commit 1441fe0b9152daeb2b86f47a153206fa2aa565cc Author: Eric Huss <eric@huss.org> Date: Sun May 28 13:50:21 2023 -0700 Explicitly document the `hidelines` key. commit 7df1d8c838c0e21968666b671885ac185a426fd7 Author: Jannik Obermann <jannik.obermann@gmail.com> Date: Wed Feb 23 01:02:54 2022 +0100 Support hidden lines in languages other than Rust Co-Authored-By: thecodewarrior <5467669+thecodewarrior@users.noreply.github.com> commit 3a51abfcadb90be71199ddf357d74f3300cce1e1 Merge: 870e908 1db52ff Author: Eric Huss <eric@huss.org> Date: Sun May 28 12:16:26 2023 -0700 Merge pull request #2013 from ImUrX/heading-extension Add heading extension support commit 870e9086dc0e25c20863d39fdff6f51c96430fae Merge: 4f1b5ea bbc32df Author: Eric Huss <eric@huss.org> Date: Sun May 28 12:12:26 2023 -0700 Merge pull request #2092 from ehuss/update-pulldown-cmark Update pulldown-cmark to 0.9.3 commit 1db52ff53170a8c3ea28ef248082946da11a256d Author: Eric Huss <eric@huss.org> Date: Sun May 28 11:55:56 2023 -0700 Fix search for custom heading attributes commit e3be293420665d81aa7b1677aed9ad2f3e557b3c Author: Eric Huss <eric@huss.org> Date: Sun May 28 11:33:58 2023 -0700 Add an integration test for heading attributes commit bbc32dff8248c55df1e87030f68cd184300c8351 Author: Eric Huss <eric@huss.org> Date: Sun May 28 12:00:00 2023 -0700 Update pulldown-cmark to 0.9.3 commit 861197e61cc57239483246034299d6d5a4208108 Author: Eric Huss <eric@huss.org> Date: Sun May 28 11:33:24 2023 -0700 Add a test to the test_book for custom heading attributes commit 34e5ef22a099416300b4ba68a714c98539009c54 Author: Eric Huss <eric@huss.org> Date: Sun May 28 11:32:31 2023 -0700 Don't include empty class attribute. commit b141297651f2e89a1466b39af250f0c5e1b363c6 Author: Eric Huss <eric@huss.org> Date: Sun May 28 11:31:35 2023 -0700 Update documentation for heading attributes commit 0cb977e603bc4c736bc82baeb9f4bf1f93201f6c Author: Uriel <urielfontan2002@gmail.com> Date: Sun Mar 5 07:04:26 2023 -0300 docs suggestion Co-authored-by: Eric Huss <eric@huss.org> commit c8a5adcee9ce27f06a4477fc424075cb3d09af30 Author: ImUrX <urielfontan2002@gmail.com> Date: Sun Feb 12 05:00:31 2023 -0300 fix more mistakes commit ecdb411711ba1b52d982ce5c060d229da8b8420b Author: ImUrX <urielfontan2002@gmail.com> Date: Sun Feb 12 04:29:33 2023 -0300 fix mistakes commit a4e206168dee6a3293ab9d3a72a51a430e705f7c Author: ImUrX <urielfontan2002@gmail.com> Date: Thu Feb 9 03:58:54 2023 -0300 Add working heading extension commit 4f1b5eae54f1f26a5d170b8d9ea0326d1e8548c3 Merge: 1b3922d 54f14e8 Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Thu May 25 10:37:34 2023 +0530 Merge pull request #2091 from zjj/master Update test_book highlight.md commit 54f14e89cf88c2fc6367c26e8685fe55a2a002a6 Author: zjj <zhong2plus@gmail.com> Date: Thu May 25 12:04:43 2023 +0800 Update test_book highlight.md Add missing bash annotation commit 1b3922d466b562a1a1a5e213cbfecf7c8d48beb0 Author: Eric Huss <eric@huss.org> Date: Sat May 13 12:52:42 2023 -0700 Fix typo commit 00a30a998457972414fd49ed71a9de0c297908bf Merge: 4d229d7 db6699d Author: Eric Huss <eric@huss.org> Date: Sat May 13 12:35:36 2023 -0700 Merge pull request #2087 from ehuss/bump-version Update to 0.4.29 commit db6699dae22a3218593626feb224f6ebf4183ec5 Author: Eric Huss <eric@huss.org> Date: Sat May 13 12:26:29 2023 -0700 Update to 0.4.29 commit 4d229d7b942ee2016b62003032a9a04e589cb048 Merge: 0992173 d94c5f8 Author: Eric Huss <eric@huss.org> Date: Sat May 13 12:20:46 2023 -0700 Merge pull request #2086 from ehuss/sync-cargo.toml Set minimum versions in Cargo.toml commit d94c5f8380f4e21ccc370569e1f171362edabfc6 Author: Eric Huss <eric@huss.org> Date: Sat May 13 12:01:03 2023 -0700 Set minimum versions in Cargo.toml commit 099217390e9586e547135a99998a4f3ab24a2107 Merge: d746b23 4c4ab8a Author: Eric Huss <eric@huss.org> Date: Sat May 13 11:05:00 2023 -0700 Merge pull request #2085 from ehuss/update-clap Update clap commit 4c4ab8a57d7409bcf45f103282a2be1ed98aac7d Author: Eric Huss <eric@huss.org> Date: Sat May 13 10:53:22 2023 -0700 Update clap commit d746b237499d257820a48df6351538c892416612 Merge: 3c54a4d f77c597 Author: Eric Huss <eric@huss.org> Date: Sat May 13 10:49:39 2023 -0700 Merge pull request #2084 from ehuss/update-indirect Update some indirect dependencies commit f77c597e013080606719b06b7688ca37a87925e9 Author: Eric Huss <eric@huss.org> Date: Sat May 13 10:16:26 2023 -0700 Update some indirect dependencies commit 3c54a4d33b9fef0ef0123c7e5e7a0c2bdea60c0e Merge: cf9de82 c3155e2 Author: Eric Huss <eric@huss.org> Date: Sat May 13 10:15:38 2023 -0700 Merge pull request #2083 from ehuss/fix-clippy Apply some clippy fixes commit cf9de82c2afdac4fd9b275061bbb86b57d2941cf Merge: f4507ae be966cf Author: Eric Huss <eric@huss.org> Date: Sat May 13 09:56:47 2023 -0700 Merge pull request #2082 from ehuss/update-direct-dependencies Update some direct dependencies commit c3155e264225e088f6ff48c42e93583593a07555 Author: Eric Huss <eric@huss.org> Date: Sat May 13 09:55:51 2023 -0700 Apply clippy::match_like_matches_macro commit d8f171a99643e96f0199682c0d088970505e3cbb Author: Eric Huss <eric@huss.org> Date: Sat May 13 09:50:32 2023 -0700 Apply clippy::manual_while_let_some commit 0ef3bb1cc635c60a7acc8bc6222f732e60acd70f Author: Eric Huss <eric@huss.org> Date: Sat May 13 09:46:30 2023 -0700 Apply clippy::needless_borrowed_reference commit 54df8234ed6466571cd18148b8e577e35d02980b Author: Eric Huss <eric@huss.org> Date: Sat May 13 09:45:46 2023 -0700 Apply clippy::let_unit_value commit dc08e373209146d4bf4dd2957b74128b76dfd355 Author: Eric Huss <eric@huss.org> Date: Sat May 13 09:44:50 2023 -0700 Apply clippy::borrow_deref_ref commit 45a8575b95107a4fc385936db3508b4043423c98 Author: Eric Huss <eric@huss.org> Date: Sat May 13 09:44:11 2023 -0700 Apply clippy::needless_borrow commit be966cfe1f5f7da7091dde61a96295a179b6f4b8 Author: Eric Huss <eric@huss.org> Date: Sat May 13 09:27:32 2023 -0700 Raise MSRV to 1.65 commit f4507aeb9b3371c9bab5fb561d7eeeaefac34f5b Merge: 71ea92b 0104784 Author: Eric Huss <eric@huss.org> Date: Sat May 13 09:19:06 2023 -0700 Merge pull request #2080 from t2y/fix-copy-fonts-message Fix handling of copy-fonts=true when fonts.css is overridden commit 0985691fbd308729006153d90da0ebac21edad2e Author: Eric Huss <eric@huss.org> Date: Sat May 13 09:12:23 2023 -0700 Update some direct dependencies commit 01047846a9df2c517c4c76276b2425bca11312c5 Author: Eric Huss <eric@huss.org> Date: Sat May 13 08:59:28 2023 -0700 Don't copy the stock fonts if the user has overridden fonts.css. This wasn't behaving as I was really intending. commit 75a6d65e5a25c4394f5fd2404d559d2309057df9 Author: Eric Huss <eric@huss.org> Date: Sat May 13 08:49:17 2023 -0700 Don't warn on copy-fonts=true (the default) when fonts.css is overridden. commit 71ea92bbec2e870d02b112a94d99bf5fba02592e Merge: af036d9 aac6de0 Author: Eric Huss <eric@huss.org> Date: Fri May 12 16:01:21 2023 -0700 Merge pull request #2081 from cn-liutailin/patch-2 Update renderers.md commit aac6de01ded9a4f578161cc772d3b1569ab0956b Author: liutailin <67492103+cn-liutailin@users.noreply.github.com> Date: Sat May 13 00:04:12 2023 +0800 Update renderers.md Missing symbol ":" commit af036d9f456a9676335fe6308040aab9a396b286 Merge: 41567b0 b9c6b32 Author: Eric Huss <eric@huss.org> Date: Sun Apr 30 14:18:30 2023 -0700 Merge pull request #2057 from seanpoulter/init-skip fix(cli): init --force skips confirmation prompts commit 04016f3be67aa61a463ce7ad39b5260626fbae76 Author: Tetsuya Morimoto <tetsuya.morimoto@gmail.com> Date: Fri Apr 28 12:46:49 2023 +0900 Refactor the warning message related to copy_fonts so that a user simply configures it commit 41567b0456d5a2bcee4ccb3fc3eba5f0020c366e Merge: 9db3a60 35fdd00 Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Sun Apr 23 11:12:26 2023 +0530 Merge pull request #2076 from ehuss/gitignore Switch from gitignore to ignore commit 9db3a601ca7a6ba48559033c43df81a512ed9be1 Merge: dec0e24 7a435be Author: Eric Huss <eric@huss.org> Date: Sat Apr 22 12:55:46 2023 -0700 Merge pull request #2071 from expikr/patch-3 Added missing documentation for `mdbook init --ignore=<git|none>` commit 35fdd0020318048c3f6040ded9862da5bc783acc Author: Eric Huss <eric@huss.org> Date: Sat Apr 22 12:49:39 2023 -0700 Switch from gitignore to ignore commit 7a435be018a96e12dd290ac209136cfb22dfa166 Author: expikr <77922942+expikr@users.noreply.github.com> Date: Tue Apr 18 01:53:38 2023 +0800 Update init.md commit dec0e242753835862545cd626a5b9d6f56f0db0d Merge: b5ffc73 c624fc0 Author: Eric Huss <eric@huss.org> Date: Thu Apr 13 10:40:49 2023 -0700 Merge pull request #2063 from rust-lang/dependabot/cargo/h2-0.3.17 Bump h2 from 0.3.15 to 0.3.17 commit c624fc078ba5cf62779692b2d05a20130c4b132e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Apr 13 17:04:53 2023 +0000 Bump h2 from 0.3.15 to 0.3.17 Bumps [h2](https://github.com/hyperium/h2) from 0.3.15 to 0.3.17. - [Release notes](https://github.com/hyperium/h2/releases) - [Changelog](https://github.com/hyperium/h2/blob/master/CHANGELOG.md) - [Commits](https://github.com/hyperium/h2/compare/v0.3.15...v0.3.17) --- updated-dependencies: - dependency-name: h2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> commit b9c6b326b7a65996884d881efd39ec08b22c4fe5 Author: Sean Poulter <sean.poulter@gmail.com> Date: Mon Apr 3 08:36:57 2023 -0400 style(tests): Fixed issues reported by clippy commit 0003072623b6de669c6f563fd9f49c09afec3154 Author: Sean Poulter <sean.poulter@gmail.com> Date: Mon Apr 3 08:36:47 2023 -0400 docs(cli): Add docs for --force commit bffdb0b03d7b94af26083053191a4d77feb4fb1a Author: Sean Poulter <sean.poulter@gmail.com> Date: Mon Apr 3 23:00:40 2023 -0400 fix(cli): init --force skips confirmation prompts commit b5ffc734a2dfcf225b26ff5fd94ca8e772293bf6 Merge: efb671a a2c88ae Author: Eric Huss <eric@huss.org> Date: Sun Apr 2 14:52:32 2023 -0700 Merge pull request #2056 from deining/http_to_https Convert links from http to https protocol commit a2c88ae0f17b7ffacd551a6b410ef8a0a384a3ac Author: Andreas Deininger <andreas@deininger.net> Date: Sun Apr 2 21:35:08 2023 +0200 Convert links from http to https protocol commit efb671aaf241b7f93597ac70178989a332fe85e0 Merge: 4c59405 a4b4b8f Author: Eric Huss <eric@huss.org> Date: Sat Mar 4 16:27:55 2023 -0800 Merge pull request #2042 from ehuss/bump-version Update to 0.4.28 commit a4b4b8f6498d5debe17f990a63515dd2f4c9270e Author: Eric Huss <eric@huss.org> Date: Sat Mar 4 15:40:56 2023 -0800 Update to 0.4.28 commit 4c59405e5ce85d688c069adac815c3fd7d6cd99e Merge: 703a215 b09aa0e Author: Eric Huss <eric@huss.org> Date: Sat Mar 4 14:55:10 2023 -0800 Merge pull request #1986 from mgeisler/preprocessors-for-test Run preprocessors in `mdbook test` commit 703a215ef878d9ed7914eda04c37365865f0e820 Merge: 1668ab7 f5f96bc Author: Eric Huss <eric@huss.org> Date: Sat Mar 4 14:05:01 2023 -0800 Merge pull request #2039 from Skwodo/master Change overflow-x hidden to clip commit f5f96bc4f464a4f1d40fce5b71bab95d35645f86 Author: Skwodo <skwodo@skwodo.com> Date: Thu Mar 2 21:01:38 2023 +0100 change overflow-x hidden to clip commit 1668ab78776ea966fa8ea4b335dd1394103d1cad Merge: c15220d 26fc0da Author: Eric Huss <eric@huss.org> Date: Tue Feb 14 06:34:20 2023 -0800 Merge pull request #2025 from tshepang/patch-1 Update continuous-integration.md commit 26fc0da9a92d30aa9419eac3220a833056f2df12 Author: Tshepang Mbambo <tshepang@gmail.com> Date: Tue Feb 14 08:29:40 2023 +0200 Update continuous-integration.md typo commit c15220d1a1d6da2cbb58f2155ef333ed205ee1c7 Merge: 7c4562a fa6aa2c Author: Eric Huss <eric@huss.org> Date: Mon Feb 13 12:42:15 2023 -0800 Merge pull request #2017 from thanatos/roy/fix-sidebar Default the sidebar to visible in large screens commit 7c4562a8b3fe103f574b0056a687ee1174c3b7d1 Merge: 958b456 6e3176f Author: Eric Huss <eric@huss.org> Date: Mon Feb 13 08:07:35 2023 -0800 Merge pull request #2023 from ehuss/bump-version Update to 0.4.27 commit 6e3176f7266f073f306ba44231bf55d9de6c8b0f Author: Eric Huss <eric@huss.org> Date: Mon Feb 13 07:53:59 2023 -0800 Update to 0.4.27 commit 958b4568734b03c7f29da316c83a46d3b89a6c72 Author: Eric Huss <eric@huss.org> Date: Mon Feb 13 07:53:32 2023 -0800 Also make sure releases use --locked If it somehow gets out of sync, then the release process otherwise wouldn't catch it. commit a43b5b69abd1ad99bd7ddfd4fc274d3c44ce88ba Merge: 1517435 7abb28c Author: Eric Huss <eric@huss.org> Date: Mon Feb 13 07:51:26 2023 -0800 Merge pull request #2022 from ehuss/ci-locked Make sure CI runs with --locked commit 15174354415b3101dc184e1257c15fa94f91da14 Merge: 112fd4a 90fbe11 Author: Eric Huss <eric@huss.org> Date: Mon Feb 13 07:44:45 2023 -0800 Merge pull request #2021 from rust-lang/revert-2009-deps/toml Revert "bump 'toml' dependency" commit 7abb28cb2ec231fa0c4f9d2451762b193610ab38 Author: Eric Huss <eric@huss.org> Date: Mon Feb 13 07:43:10 2023 -0800 Make sure CI runs with --locked commit 112fd4aac3d53bbfd7519699464fe4c3f2ef13ca Merge: 3966498 c150529 Author: Eric Huss <eric@huss.org> Date: Mon Feb 13 07:33:59 2023 -0800 Merge pull request #2020 from mgeisler/patch-1 Remove spammy `debug!` log from `path_to_root` commit 90fbe112af0d1c9e45e381d653cb902a74d5ea30 Author: Eric Huss <eric@huss.org> Date: Mon Feb 13 07:31:33 2023 -0800 Revert "bump 'toml' dependency" commit c150529c7ceb1c078686908a84abd8aae856e27f Author: Martin Geisler <mgeisler@google.com> Date: Mon Feb 13 16:17:31 2023 +0100 Remove spammy `debug!` log from `path_to_root` The log statement is empty and simply fills up the logs when you run `mdbook` with `RUST_LOG=debug`. commit fa6aa2ced885713cc5038c25b6d25ce12343631c Author: Roy Wellington Ⅳ <cactus_hugged@yahoo.com> Date: Sat Feb 11 18:04:58 2023 -0500 Default the sidebar to visible in large screens The code here leads me to believe that the intention is for the sidebar to be default visible on large screens (where `clientWidth` > 1080) and hidden otherwise. However, as previously written, if the `localStorage.getItem` call fails (for example, if the user agent is not accepting cookies), then we fall back to `sidebar = sidebar || 'visible';` — but `sidebar` is already set to `hidden`, so the `|| 'visible'` never happens. This results in the sidebar hiding itself on every navigation through an mdBook, meaning if you're just switching between sections trying to find something that you keep needing to re-open the sidebar. commit 39664985ba4eeacf780c6bb47c984236f5a20d5d Merge: 2c710d3 ab1e969 Author: Eric Huss <eric@huss.org> Date: Wed Feb 8 16:09:45 2023 -0800 Merge pull request #2012 from ehuss/bump-version Update to 0.4.26 commit ab1e9694bc9a5bd9f7e85e42c0050887083be05e Author: Eric Huss <eric@huss.org> Date: Wed Feb 8 15:55:07 2023 -0800 Update to 0.4.26 commit 2c710d3b7db53fea909e4fc5c7b793eb42b5191f Merge: 581ab2c c2d9739 Author: Eric Huss <eric@huss.org> Date: Wed Feb 8 15:56:40 2023 -0800 Merge pull request #1987 from ehuss/theme-fonts Make fonts part of the theme. commit 581ab2c9458e228498911e759f9ca100e2969b78 Merge: e352e4f 274b48c Author: Eric Huss <eric@huss.org> Date: Wed Feb 8 15:53:35 2023 -0800 Merge pull request #2011 from ehuss/update-deps Update some direct dependencies commit 274b48c82f2aa1818e2b2bde20892a9099db24e6 Author: Eric Huss <eric@huss.org> Date: Wed Feb 8 15:40:48 2023 -0800 Update some direct dependencies Updating anyhow v1.0.66 -> v1.0.69 Updating assert_cmd v2.0.7 -> v2.0.8 Updating handlebars v4.3.5 -> v4.3.6 Updating notify v5.0.0 -> v5.1.0 Updating once_cell v1.16.0 -> v1.17.0 Removing bstr v0.2.17 Removing lazy_static v1.4.0 Updating opener v0.5.0 -> v0.5.2 Updating regex v1.7.0 -> v1.7.1 Updating predicates v2.1.4 -> v2.1.5 Updating semver v1.0.14 -> v1.0.16 Updating serde v1.0.150 -> v1.0.152 Updating serde_derive v1.0.150 -> v1.0.152 Updating serde_json v1.0.89 -> v1.0.93 commit e352e4f59cbd1090897d0e30fec101a9dbea9c18 Merge: 0e1384b 734936d Author: Eric Huss <eric@huss.org> Date: Wed Feb 8 15:37:53 2023 -0800 Merge pull request #1994 from Skwodo/master fix overflow-x on mobile commit 734936d819098ee3ce7eef85561ff2d39188064a Author: Eric Huss <eric@huss.org> Date: Wed Feb 8 15:22:09 2023 -0800 Add some comments about overflow-x commit 0e1384b4d274bb7f801b584fb47cf9bc730c7950 Merge: 69bb5c7 2160613 Author: Eric Huss <eric@huss.org> Date: Wed Feb 8 14:08:21 2023 -0800 Merge pull request #2009 from danieleades/deps/toml bump 'toml' dependency commit 2160613c6afc622673683d642d91d45b42b3d66c Author: Daniel Eades <danieleades@hotmail.com> Date: Wed Feb 8 15:40:15 2023 +0000 bump 'toml' dependency commit 69bb5c7fbad5f90ed880a00b02f19c09197e745e Merge: 703c2f2 f32e1a7 Author: Eric Huss <eric@huss.org> Date: Sun Jan 29 09:34:13 2023 -0800 Merge pull request #2001 from iFreilicht/patch-1 Fix incorrect version command commit f32e1a7773eb84dd1fc272e4956a760ecc7291c7 Author: Felix Uhl <iFreilicht@users.noreply.github.com> Date: Sat Jan 28 20:21:18 2023 +0100 Fix incorrect version command commit 703c2f214b7b1bd9fccbbc3860289e63369e0575 Merge: 0079184 6de8317 Author: Eric Huss <eric@huss.org> Date: Sat Jan 28 07:41:34 2023 -0800 Merge pull request #1998 from dalance/remove_time Remove dependency to time 0.1.44 commit 6de831778a2930a9f915bcf8b48e575f30f026de Author: dalance <dalance@gmail.com> Date: Thu Jan 26 18:02:43 2023 +0900 Remove dependency to time 0.1.44 commit ca46086e791cf9330252142287766e40c8fe6447 Author: Skwodo <96998450+Skwodo@users.noreply.github.com> Date: Sat Jan 21 22:41:01 2023 +0100 fix overflow-x on mobile commit 0079184c16de0916b82e5b3785963f3ef3f505ff Merge: a3b508f dcc9efe Author: Eric Huss <eric@huss.org> Date: Wed Jan 18 09:25:02 2023 -0800 Merge pull request #1961 from noritada/fix/scrollbar-in-chrome-and-safari Use default scrollbars on webkit browsers commit dcc9efea0abe824eea893cbfe3d5a5827c2d1283 Author: Noritada Kobayashi <noritada.kobayashi@gmail.com> Date: Wed Jan 18 23:51:09 2023 +0900 Remove the WebKit-specific scrollbar styling altogether It is preferable to remove WebKit-specific styling and use the browser and OS default scrollbars. Thanks to comments from @julianfortune, @arniu, and @ehuss. Closes #1483. commit a3b508fab9d2bc7f2ae5b7a9272c1fd8ff4bd021 Merge: 41a6f0d 5359b48 Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Mon Jan 16 23:00:22 2023 +0530 Merge pull request #1988 from ehuss/issue-templates Add issue templates and update contributor docs commit 5359b487f277e8fe86cf516e1cbec237b178c40a Author: Eric Huss <eric@huss.org> Date: Mon Jan 16 09:17:13 2023 -0800 Add issue templates and update contributor docs commit c2d973997ac9dd8fcad51e83c36719e283291616 Author: Eric Huss <eric@huss.org> Date: Sun Jan 15 11:42:46 2023 -0800 Make fonts part of the theme. commit b09aa0e65cf5cce8cd1da0582e988339e02ae908 Author: Martin Geisler <martin@geisler.net> Date: Sun Jan 15 11:44:46 2023 +0100 Run preprocessors in `mdbook test` While adding support for translations[1] to Comprehensive Rust 🦀, I noticed that `mdbook test` doesn’t execute preprocessors the same way as `mdbook build`. This PR makes the two commands use the same code to find and execute preprocessors. [1]: https://github.com/google/comprehensive-rust/pull/130 commit 41a6f0d43e1a2d9543877eacb4cd2a017f9fe8da Merge: c640294 9764f88 Author: Eric Huss <eric@huss.org> Date: Wed Dec 28 19:47:20 2022 -0800 Merge pull request #1968 from ehuss/ehuss-patch-1 Fix MDBOOK_BOOK environment variable example commit 9764f8886bcf2d19c3f3eee0614ee93ec27d7adb Author: Eric Huss <eric@huss.org> Date: Wed Dec 28 19:21:38 2022 -0800 Fix MDBOOK_BOOK environment variable example commit 1ba2c063e0d2e96022f00ad3f145b9bfb4d1b130 Author: Noritada Kobayashi <noritada.kobayashi@gmail.com> Date: Thu Dec 22 15:40:03 2022 +0900 Thin scrollbars in Chrome and Safari to make them less assertive (#1483) commit c640294dbf7c416dd959be9d02436d7055c97293 Merge: 1ba74a3 dec487c Author: Eric Huss <eric@huss.org> Date: Sat Dec 17 08:19:15 2022 -0800 Merge pull request #1960 from ehuss/bump-version Update to 0.4.25 commit dec487c62b36449be4cc9cf322c30917a91c9a09 Author: Eric Huss <eric@huss.org> Date: Sat Dec 17 07:42:00 2022 -0800 Update to 0.4.25 commit 1ba74a30fc19728ab43eb80e71022be90c3049fc Merge: e14d381 fcf0ceb Author: Eric Huss <eric@huss.org> Date: Sat Dec 17 07:39:27 2022 -0800 Merge pull request #1959 from ehuss/test-lib-multiple Fix test with multiple library paths commit fcf0cebf6c26beb90516a21ae1d123921f7ba3d3 Author: Eric Huss <eric@huss.org> Date: Sat Dec 17 07:11:13 2022 -0800 Fix test with multiple library paths commit e14d38194f542e5f5472727a222e00f355a14cd1 Merge: 8767ebf 294aad0 Author: Eric Huss <eric@huss.org> Date: Thu Dec 15 07:14:13 2022 -0800 Merge pull request #1956 from ehuss/bump-version Update to 0.4.24 commit 294aad092e832b10b1a2cdb65a0e7244aca62a28 Author: Eric Huss <eric@huss.org> Date: Thu Dec 15 06:55:05 2022 -0800 Update to 0.4.24 commit 8767ebf8351f86208c10fe88762eb7b185d632fd Merge: eb77083 cd907f2 Author: Eric Huss <eric@huss.org> Date: Thu Dec 15 06:50:44 2022 -0800 Merge pull request #1955 from ehuss/ubuntu-20.04 Switch to older ubuntu image commit cd907f2edfe0ab330fb80d1c4d482ea689ffd9d6 Author: Eric Huss <eric@huss.org> Date: Thu Dec 15 05:52:15 2022 -0800 Switch to older ubuntu image commit eb77083d23c768521a0024c6317b8d295198a501 Merge: 68a75da 2193623 Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 18:46:05 2022 -0800 Merge pull request #1953 from ehuss/bump-version Update to 0.4.23 commit 219362318c728366979a740380e700d8c22525b9 Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 17:48:46 2022 -0800 Update to 0.4.23 commit 68a75dae486ec6033d8b9d59296aedd2c065a717 Merge: 0b2520f 87a381e Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 17:26:07 2022 -0800 Merge pull request #1844 from wendajiang/master Upgrade clap commit 87a381e0a7f056c22f0536b6377f38ee4fd10f09 Author: David <wendajiang93@163.com> Date: Mon Jul 4 23:16:31 2022 +0800 upgrade clap to 4.0 commit 0b2520f84a1ecb4c1a627c894e3ec3a51146d102 Merge: cda4448 21ab85c Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 17:08:41 2022 -0800 Merge pull request #1952 from ehuss/update-deps-breaking Update dependencies with semver major changes commit 21ab85cd03b909594efd311c6fe1cd2b004d4c82 Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 14:01:27 2022 -0800 Update notify Update notify from 4.0.17 to 5.0.0 https://github.com/notify-rs/notify/blob/main/UPGRADING_V4_TO_V5.md https://github.com/notify-rs/notify/blob/main/CHANGELOG.md#notify-500-2022-08-28 commit 486bf32ac73a47e5c01f18e3ea4a5e92f39b5521 Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 08:04:59 2022 -0800 Update topological-sort Update topological-sort from 0.1.0 to 0.2.2 https://github.com/gifnksm/topological-sort-rs/compare/v0.1.0...v0.2.2 commit 4f6610716a4214f3fdb035513ebcbc3cf114273a Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 08:03:05 2022 -0800 Update select Update select from 0.5.0 to 0.6.0 https://github.com/utkarshkukreti/select.rs/compare/0.5.0...0.6.0 commit 6db4ca71dafadc32e37644b2c26e1bbedba6f83a Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 07:53:24 2022 -0800 Update env_logger Update env_logger from 0.9.3 to 0.10.0 https://github.com/rust-cli/env_logger/blob/main/CHANGELOG.md#0100---2022-11-24 commit d5319e2b4f9509fc7344f3443c58c20de487e183 Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 07:41:18 2022 -0800 Update assert_cmd Update from 1.0.8 to 2.0.7 https://github.com/assert-rs/assert_cmd/blob/master/CHANGELOG.md#207---2022-12-02 commit cda44480b77bd0881191237bd7e712a8886a979e Merge: 59bd5db fb0af12 Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 08:05:17 2022 -0800 Merge pull request #1951 from ehuss/update-deps Update dependencies commit fb0af12433168aa979b92564fbcd2feaadab3aa4 Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 07:19:37 2022 -0800 Bump MSRV to 1.60 Needed for new feature syntax commit b5f858da4ef6bac4b03b329269fba97458c53791 Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 07:03:48 2022 -0800 Update dependencies Fairly large update of semver compatible deps: Updating aho-corasick v0.7.18 -> v0.7.20 Updating ammonia v3.1.2 -> v3.3.0 Adding android_system_properties v0.1.5 Removing ansi_term v0.12.1 Updating anyhow v1.0.43 -> v1.0.66 Updating assert_cmd v1.0.7 -> v1.0.8 Updating autocfg v1.0.1 -> v1.1.0 Updating base64 v0.13.0 -> v0.13.1 Updating bit-set v0.5.2 -> v0.5.3 Removing block-buffer v0.7.3 Removing block-buffer v0.9.0 Adding block-buffer v0.10.3 Removing block-padding v0.1.5 Adding bumpalo v3.11.1 Removing byte-tools v0.3.1 Updating bytes v1.0.1 -> v1.3.0 Adding cc v1.0.77 Updating chrono v0.4.19 -> v0.4.23 Updating clap v3.0.10 -> v3.2.23 Updating clap_complete v3.0.4 -> v3.2.5 Adding clap_lex v0.2.4 Adding codespan-reporting v0.11.1 Adding core-foundation-sys v0.8.3 Updating cpufeatures v0.1.5 -> v0.2.5 Adding crypto-common v0.1.6 Updating ctor v0.1.20 -> v0.1.26 Adding cxx v1.0.83 Adding cxx-build v1.0.83 Adding cxxbridge-flags v1.0.83 Adding cxxbridge-macro v1.0.83 Updating diff v0.1.12 -> v0.1.13 Removing digest v0.8.1 Removing digest v0.9.0 Adding digest v0.10.6 Updating either v1.6.1 -> v1.8.0 Updating elasticlunr-rs v3.0.0 -> v3.0.1 Updating env_logger v0.9.0 -> v0.9.3 Removing fake-simd v0.1.2 Adding fastrand v1.8.0 Updating filetime v0.2.15 -> v0.2.19 Updating form_urlencoded v1.0.1 -> v1.1.0 Updating futf v0.1.4 -> v0.1.5 Updating futures-channel v0.3.21 -> v0.3.25 Updating futures-core v0.3.21 -> v0.3.25 Updating futures-macro v0.3.16 -> v0.3.25 Updating futures-sink v0.3.21 -> v0.3.25 Updating futures-task v0.3.16 -> v0.3.25 Updating futures-util v0.3.16 -> v0.3.25 Removing generic-array v0.12.4 Removing generic-array v0.14.4 Adding generic-array v0.14.6 Updating getrandom v0.2.3 -> v0.2.8 Updating h2 v0.3.4 -> v0.3.15 Updating handlebars v4.1.2 -> v4.3.5 Updating hashbrown v0.11.2 -> v0.12.3 Updating headers v0.3.4 -> v0.3.8 Removing html5ever v0.25.1 Adding html5ever v0.25.2 Adding html5ever v0.26.0 Updating http v0.2.4 -> v0.2.8 Updating http-body v0.4.3 -> v0.4.5 Updating httparse v1.5.1 -> v1.8.0 Updating httpdate v1.0.1 -> v1.0.2 Updating hyper v0.14.11 -> v0.14.23 Adding iana-time-zone v0.1.53 Adding iana-time-zone-haiku v0.1.1 Updating idna v0.2.3 -> v0.3.0 Updating indexmap v1.7.0 -> v1.9.2 Adding instant v0.1.12 Updating itertools v0.10.1 -> v0.10.5 Updating itoa v0.4.8 -> v1.0.4 Adding js-sys v0.3.60 Updating libc v0.2.100 -> v0.2.138 Adding link-cplusplus v1.0.7 Adding lock_api v0.4.9 Updating log v0.4.14 -> v0.4.17 Adding markup5ever v0.11.0 Removing matches v0.1.9 Updating memchr v2.4.1 -> v2.5.0 Updating mime_guess v2.0.3 -> v2.0.4 Updating mio v0.7.13 -> v0.8.5 Removing miow v0.3.7 Updating net2 v0.2.37 -> v0.2.38 Removing ntapi v0.3.6 Updating num-integer v0.1.44 -> v0.1.45 Updating num-traits v0.2.14 -> v0.2.15 Updating num_cpus v1.13.0 -> v1.14.0 Updating once_cell v1.15.0 -> v1.16.0 Removing opaque-debug v0.2.3 Removing opaque-debug v0.3.0 Updating os_str_bytes v6.0.0 -> v6.4.1 Updating output_vt100 v0.1.2 -> v0.1.3 Adding parking_lot v0.12.1 Adding parking_lot_core v0.9.5 Updating percent-encoding v2.1.0 -> v2.2.0 Updating pest v2.1.3 -> v2.5.1 Updating pest_derive v2.1.0 -> v2.5.1 Updating pest_generator v2.1.3 -> v2.5.1 Updating pest_meta v2.1.3 -> v2.5.1 Adding phf v0.10.1 Adding phf_codegen v0.10.0 Adding phf_generator v0.10.0 Adding phf_shared v0.10.0 Updating pin-project v1.0.8 -> v1.0.12 Updating pin-project-internal v1.0.8 -> v1.0.12 Updating pin-project-lite v0.2.7 -> v0.2.9 Updating ppv-lite86 v0.2.10 -> v0.2.17 Updating predicates v2.0.1 -> v2.1.4 Updating predicates-core v1.0.2 -> v1.0.5 Updating predicates-tree v1.0.2 -> v1.0.7 Updating pretty_assertions v1.2.1 -> v1.3.0 Removing proc-macro-hack v0.5.19 Removing proc-macro-nested v0.1.7 Updating proc-macro2 v1.0.28 -> v1.0.47 Updating pulldown-cmark v0.9.1 -> v0.9.2 Removing quick-error v2.0.1 Updating quote v1.0.9 -> v1.0.21 Updating rand v0.8.4 -> v0.8.5 Updating rand_core v0.6.3 -> v0.6.4 Removing rand_hc v0.3.1 Updating redox_syscall v0.2.10 -> v0.2.16 Updating regex v1.5.5 -> v1.7.0 Updating regex-syntax v0.6.25 -> v0.6.28 Adding rustls-pemfile v0.2.1 Updating ryu v1.0.5 -> v1.0.11 Updating scoped-tls v1.0.0 -> v1.0.1 Adding scopeguard v1.1.0 Adding scratch v1.0.2 Updating semver v1.0.4 -> v1.0.14 Updating serde v1.0.129 -> v1.0.150 Updating serde_derive v1.0.129 -> v1.0.150 Updating serde_json v1.0.66 -> v1.0.89 Updating serde_urlencoded v0.7.0 -> v0.7.1 Removing sha-1 v0.8.2 Removing sha-1 v0.9.7 Adding sha-1 v0.10.1 Adding sha1 v0.10.5 Updating shlex v1.0.0 -> v1.1.0 Updating siphasher v0.3.6 -> v0.3.10 Updating slab v0.4.4 -> v0.4.7 Adding smallvec v1.10.0 Updating socket2 v0.4.1 -> v0.4.7 Updating string_cache v0.8.1 -> v0.8.4 Updating string_cache_codegen v0.5.1 -> v0.5.2 Updating syn v1.0.75 -> v1.0.105 Updating tempfile v3.2.0 -> v3.3.0 Updating tendril v0.4.2 -> v0.4.3 Updating termcolor v1.1.2 -> v1.1.3 Adding termtree v0.4.0 Updating textwrap v0.14.2 -> v0.16.0 Updating thiserror v1.0.31 -> v1.0.37 Updating thiserror-impl v1.0.31 -> v1.0.37 Updating time v0.1.43 -> v0.1.45 Updating tinyvec v1.3.1 -> v1.6.0 Updating tokio v1.16.1 -> v1.23.0 Updating tokio-macros v1.8.0 -> v1.8.2 Updating tokio-stream v0.1.7 -> v0.1.11 Updating tokio-tungstenite v0.15.0 -> v0.17.2 Updating tokio-util v0.6.7 -> v0.7.4 Updating toml v0.5.8 -> v0.5.10 Updating tower-service v0.3.1 -> v0.3.2 Updating tracing v0.1.26 -> v0.1.37 Updating tracing-core v0.1.19 -> v0.1.30 Removing treeline v0.1.0 Updating tungstenite v0.14.0 -> v0.17.3 Updating typenum v1.13.0 -> v1.16.0 Updating ucd-trie v0.1.3 -> v0.1.5 Updating unicode-bidi v0.3.6 -> v0.3.8 Adding unicode-ident v1.0.5 Updating unicode-normalization v0.1.19 -> v0.1.22 Adding unicode-width v0.1.10 Removing unicode-xid v0.2.2 Updating url v2.2.2 -> v2.3.1 Updating version_check v0.9.3 -> v0.9.4 Updating warp v0.3.2 -> v0.3.3 Removing wasi v0.10.2+wasi-snapshot-preview1 Adding wasi v0.10.0+wasi-snapshot-preview1 Adding wasi v0.11.0+wasi-snapshot-preview1 Adding wasm-bindgen v0.2.83 Adding wasm-bindgen-backend v0.2.83 Adding wasm-bindgen-macro v0.2.83 Adding wasm-bindgen-macro-support v0.2.83 Adding wasm-bindgen-shared v0.2.83 Adding windows-sys v0.42.0 Adding windows_aarch64_gnullvm v0.42.0 Adding windows_aarch64_msvc v0.42.0 Adding windows_i686_gnu v0.42.0 Adding windows_i686_msvc v0.42.0 Adding windows_x86_64_gnu v0.42.0 Adding windows_x86_64_gnullvm v0.42.0 Adding windows_x86_64_msvc v0.42.0 Updating xml5ever v0.16.1 -> v0.16.2 Adding yansi v0.5.1 commit 59bd5db55670a9b2e20daf2033f8ae52ce8206e3 Merge: 36e1f01 cf1557e Author: Eric Huss <eric@huss.org> Date: Wed Dec 14 06:57:02 2022 -0800 Merge pull request #1950 from yoyomo/issue-1949 #1949 update for hidden only on clipboard commit cf1557e4543f302c24885d4eca71db950bcd25f2 Author: armandocumate <armando@documate.org> Date: Tue Dec 13 15:22:03 2022 -0800 update for hidden only on clipboard commit 36e1f0109126cdf1137326e27bddc0b05a78293b Merge: 4deb5c7 e3c484a Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Tue Dec 6 13:26:45 2022 +0530 Merge pull request #1946 from LePichu/master fix: random `Array` ref in `src/theme/book.js` commit e3c484af0162885d486335da2da25541b272e837 Author: LePichu <ishat.prsnl65844@gmail.com> Date: Tue Dec 6 12:05:11 2022 +0530 fix: random ref in commit 4deb5c7ceed333fc01799c8f6ed065eb96a4513d Merge: 678b469 21fb329 Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Tue Nov 29 23:40:01 2022 +0530 Merge pull request #1941 from klensy/msrv fix msrv in docs commit 21fb329d568812ca49de35609244d17bfe7bb020 Author: klensy <klensy@users.noreply.github.com> Date: Tue Nov 29 20:33:03 2022 +0300 fix msrv in docs commit 678b4698352f1fa40b97b1887a2ff6ed7e501230 Merge: 4844f72 ded48dd Author: Eric Huss <eric@huss.org> Date: Mon Nov 28 10:16:18 2022 -0800 Merge pull request #1938 from ehuss/bump-version Update to 0.4.22 commit ded48ddac78aeb09709f3b8b0d75e80942bb8a3f Author: Eric Huss <eric@huss.org> Date: Mon Nov 28 09:54:39 2022 -0800 Update to 0.4.22 commit 8a02fc755f3f9bc5976bb378d1496008404963f6 Author: Eric Huss <eric@huss.org> Date: Mon Nov 28 09:53:47 2022 -0800 Fix broken doc link commit 4844f72b964fcb3f2844191c265bd8cc32305cca Merge: c34c3bf f32bd6f Author: Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> Date: Tue Nov 22 13:32:12 2022 +0530 Merge pull request #1935 from ehuss/theme-dropdown-rendering-changes Show the currently selected theme commit f32bd6f9458018cc0187efed2ae16a53856bd509 Author: Eric Huss <eric@huss.org> Date: Mon Nov 21 15:27:39 2022 -0800 Show the currently selected theme. commit f64fcbc07d2742ae0a32ef4160f3bd4484982459 Author: Eric Huss <eric@huss.org> Date: Mon Nov 21 14:00:18 2022 -0800 Fix clipping in theme popup commit c34c3bf73096d811136e54fd856620b5e7859af2 Merge: d45f02d de4c551 Author: Eric Huss <eric@huss.org> Date: Fri Nov 18 18:05:37 2022 -0800 Merge pull request #1929 from Benjins/patch-2 Update docs link in Cargo.toml to HTTPS ve…

ivilata added a commit to censorship-no/ceno-docs that referenced this pull request Feb 24, 2022

Adopt gh:cN3rd/mdBook:rtl (rust-lang/mdBook#1641) for RTL support.

63addeb

It fixes rendering issues with prev/next arrows, and it does not need altering HTML after rendering.

crawfxrd mentioned this pull request Jun 10, 2022

Support right-to-left languages #1489

Closed

3 tasks

mgeier mentioned this pull request Jun 11, 2022

bidi/right-to-left support? mgeier/insipid-sphinx-theme#32

Open

cN3rd force-pushed the rtl branch from 0411d62 to 304a0df Compare June 24, 2022 15:01

mgeisler reviewed Jul 31, 2023

View reviewed changes

Manishearth approved these changes Sep 1, 2023

View reviewed changes

crawfxrd and others added 13 commits September 2, 2023 07:47

Move sidebar, js classes from html to body element

1088066

This will be necessary for using CSS selectors on root attributes. Signed-off-by: Tim Crawford <crawfxrd@gmail.com>

Use CSS selectors to override properties for RTL

3a99899

Fix behavior of some elements when displaying page in RTL. Signed-off-by: Tim Crawford <crawfxrd@gmail.com>

Add text_direction property in general book metadata

819a108

Text direction can selected in the config via the `text_direction` attribute in `book.toml`, or be derived from the book's language.

Support text_direction attribute in HTML output

7717b9d

Fix icons when using RTL

5e0c68c

Ensure code segments always render in LTR

6be98e0

Add proper test to inline code within the book.

8564a7f

Some minor corrections from code review.

4749f9d

Update language list to include missing rtl languages.

db877b1

Remove text_drection_from_lang_code

869fe2f

The test above should cover this sufficiently.

Fix sidebar behavior with RTL.

b871676

Fix theme selector for RTL.

fb272d1

Make the arrow keys honor RTL.

802e7bf

At least to my understanding, the pages will flip in the opposite direction.

ehuss force-pushed the rtl branch from 304a0df to 802e7bf Compare September 2, 2023 23:45

ehuss added this pull request to the merge queue Sep 2, 2023

Merged via the queue into rust-lang:master with commit 09f222b Sep 3, 2023
8 checks passed

mgeisler mentioned this pull request Sep 4, 2023

Test new mdbook right-to-left rendering google/comprehensive-rust#1164

Closed

mgeisler mentioned this pull request Sep 4, 2023

Add support for right-to-left languages google/comprehensive-rust#1165

Merged

mgeisler mentioned this pull request Sep 20, 2023

How implement rtl #921

Closed

mgeisler mentioned this pull request Oct 17, 2023

Persian translation google/comprehensive-rust#671

Open

atjn mentioned this pull request Sep 21, 2024

Fix automatic dark mode #2441

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Continued work on "Support right-to-left languages" #1641

Continued work on "Support right-to-left languages" #1641

cN3rd commented Sep 3, 2021

XVilka commented Oct 12, 2021

ivilata commented Feb 24, 2022 •

edited

Loading

jnny commented Jun 10, 2022

cN3rd commented Jun 24, 2022 •

edited

Loading

ivilata commented Jun 28, 2022

ywmaa commented Dec 11, 2022

mgeisler commented Jul 31, 2023

mgeisler Jul 31, 2023

mgeisler Jul 31, 2023

mgeisler Jul 31, 2023

mgeisler Jul 31, 2023

jnny commented Sep 1, 2023

Manishearth left a comment

Manishearth Sep 1, 2023

ehuss commented Sep 2, 2023

mgeisler commented Sep 4, 2023

mgeisler commented Sep 5, 2023

Manishearth commented Sep 5, 2023

mgeisler commented Sep 8, 2023

moaminsharifi commented Oct 23, 2023

Manishearth commented Oct 23, 2023

	When not specified, the correct text direction is derived from the book's `language` attribute.
	When not specified, the text direction is derived from the book's `language` attribute.

	/// When not specified, the correct text direction is derived from [BookConfig::language].
	/// When not specified, the text direction is derived from [BookConfig::language].

	TextDirection::from_lang_code(&self.language.clone().unwrap_or_default())
	TextDirection::from_lang_code(self.language.as_deref().unwrap_or_default())

Continued work on "Support right-to-left languages" #1641

Continued work on "Support right-to-left languages" #1641

Conversation

cN3rd commented Sep 3, 2021

XVilka commented Oct 12, 2021

ivilata commented Feb 24, 2022 • edited Loading

jnny commented Jun 10, 2022

cN3rd commented Jun 24, 2022 • edited Loading

ivilata commented Jun 28, 2022

ywmaa commented Dec 11, 2022

mgeisler commented Jul 31, 2023

mgeisler Jul 31, 2023

Choose a reason for hiding this comment

mgeisler Jul 31, 2023

Choose a reason for hiding this comment

mgeisler Jul 31, 2023

Choose a reason for hiding this comment

mgeisler Jul 31, 2023

Choose a reason for hiding this comment

jnny commented Sep 1, 2023

Manishearth left a comment

Choose a reason for hiding this comment

Manishearth Sep 1, 2023

Choose a reason for hiding this comment

ehuss commented Sep 2, 2023

mgeisler commented Sep 4, 2023

mgeisler commented Sep 5, 2023

Manishearth commented Sep 5, 2023

mgeisler commented Sep 8, 2023

moaminsharifi commented Oct 23, 2023

Manishearth commented Oct 23, 2023

ivilata commented Feb 24, 2022 •

edited

Loading

cN3rd commented Jun 24, 2022 •

edited

Loading