Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continued work on "Support right-to-left languages" #1641

Merged
merged 14 commits into from
Sep 3, 2023
Merged

Continued work on "Support right-to-left languages" #1641

merged 14 commits into from
Sep 3, 2023

Commits on Sep 2, 2023

  1. Use logical CSS properties 

    Replace phyiscal properties (top/bottom/left/right) with logical
properties (start/end) that can be used in non-LTR contexts (e.g.,
content in Arabic or Hebrew).

Based on the CSS Logical Properties and Values Level 1 specification,
currently an Editor's Draft [1].

Referencing MDN, all major browsers except Internet Explorer support the
margin, padding, and border properties.

[1]: https://drafts.csswg.org/css-logical/

Signed-off-by: Tim Crawford <crawfxrd@gmail.com>
    @crawfxrd @ehuss
    crawfxrd authored and ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    73d4450 View commit details
    Browse the repository at this point in the history

  2. Move sidebar, js classes from html to body element 

    This will be necessary for using CSS selectors on root attributes.

Signed-off-by: Tim Crawford <crawfxrd@gmail.com>
    @crawfxrd @ehuss
    crawfxrd authored and ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    1088066 View commit details
    Browse the repository at this point in the history

  3. Use CSS selectors to override properties for RTL 

    Fix behavior of some elements when displaying page in RTL.

Signed-off-by: Tim Crawford <crawfxrd@gmail.com>
    @crawfxrd @ehuss
    crawfxrd authored and ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    3a99899 View commit details
    Browse the repository at this point in the history

  4. Add text_direction property in general book metadata 

    Text direction can selected in the config via the `text_direction` attribute in `book.toml`,
or be derived from the book's language.
    @cN3rd @ehuss
    cN3rd authored and ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    819a108 View commit details
    Browse the repository at this point in the history

  5. Support text_direction attribute in HTML output

    @cN3rd @ehuss
    cN3rd authored and ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    7717b9d View commit details
    Browse the repository at this point in the history

  6. Fix icons when using RTL

    @cN3rd @ehuss
    cN3rd authored and ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    5e0c68c View commit details
    Browse the repository at this point in the history

  7. Ensure code segments always render in LTR

    @ehuss
    cN3rd authored and ehuss committed Sep 2, 2023
    1 Configuration menu
    Copy the full SHA
    6be98e0 View commit details
    Browse the repository at this point in the history

  8. Add proper test to inline code within the book.

    @ehuss
    cN3rd authored and ehuss committed Sep 2, 2023
    1 Configuration menu
    Copy the full SHA
    8564a7f View commit details
    Browse the repository at this point in the history

  9. Some minor corrections from code review.

    @ehuss
    ehuss committed Sep 2, 2023
    1 Configuration menu
    Copy the full SHA
    4749f9d View commit details
    Browse the repository at this point in the history

  10. Update language list to include missing rtl languages.

    @ehuss
    ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    db877b1 View commit details
    Browse the repository at this point in the history

  11. Remove text_drection_from_lang_code 

    The test above should cover this sufficiently.
    @ehuss
    ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    869fe2f View commit details
    Browse the repository at this point in the history

  12. Fix sidebar behavior with RTL.

    @ehuss
    ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    b871676 View commit details
    Browse the repository at this point in the history

  13. Fix theme selector for RTL.

    @ehuss
    ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    fb272d1 View commit details
    Browse the repository at this point in the history

  14. Make the arrow keys honor RTL. 

    At least to my understanding, the pages will flip in the opposite direction.
    @ehuss
    ehuss committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    802e7bf View commit details
    Browse the repository at this point in the history