Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.56 to get access to Rust 2021 crates #1866

Closed
wants to merge 1 commit into from

Conversation

mgeisler
Copy link
Contributor

@mgeisler mgeisler commented Jul 28, 2022

I noticed in #1864 that mdBook does not yet use the Rust 2021 edition.
This 2021 edition was made stable in the 1.56 release on 2021-10-21.
The previous MSRV (1.54) was released on 2021-07-29.

I noticed in rust-lang#1062 that mdBook does not yet use the Rust 2021 edition.
This 2021 edition was made stable in the 1.56 release on 2021-10-21.
The previous MSRV (1.54) was released on 2021-07-29.
@ehuss
Copy link
Contributor

ehuss commented Jul 28, 2022

Is there something specific that needs this to be updated?

I'm a bit confused to the relationship to #1062, as that is 3 years old.

There is #1831 to update the actual edition, but the PR currently has some failures. If someone else wants to revive it, I think that would be fine. But otherwise I'm not sure if I'd bother updating the version without a need.

@mgeisler
Copy link
Contributor Author

Is there something specific that needs this to be updated?

I'm a bit confused to the relationship to #1062, as that is 3 years old.

Hi @ehuss, I'm sorry, I don't know what I was copying before... I wanted to refer to #1864 and ended up copying something else. I've updated it now in the comment and will fix it in the commit too.

Thanks for the pointer to #1831, I will be happy to see what needs to be fixed there.

@mgeisler
Copy link
Contributor Author

The same change (and more) is being made in #1831.

@mgeisler mgeisler closed this Jul 31, 2022
@mgeisler mgeisler deleted the msrv-2021-edition branch September 10, 2022 22:11
@mgeisler
Copy link
Contributor Author

The edition was eventually bumped in #1887.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants