Require Rust 2021 edition #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeisler
force-pushed
the
edition-2021
branch
2 times, most recently
from
5c2e591
to
ea913d5
Compare
This was referenced Sep 9, 2022
Merged
ISSOtm
approved these changes
Sep 9, 2022
Dylan-DPC
added
the
msrv-bump
|
@ehuss do we want to do this in a new major version? |
ehuss
reviewed
Sep 9, 2022
No, I think a normal release is fine. |
This allows us to clean up and simplify the code.
mgeisler
force-pushed
the
edition-2021
branch
from
ea913d5
to
66bf85b
Compare
This was referenced Sep 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to clean up and simplify the code.
The changes were originally written by @Dylan-DPC in #1831. This PR fixes a few build errors in that PR, thanks to the helpful comments made by @ISSOtm. I've also rebased the changes onto the latest
master.