Use isize::MAX directly on type instead of module #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, wrong repo... no bors here :P |
Centril
approved these changes
Apr 5, 2020
|
Oops. I pushed a fix for what the CI failed at at basically the same time as you approved. But it only fixed one of two errors. Should I try to fix the remaining one, merge as is, or revert that fix? |
|
We'll need to fix the CI errors before merging. |
|
The errors were not caused by this PR. But we can fix them while at it, sure :) |
faern
force-pushed
the
use-assoc-int-consts
branch
from
7559feb
to
1d517f8
Compare
|
@Centril Done! |
Centril
approved these changes
Apr 6, 2020
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 7, 2020
…tolnay Use assoc int submodules Bumping some submodules to the commits their masters currently point at. The main point of this is to get the associated integer/float constant documentation updates that were recently merged to them: * rust-lang/nomicon#207 * rust-lang/rust-by-example#1327 * rust-lang/stdarch#848 But for some, a few more changes slipped by that happened to be in the master branch of these submodules. r? @dtolnay
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 7, 2020
…tolnay Use assoc int submodules Bumping some submodules to the commits their masters currently point at. The main point of this is to get the associated integer/float constant documentation updates that were recently merged to them: * rust-lang/nomicon#207 * rust-lang/rust-by-example#1327 * rust-lang/stdarch#848 But for some, a few more changes slipped by that happened to be in the master branch of these submodules. r? @dtolnay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's simpler (shorter) to access
MIN/MAXdirectly on the integer types now. This repository only had a single instance of this, so the PR is tiny. But it's basically a follow up of rust-lang/rust#69860 to make all documentation consistently use the newest versions of the constants.r? @dtolnay