Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assoc int submodules #70854

Merged
merged 3 commits into from
Apr 7, 2020
Merged

Conversation

faern
Copy link
Contributor

@faern faern commented Apr 6, 2020

Bumping some submodules to the commits their masters currently point at. The main point of this is to get the associated integer/float constant documentation updates that were recently merged to them:

But for some, a few more changes slipped by that happened to be in the master branch of these submodules.

r? @dtolnay

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2020
@dtolnay
Copy link
Member

dtolnay commented Apr 6, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 6, 2020

📌 Commit 01b3293 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2020
@Centril
Copy link
Contributor

Centril commented Apr 7, 2020

But for some, a few more changes slipped by that happened to be in the master branch of these submodules.

Please include a summary of those changes in the future. Thanks.

Centril added a commit to Centril/rust that referenced this pull request Apr 7, 2020
…tolnay

Use assoc int submodules

Bumping some submodules to the commits their masters currently point at. The main point of this is to get the associated integer/float constant documentation updates that were recently merged to them:

* rust-lang/nomicon#207
* rust-lang/rust-by-example#1327
* rust-lang/stdarch#848

But for some, a few more changes slipped by that happened to be in the master branch of these submodules.

r? @dtolnay
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2020
…ievink

Rollup of 5 pull requests

Successful merges:

 - rust-lang#70201 (Small tweaks in ToOwned::clone_into)
 - rust-lang#70762 (Miri leak check: memory reachable through globals is not leaked)
 - rust-lang#70846 (Keep codegen units unmerged when building compiler builtins)
 - rust-lang#70854 (Use assoc int submodules)
 - rust-lang#70857 (Don't import integer and float modules, use assoc consts 2)

Failed merges:

r? @ghost
@bors bors merged commit 78c64d0 into rust-lang:master Apr 7, 2020
@faern faern deleted the use-assoc-int-submodules branch April 16, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants