Add missing main function in static life time example. #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @marioidival (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 22, 2020
Update books ## nomicon 2 commits in d8383b65f7948c2ca19191b3b4bd709b403aaf45..a5a48441d411f61556b57d762b03d6874afe575d 2020-11-22 10:24:42 -0500 to 2020-12-06 10:39:41 +0900 - Update atomics.md (rust-lang/nomicon#249) - Rename `AllocRef` to `Allocator` and `(de)alloc` to `(de)allocate` (rust-lang/nomicon#248) ## reference 2 commits in a8afdca5d0715b2257b6f8b9a032fd4dd7dae855..b278478b766178491a8b6f67afa4bcd6b64d977a 2020-11-30 06:44:46 -0800 to 2020-12-21 18:18:03 -0800 - Update unions for safe ManuallyDrop assignment. (rust-lang/reference#912) - Removing ambiguity in type-layout.md (rust-lang/reference#911) ## book 25 commits in a190438d77d28041f24da4f6592e287fab073a61..5bb44f8b5b0aa105c8b22602e9b18800484afa21 2020-11-16 10:44:08 -0600 to 2020-12-18 20:07:31 -0500 - Make some further edits to rust-lang/book#2447 - Merge remote-tracking branch 'origin/pr/2447' - Remove copied and dangling link brackets - Merge remote-tracking branch 'origin/pr/2359' - Override toolchain to nightly for run lints action. (rust-lang/book#2528) - Remove an uneeded 'static lifetime (rust-lang/book#1752) - Fixes rust-lang/book#2330. Clarify why the lock is held too long - Update paragraph about rustfmt in Chapter 1.2 (rust-lang/book#2304) - Clarify language around further from rust-lang/book#2418 - Merge remote-tracking branch 'origin/pr/2418' - Merge remote-tracking branch 'origin/pr/2475' - Add some further edits to rust-lang/book#2433 - Merge remote-tracking branch 'origin/pr/2433' - Note all the method families to handle integer overflow - Merge remote-tracking branch 'origin/pr/2405' - Fix rust-lang/book#1855 - incorporate new reference cycle diagram - Make some further edits to the changes in rust-lang/book#1886 - Merge remote-tracking branch 'origin/pr/1886' - Make some further edits to rust-lang/book#1998 - Merge remote-tracking branch 'origin/pr/1998' - Update Rust version and output (rust-lang/book#2518) - Fix typo, regarding privileged ports being up to 1023 instead of 1024 (rust-lang/book#2509) - Change "appendixes" to "appendices" in intro. (rust-lang/book#2498) - Update 16-11 to use method call expression for `clone` (rust-lang/book#2511) - Correct chapter 20 final listing (rust-lang/book#2516) ## rust-by-example 7 commits in 236c734a2cb323541b3394f98682cb981b9ec086..1cce0737d6a7d3ceafb139b4a206861fb1dcb2ab 2020-11-30 14:05:49 -0300 to 2020-12-21 17:36:29 -0300 - Add book.description in book.toml (rust-lang/rust-by-example#1397) - Simplify the call of filter_map (rust-lang/rust-by-example#1396) - Update README.md (rust-lang/rust-by-example#1382) - Add missing main function in static life time example. (rust-lang/rust-by-example#1383) - Clarify first matching arm and all possible values (rust-lang/rust-by-example#1395) - Clarify distinction between for iter and into_iter (rust-lang/rust-by-example#1394) - Drop extern crate (rust-lang/rust-by-example#1393)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone, I just realized that the static lifetime trait bound example mentions a specific compiler error but if the example is compiled through the playground this is not shown as the example misses a
mainfunction. I therefore renamed the functionuse_itintomainto ensure the expected error message appears.Is this the expected solution? If not feel free to nitpick and I am going to adjust the commit based on your requests.