Extract diagnostics module and document some functions #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the lint building functions from `utils/mod.rs` to their own `utils/diagnostics.rs` file. Also adds documentation for three of them.
|
needs a rebase once #3790 is merged. r=me after rebase. |
flip1995
added
the
S-waiting-on-author
|
Oh wait this should go through without a rebase, oops. Let's queue this. @bors r+ |
|
📌 Commit 7d883cd has been approved by |
bors
added a commit
that referenced
this pull request
Feb 24, 2019
Extract diagnostics module and document some functions This moves the lint building functions from `utils/mod.rs` to their own `utils/diagnostics.rs` file. Also adds documentation for three of them.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the lint building functions from
utils/mod.rsto their ownutils/diagnostics.rsfile. Also adds documentation for three of them.