partially HirIdify lints #3790
Merged
partially HirIdify lints #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created a local branch that we'll need to merge before bumping the clippy submodule in rustc again |
|
@bors try (The rustc PR was merged) |
bors
added a commit
that referenced
this pull request
Feb 24, 2019
partially HirIdify lints Enables rust-lang/rust#58232 (a part of rust-lang/rust#57578).
|
💔 Test failed - checks-travis |
|
r=me with format fixed: https://travis-ci.com/rust-lang/rust-clippy/jobs/180079355#L1377 |
phansch
added
the
S-waiting-on-author
|
Note: you cannot modify 1fac380 anymore, you have to add another commit with the fix. |
|
I'll send a fix shortly. |
|
@mati865 thanks for the warning (makes perfect sense); I'm usually very squash-happy ^^. |
|
@bors r=phansch |
|
📌 Commit 601cbc6 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 24, 2019
partially HirIdify lints Enables rust-lang/rust#58232 (a part of rust-lang/rust#57578).
Merged
|
☀️ Test successful - checks-travis, status-appveyor |
Merged
bors
added a commit
that referenced
this pull request
Feb 26, 2019
HirIdify some lints Unblocks rust-lang/rust#58561 (a part of [rust-lang/rust#57578](rust-lang/rust#57578)). Can we branch it like with #3790? I can rebase on a different commit if need be. Haven't had time to run tests yet, so I'd wait for Travis 🙈.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables rust-lang/rust#58232 (a part of rust-lang/rust#57578).