Remove NodeId from some HIR nodes #58561

ljedrz · 2019-02-18T15:40:32Z

The next iteration of #57578.

Removes NodeId from:

rust-highfive · 2019-02-18T16:09:19Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0fd4b7b5:start=1550505041681172177,finish=1550505043963344548,duration=2282172371
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:04:13] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:13] tidy error: /checkout/src/librustc/middle/stability.rs:292: line longer than 100 chars
[00:04:14] some tidy checks failed
[00:04:14] 
[00:04:14] 
[00:04:14] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:14] 
[00:04:14] 
[00:04:14] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:14] Build completed unsuccessfully in 0:00:46
[00:04:14] Build completed unsuccessfully in 0:00:46
[00:04:14] make: *** [tidy] Error 1
[00:04:14] Makefile:68: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:243c2d72
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Feb 18 15:55:09 UTC 2019
---
travis_time:end:0ce4dade:start=1550505310063858333,finish=1550505310068388008,duration=4529675
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:03b9d959
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0ff4466a
travis_time:start:0ff4466a
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:01acfb53
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-02-19T03:43:32Z

☔ The latest upstream changes (presumably #58503) made this pull request unmergeable. Please resolve the merge conflicts.

Zoxc · 2019-02-19T07:34:25Z

These changes look good to me.

@bors delegate+

bors · 2019-02-19T07:34:27Z

✌️ @ljedrz can now approve this pull request

rust-highfive · 2019-02-19T19:31:09Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0790de7a:start=1550603541944574983,finish=1550603679680686988,duration=137736112005
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:06:09] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:06:10] tidy error: /checkout/src/librustdoc/clean/mod.rs:2632: tab character
[00:06:11] some tidy checks failed
[00:06:11] 
[00:06:11] 
[00:06:11] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:06:11] 
[00:06:11] 
[00:06:11] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:06:11] Build completed unsuccessfully in 0:00:45
[00:06:11] Build completed unsuccessfully in 0:00:45
[00:06:11] make: *** [tidy] Error 1
[00:06:11] Makefile:68: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:06a5790e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Feb 19 19:21:01 UTC 2019
---
travis_time:end:06d7eeec:start=1550604062077196475,finish=1550604062081578725,duration=4382250
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:096a44c0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:067cac4c
travis_time:start:067cac4c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:19fa23c8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-02-23T17:07:21Z

☔ The latest upstream changes (presumably #58669) made this pull request unmergeable. Please resolve the merge conflicts.

ljedrz · 2019-02-24T06:58:21Z

@bors r=Zoxc

bors · 2019-02-24T06:58:22Z

📌 Commit 63b4dd9 has been approved by Zoxc

ljedrz · 2019-02-24T20:05:57Z

Blocked by rust-lang/rust-clippy#3814.

rust-highfive · 2019-02-24T22:57:41Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:25cf9d58:start=1551042031185801905,finish=1551042121772123790,duration=90586321885
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-tools

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

ljedrz · 2019-02-25T06:02:31Z

The build stalled; might be spurious. I'm not sure if reopening will retry Travis; lemme see...

edit: yep, that did the trick.

rust-highfive · 2019-02-25T07:59:45Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:09de66bd:start=1551074638382806590,finish=1551074725619953484,duration=87237146894
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-tools
---
[01:24:02] test [ui] ui/assign_ops2.rs ... test [ui] ui/assign_ops2.rs has been running for over 60 seconds
[01:24:04] test [ui] ui/block_in_if_condition.rs ... test [ui] ui/block_in_if_condition.rs has been running for over 60 seconds
[01:24:06] test [ui] ui/borrow_box.rs ... test [ui] ui/borrow_box.rs has been running for over 60 seconds
[01:24:06] test [ui] ui/box_vec.rs ... test [ui] ui/box_vec.rs has been running for over 60 seconds
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

ljedrz · 2019-02-25T08:00:50Z

The tooltest error seems legit; I'll look into it.

edit: clippy updated, retrying.

ljedrz · 2019-02-25T12:33:01Z

@bors r=Zoxc

bors · 2019-02-25T12:33:02Z

📌 Commit 77a30ec has been approved by Zoxc

ljedrz · 2019-02-25T15:06:01Z

Can I get a priority bump to 1 due to submodule update?

Centril · 2019-02-25T21:23:09Z

Rollup fairness (due to submodule update), @bors p=1

bors · 2019-02-26T06:13:39Z

⌛ Testing commit 77a30ec with merge ea43c3c...

@Zoxc

Remove NodeId from some HIR nodes The next iteration of #57578. Removes `NodeId` from: - [x] `Lifetime` - [x] `Ty` - [x] `GenericParam` - [x] `WhereClause` - [x] `WhereEqPredicate` - [x] `MacroDef` - [x] `Block` - [x] `Expr` r? @Zoxc

bors · 2019-02-26T08:59:08Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: Zoxc
Pushing ea43c3c to master...

bors · 2019-02-26T08:59:19Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: Zoxc
Pushing ea43c3c to master...

HirIdify some lints Unblocks rust-lang/rust#58561 (a part of [rust-lang/rust#57578](rust-lang/rust#57578)). Can we branch it like with #3790? I can rebase on a different commit if need be. Haven't had time to run tests yet, so I'd wait for Travis 🙈.

rust-highfive assigned Zoxc Feb 18, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2019

ljedrz changed the title ~~HirId-ify some nodes~~ Remove NodeId from some HIR nodes Feb 18, 2019

ljedrz force-pushed the HirIdify_some_nodes branch from c7da41c to 1581d6c Compare February 18, 2019 16:13

ljedrz force-pushed the HirIdify_some_nodes branch from 1581d6c to 122d653 Compare February 19, 2019 19:08

ljedrz force-pushed the HirIdify_some_nodes branch from 122d653 to 2d76ab5 Compare February 19, 2019 19:45

ljedrz mentioned this pull request Feb 22, 2019

Remove NodeId from hir::Block #58651

Closed

ljedrz added 10 commits February 24, 2019 07:50

hir: impl Display for HirId

904a91c

hir: remove NodeId from Lifetime and Ty

00b74e5

passes: HirIdify Id

58ed683

privacy: HirIdify ObsoleteVisiblePrivateTypesVisitor

1c18ac1

hir: remove NodeId from GenericParam

e4f8a6b

hir: remove NodeId from WhereClause

cd5b5e7

hir: remove NodeId from WhereEqPredicate

b6b2edb

middle: partially HirIdify stability

46e4f4a

doc: partially HirIdify visit_ast

c886d47

hir: remove NodeId from MacroDef

63b4dd9

ljedrz force-pushed the HirIdify_some_nodes branch from 2d76ab5 to 63b4dd9 Compare February 24, 2019 06:52

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2019

ljedrz mentioned this pull request Feb 24, 2019

Remove NodeId from Block and Expr #58698

Closed

2 tasks

hir: remove NodeId from Block

021a140

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2019

ljedrz mentioned this pull request Feb 24, 2019

HirIdify some lints rust-lang/rust-clippy#3814

Merged

ljedrz closed this Feb 25, 2019

ljedrz reopened this Feb 25, 2019

update clippy

77a30ec

ljedrz force-pushed the HirIdify_some_nodes branch from a030d9d to 77a30ec Compare February 25, 2019 10:26

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2019

bors merged commit 77a30ec into rust-lang:master Feb 26, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 26, 2019

ljedrz deleted the HirIdify_some_nodes branch February 26, 2019 09:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove NodeId from some HIR nodes #58561

Remove NodeId from some HIR nodes #58561

ljedrz commented Feb 18, 2019 •

edited

Loading

rust-highfive commented Feb 18, 2019

bors commented Feb 19, 2019

Zoxc commented Feb 19, 2019

bors commented Feb 19, 2019

rust-highfive commented Feb 19, 2019

bors commented Feb 23, 2019

ljedrz commented Feb 24, 2019

bors commented Feb 24, 2019

ljedrz commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

ljedrz commented Feb 25, 2019 •

edited

Loading

rust-highfive commented Feb 25, 2019

ljedrz commented Feb 25, 2019 •

edited

Loading

ljedrz commented Feb 25, 2019

bors commented Feb 25, 2019

ljedrz commented Feb 25, 2019

Centril commented Feb 25, 2019

bors commented Feb 26, 2019

bors commented Feb 26, 2019

bors commented Feb 26, 2019

Remove NodeId from some HIR nodes #58561

Remove NodeId from some HIR nodes #58561

Conversation

ljedrz commented Feb 18, 2019 • edited Loading

rust-highfive commented Feb 18, 2019

bors commented Feb 19, 2019

Zoxc commented Feb 19, 2019

bors commented Feb 19, 2019

rust-highfive commented Feb 19, 2019

bors commented Feb 23, 2019

ljedrz commented Feb 24, 2019

bors commented Feb 24, 2019

ljedrz commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

ljedrz commented Feb 25, 2019 • edited Loading

rust-highfive commented Feb 25, 2019

ljedrz commented Feb 25, 2019 • edited Loading

ljedrz commented Feb 25, 2019

bors commented Feb 25, 2019

ljedrz commented Feb 25, 2019

Centril commented Feb 25, 2019

bors commented Feb 26, 2019

bors commented Feb 26, 2019

bors commented Feb 26, 2019

ljedrz commented Feb 18, 2019 •

edited

Loading

ljedrz commented Feb 25, 2019 •

edited

Loading

ljedrz commented Feb 25, 2019 •

edited

Loading