Remove NodeId from hir::Block #58651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust-highfive
added
the
S-waiting-on-review
ljedrz
commented
Feb 22, 2019
| @@ -679,7 +678,7 @@ pub fn check_unsafety<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, def_id: DefId) { | |||
| } | |||
|
|
|||
| let mut unsafe_blocks: Vec<_> = unsafe_blocks.into_iter().collect(); | |||
| unsafe_blocks.sort(); | |||
| unsafe_blocks.sort_by_cached_key(|(hir_id, _)| tcx.hir().hir_to_node_id(*hir_id)); | |||
There was a problem hiding this comment.
I'm not sure if this is the best way to tackle it, but the regular sort now breaks the order of error messages in 2 "unnecessary unsafe" test cases.
ljedrz
force-pushed
the
HirIdify_block
branch
from
86d4147
to
21bf549
Compare
|
Closing in favor of #58698. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next iteration of #57578. The relevant part is the last commit (the others are dependencies).
Blocked by #58561.
r? @Zoxc