Add custom ICE message that points to Clippy repo #4588

phansch · 2019-09-27T05:21:29Z

changelog: Link to Clippy issue tracker in ICE messages

This utilizes rust-lang/rust#60584 by setting
our own panic_hook and pointing to our own issue tracker instead of
the rustc issue tracker.

This also adds a new internal lint to test the ICE message.

Potential downsides

This essentially copies rustc's report_ice function as
report_clippy_ice. I think that's how it's meant to be implemented, but
maybe @jonas-schievink could have a look as well =)

The downside of more-or-less copying this function is that we have to
maintain it as well now.
The original function can be found here.
driver now depends directly on rustc and rustc_errors

Closes #2734

src/driver.rs

phansch · 2019-09-27T05:43:40Z

Looks like the test fails because locally I've been running without RUST_BACKTRACE=1, but travis runs all tests with RUST_BACKTRACE=1.

Is there a way to set the backtrace level in a compiletest header? If I just re-record the stderr output with RUST_BACKTRACE=1, it will fail for people locally when running without backtraces enabled.

jonas-schievink · 2019-09-27T11:04:20Z

This essentially copies rustc's report_ice function as
report_clippy_ice. I think that's how it's meant to be implemented, but
maybe @jonas-schievink could have a look as well =)

You can also call rustc_driver::report_ice and pass your custom URL, as long as that's all you want to customize.

flip1995 · 2019-09-27T13:59:35Z

clippy_lints/src/utils/internal_lints.rs

+fn is_trigger_fn(fn_kind: FnKind<'_>) -> bool {
+    match fn_kind {
+        FnKind::ItemFn(ident, ..) | FnKind::Method(ident, ..) => {
+            ident.name.as_str() == "should_trigger_an_ice_in_clippy"


Though Clippy internal lints are never emitted by Clippy, they still run all the time. I don't think that anyone would name a function should_trigger_an_ice_in_clippy, but I suggest to change this name to one of the following:

should_trigger_an_ice_when_clippy_is_run

Make it a Clippy easteregg and give it a cool name 😎 it_looks_like_you_are_trying_to_kill_clippy or similar. (https://twitter.com/ManishEarth/status/1107297057604145152)

ooh i like the easter egg idea

Manishearth

r+ with the function name changed 😄

phansch · 2019-10-09T06:00:12Z

I updated the function name and hopefully fixed the test 🙏

I decided to keep the copy of rustc's report_ice function, because that allows us to print the Clippy version in the ICE message. I think that's worth the extra code (and I could take ownership of that, if something breaks).

@bors r=Manishearth

bors · 2019-10-09T06:00:14Z

📌 Commit 1814964 has been approved by Manishearth

@jonas-schievink

Add custom ICE message that points to Clippy repo changelog: Link to Clippy issue tracker in ICE messages This utilizes rust-lang/rust#60584 by setting our own `panic_hook` and pointing to our own issue tracker instead of the rustc issue tracker. This also adds a new internal lint to test the ICE message. **Potential downsides** * This essentially copies rustc's `report_ice` function as `report_clippy_ice`. I think that's how it's meant to be implemented, but maybe @jonas-schievink could have a look as well =) The downside of more-or-less copying this function is that we have to maintain it as well now. The original function can be found [here][original]. * `driver` now depends directly on `rustc` and `rustc_errors` Closes #2734 [original]: https://github.com/rust-lang/rust/blob/59367b074f1523353dddefa678ffe3cac9fd4e50/src/librustc_driver/lib.rs#L1185

bors · 2019-10-09T06:00:21Z

⌛ Testing commit 1814964 with merge e261df4...

bors · 2019-10-09T06:00:51Z

💡 This pull request was already approved, no need to approve it again.

This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

bors · 2019-10-09T06:00:51Z

📌 Commit 1814964 has been approved by Manishearth

@jonas-schievink

Add custom ICE message that points to Clippy repo changelog: Link to Clippy issue tracker in ICE messages This utilizes rust-lang/rust#60584 by setting our own `panic_hook` and pointing to our own issue tracker instead of the rustc issue tracker. This also adds a new internal lint to test the ICE message. **Potential downsides** * This essentially copies rustc's `report_ice` function as `report_clippy_ice`. I think that's how it's meant to be implemented, but maybe @jonas-schievink could have a look as well =) The downside of more-or-less copying this function is that we have to maintain it as well now. The original function can be found [here][original]. * `driver` now depends directly on `rustc` and `rustc_errors` Closes #2734 [original]: https://github.com/rust-lang/rust/blob/59367b074f1523353dddefa678ffe3cac9fd4e50/src/librustc_driver/lib.rs#L1185

bors · 2019-10-09T06:00:58Z

⌛ Testing commit 1814964 with merge 64d77b2...

bors · 2019-10-09T06:33:54Z

💔 Test failed - checks-travis

phansch · 2019-10-09T07:01:50Z

Dogfood tests are failing, will fix them later today

jonas-schievink · 2019-10-09T18:55:47Z

@phansch did you see #4588 (comment)?

phansch · 2019-10-09T18:58:03Z

@phansch did you see #4588 (comment)?

Yup, thanks! It's just that it would be nice to also show the Clippy version instead of the rustc version in the ICE message. I don't think that's possible when using rustc_driver::report_ice?

Manishearth · 2019-10-09T19:08:15Z

We don't really version Clippy separately

…

On Wed, Oct 9, 2019, 11:58 AM Phil Hansch ***@***.***> wrote: @phansch <https://github.com/phansch> did you see #4588 (comment) <#4588 (comment)> ? Yup, thanks! It's just that it would be nice to also show the Clippy version instead of the rustc version in the ICE message. I don't think that's possible when using rustc_driver::report_ice? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4588?email_source=notifications&email_token=AAMK6SFJY47IJK4MEGEB2ADQNYST5A5CNFSM4I3B5TEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY6POI#issuecomment-540141497>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMK6SHNO43FKF3HCNCWYK3QNYST5ANCNFSM4I3B5TEA> .

phansch · 2019-10-09T19:14:38Z

We don't really version Clippy separately

Right, I meant the specific commit hash of the used Clippy. This could be useful for debugging nightly Clippy issues?

jonas-schievink · 2019-10-09T19:24:03Z

I see, that makes sense. One could also figure that out by looking at the rustc commit, but that's more work.

bors · 2019-10-14T17:34:47Z

☔ The latest upstream changes (presumably #4663) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2019-11-23T16:16:08Z

☔ The latest upstream changes (presumably #4825) made this pull request unmergeable. Please resolve the merge conflicts.

phansch · 2019-11-29T19:18:13Z

@bors r=Manishearth

bors · 2019-11-29T19:18:15Z

📌 Commit 6b5dd79 has been approved by Manishearth

bors · 2019-11-29T19:34:30Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout add_custom_ice_hook (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self add_custom_ice_hook --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging clippy_lints/src/lib.rs
Auto-merging Cargo.toml
CONFLICT (content): Merge conflict in Cargo.toml
Automatic merge failed; fix conflicts and then commit the result.

bors · 2019-11-29T19:35:38Z

☔ The latest upstream changes (presumably #4837) made this pull request unmergeable. Please resolve the merge conflicts.

@jonas-schievink

This utilizes rust-lang/rust#60584 by setting our own `panic_hook` and pointing to our own issue tracker instead of the rustc issue tracker. This also adds a new internal lint to test the ICE message. **Potential downsides** * This essentially copies rustc's `report_ice` function as `report_clippy_ice`. I think that's how it's meant to be implemented, but maybe @jonas-schievink could have a look as well =) The downside of more-or-less copying this function is that we have to maintain it as well now. The original function can be found [here][original]. * `driver` now depends directly on `rustc` and `rustc_errors` Closes rust-lang#2734 [original]: https://github.com/rust-lang/rust/blob/59367b074f1523353dddefa678ffe3cac9fd4e50/src/librustc_driver/lib.rs#L1185

phansch · 2019-11-29T19:48:16Z

@bors r=Manishearth

bors · 2019-11-29T19:48:17Z

📌 Commit c1ccba0 has been approved by Manishearth

@jonas-schievink

Add custom ICE message that points to Clippy repo changelog: Link to Clippy issue tracker in ICE messages This utilizes rust-lang/rust#60584 by setting our own `panic_hook` and pointing to our own issue tracker instead of the rustc issue tracker. This also adds a new internal lint to test the ICE message. **Potential downsides** * This essentially copies rustc's `report_ice` function as `report_clippy_ice`. I think that's how it's meant to be implemented, but maybe @jonas-schievink could have a look as well =) The downside of more-or-less copying this function is that we have to maintain it as well now. The original function can be found [here][original]. * `driver` now depends directly on `rustc` and `rustc_errors` Closes #2734 [original]: https://github.com/rust-lang/rust/blob/59367b074f1523353dddefa678ffe3cac9fd4e50/src/librustc_driver/lib.rs#L1185

bors · 2019-11-29T19:48:24Z

⌛ Testing commit c1ccba0 with merge 0e66a78...

bors · 2019-11-29T20:08:45Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 0e66a78 to master...

phansch commented Sep 27, 2019

View reviewed changes

src/driver.rs Outdated Show resolved Hide resolved

phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Sep 27, 2019

flip1995 reviewed Sep 27, 2019

View reviewed changes

Manishearth approved these changes Oct 4, 2019

View reviewed changes

phansch force-pushed the add_custom_ice_hook branch from 38b0d74 to bb4cd3a Compare October 8, 2019 19:37

phansch added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Oct 11, 2019

phansch added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 3, 2019

phansch force-pushed the add_custom_ice_hook branch from 4287e9e to a4dc78a Compare November 15, 2019 07:53

phansch removed the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Nov 16, 2019

phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Nov 28, 2019

phansch self-assigned this Nov 28, 2019

phansch force-pushed the add_custom_ice_hook branch from a4dc78a to 6b5dd79 Compare November 29, 2019 18:42

phansch added 8 commits November 29, 2019 20:47

Use Clippy version in ICE message

fc57c84

Update custom ICE function with latest rustc

36c6a18

Use exec_env to set backtrace level and normalize output

5029dfe

Make triggering this lint less likely 📎

ad6d8a4

Use rustc_env instead of exec_env for test

21dee8f

Feed the dog

44eec08

fmt

c1ccba0

phansch force-pushed the add_custom_ice_hook branch from 6b5dd79 to c1ccba0 Compare November 29, 2019 19:47

bors merged commit c1ccba0 into rust-lang:master Nov 29, 2019

matthiaskrgr mentioned this pull request Dec 2, 2019

custom ice message test fails inside rustc repo due to wrong file path #4872

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add custom ICE message that points to Clippy repo #4588

Add custom ICE message that points to Clippy repo #4588

phansch commented Sep 27, 2019 •

edited

Loading

phansch commented Sep 27, 2019

jonas-schievink commented Sep 27, 2019

flip1995 Sep 27, 2019 •

edited

Loading

Manishearth Oct 4, 2019

Manishearth left a comment

phansch commented Oct 9, 2019 •

edited

Loading

bors commented Oct 9, 2019

bors commented Oct 9, 2019

bors commented Oct 9, 2019

bors commented Oct 9, 2019

bors commented Oct 9, 2019

bors commented Oct 9, 2019

phansch commented Oct 9, 2019

jonas-schievink commented Oct 9, 2019

phansch commented Oct 9, 2019

Manishearth commented Oct 9, 2019 via email

phansch commented Oct 9, 2019

jonas-schievink commented Oct 9, 2019

bors commented Oct 14, 2019

bors commented Nov 23, 2019

phansch commented Nov 29, 2019

bors commented Nov 29, 2019

bors commented Nov 29, 2019

bors commented Nov 29, 2019

phansch commented Nov 29, 2019

bors commented Nov 29, 2019

bors commented Nov 29, 2019

bors commented Nov 29, 2019

Add custom ICE message that points to Clippy repo #4588

Add custom ICE message that points to Clippy repo #4588

Conversation

phansch commented Sep 27, 2019 • edited Loading

phansch commented Sep 27, 2019

jonas-schievink commented Sep 27, 2019

flip1995 Sep 27, 2019 • edited Loading

Choose a reason for hiding this comment

Manishearth Oct 4, 2019

Choose a reason for hiding this comment

Manishearth left a comment

Choose a reason for hiding this comment

phansch commented Oct 9, 2019 • edited Loading

bors commented Oct 9, 2019

bors commented Oct 9, 2019

bors commented Oct 9, 2019

bors commented Oct 9, 2019

bors commented Oct 9, 2019

bors commented Oct 9, 2019

phansch commented Oct 9, 2019

jonas-schievink commented Oct 9, 2019

phansch commented Oct 9, 2019

Manishearth commented Oct 9, 2019 via email

phansch commented Oct 9, 2019

jonas-schievink commented Oct 9, 2019

bors commented Oct 14, 2019

bors commented Nov 23, 2019

phansch commented Nov 29, 2019

bors commented Nov 29, 2019

bors commented Nov 29, 2019

bors commented Nov 29, 2019

phansch commented Nov 29, 2019

bors commented Nov 29, 2019

bors commented Nov 29, 2019

bors commented Nov 29, 2019

phansch commented Sep 27, 2019 •

edited

Loading

flip1995 Sep 27, 2019 •

edited

Loading

phansch commented Oct 9, 2019 •

edited

Loading