RIIR: Integration tests #4837
Merged
RIIR: Integration tests #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors try |
bors
added a commit
that referenced
this pull request
Nov 23, 2019
[WIP] RIIR: Integration tests In #4825 the `rust-lang/chalk` test failed because the output was too large. I didn't want to completely disabling the output, since showing the backtrace of an ICE directly in travis is pretty useful. Since finding strings in command outputs is easier in Rust, than in bash, I just RIIRed it. This and also rewriting our tests in Rust may help with trying out new CI platforms (cc #4577) Based on #4825, so I could test it. changelog: none
flip1995
force-pushed
the
integration
branch
3 times, most recently
from
99d6e36 to
4a63429
Compare
|
@bors try |
bors
added a commit
that referenced
this pull request
Nov 23, 2019
[WIP] RIIR: Integration tests In #4825 the `rust-lang/chalk` test failed because the output was too large. I didn't want to completely disabling the output, since showing the backtrace of an ICE directly in travis is pretty useful. Since finding strings in command outputs is easier in Rust, than in bash, I just RIIRed it. This and also rewriting our tests in Rust may help with trying out new CI platforms (cc #4577) changelog: none
flip1995
force-pushed
the
integration
branch
from
4a63429 to
ab67235
Compare
|
@bors try (and now with cache) |
bors
added a commit
that referenced
this pull request
Nov 25, 2019
[WIP] RIIR: Integration tests In #4825 the `rust-lang/chalk` test failed because the output was too large. I didn't want to completely disabling the output, since showing the backtrace of an ICE directly in travis is pretty useful. Since finding strings in command outputs is easier in Rust, than in bash, I just RIIRed it. This and also rewriting our tests in Rust may help with trying out new CI platforms (cc #4577) changelog: none
|
💔 Test failed - status-appveyor |
flip1995
added
the
S-waiting-on-review
|
@bors try |
bors
added a commit
that referenced
this pull request
Nov 28, 2019
RIIR: Integration tests In #4825 the `rust-lang/chalk` test failed because the output was too large. I didn't want to completely disabling the output, since showing the backtrace of an ICE directly in travis is pretty useful. Since finding strings in command outputs is easier in Rust, than in bash, I just RIIRed it. This and also rewriting our tests in Rust may help with trying out new CI platforms (cc #4577) changelog: none
|
☔ The latest upstream changes (presumably #4849) made this pull request unmergeable. Please resolve the merge conflicts. |
|
💔 Test failed - checks-travis |
flip1995
force-pushed
the
integration
branch
from
ab67235 to
f0d7bd1
Compare
flip1995
force-pushed
the
integration
branch
from
f0d7bd1 to
a6289cc
Compare
|
This takes about 1 minute longer per integration test. I think this is because of the additional deps and that I think this is worth though. |
phansch
added
S-waiting-on-bors
|
re the shallow clones: It seems like there is active work going on at libgit2/libgit2#3058 The 1 minute extra time is fine with me 👍 |
phansch
approved these changes
Nov 28, 2019
phansch
reviewed
Nov 28, 2019
Co-Authored-By: Phil Hansch <dev@phansch.net>
|
@bors r=phansch |
|
📌 Commit 82066d2 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 29, 2019
RIIR: Integration tests In #4825 the `rust-lang/chalk` test failed because the output was too large. I didn't want to completely disabling the output, since showing the backtrace of an ICE directly in travis is pretty useful. Since finding strings in command outputs is easier in Rust, than in bash, I just RIIRed it. This and also rewriting our tests in Rust may help with trying out new CI platforms (cc #4577) changelog: none
|
💔 Test failed - checks-travis |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Nov 29, 2019
RIIR: Integration tests In #4825 the `rust-lang/chalk` test failed because the output was too large. I didn't want to completely disabling the output, since showing the backtrace of an ICE directly in travis is pretty useful. Since finding strings in command outputs is easier in Rust, than in bash, I just RIIRed it. This and also rewriting our tests in Rust may help with trying out new CI platforms (cc #4577) changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4825 the
rust-lang/chalktest failed because the output was too large. I didn't want to completely disabling the output, since showing the backtrace of an ICE directly in travis is pretty useful. Since finding strings in command outputs is easier in Rust, than in bash, I just RIIRed it.This and also rewriting our tests in Rust may help with trying out new CI platforms (cc #4577)
changelog: none