Rollup of 4 pull requests #4789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Philipp Krones <hello@philkrones.com>
Co-Authored-By: Philipp Krones <hello@philkrones.com>
- Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py
Remove recalculation of literal value.
restriction lint for `std::process::exit` Addition to rust-lang#4655 - adds the lint checking for `std::process::exit` changelog: add restriction lint for `std::process::exit`
Fix Deprecated lints don't expand ### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py ### fixes rust-lang#4748 Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.  changelog: Show deprecated lints in lint documentation again
`DecimalLiteralRepresentation` simplification Remove recalculation of literal value. changelog: none
don't warn on CRLF in `with_newline` lints changelog: don't warn on CRLF in `print_with_newline` and `write_with_newline` fixes rust-lang#4208. This PR also transitions the unescaping logic to use the compiler's lexer.
|
@bors r+ p=4 |
|
📌 Commit 5e1a7ae has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
|
☔ The latest upstream changes (presumably #4788) made this pull request unmergeable. Please resolve the merge conflicts. |
|
#4697 needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
std::process::exit#4697 (restriction lint forstd::process::exit)DecimalLiteralRepresentationsimplification #4758 (DecimalLiteralRepresentationsimplification)with_newlinelints #4769 (don't warn on CRLF inwith_newlinelints)Failed merges:
r? @ghost
changelog: none