Code

Rollup of 12 pull requests#5432

Code

Closed

flip1995 wants to merge 55 commits intorust-lang:masterrust-lang/rust-clippy:masterfrom flip1995:rollup-9bj28lrflip1995/rust-clippy:rollup-9bj28lrCopy head branch name to clipboard

+887-603

Commits

Commits on Mar 20, 2020

• Add lint when comparing floats in an array

  Show description for 5f1bb72
  

  briankabiro

  authored and

  marcin-serwin

  committed
  5f1bb72

• Add tests for float in array comparison

  

  briankabiro

  authored and

  marcin-serwin

  committed
  b53bcc7

• Update field names in is_float

  marcin-serwin

  committed
  e91f5b2

• Update stderr of float_cmp test

  marcin-serwin

  committed
  0f9a0f8

• Add handling of float arrays to miri_to_const

  marcin-serwin

  committed
  b630644

• Handle evaluating constant index expression

  marcin-serwin

  committed
  0766002

• Allow for const arrays of zeros

  marcin-serwin

  committed
  74f5090

• Don't show comparison suggestion for arrays

  marcin-serwin

  committed
  bce1293

• Handle constant arrays with single value

  marcin-serwin

  committed
  4165236

• Add float cmp tests for arrays

  marcin-serwin

  committed
  517fa65

• Add float cmp const tests for arrays

  marcin-serwin

  committed
  1a7bddb

Commits on Apr 3, 2020

• Downgrade let_unit_value to pedantic

  dtolnay

  committed
  adcaa1b

• Downgrade trivially_copy_pass_by_ref to pedantic

  dtolnay

  committed
  94154ca

• Downgrade inefficient_to_string to pedantic

  dtolnay

  committed
  e26ae7a

• Clean up update_lints

  flip1995

  committed
  ffb2e41

• Get rid of Lint::is_internal method

  flip1995

  committed
  da67982

• Build lint lists once and the reuse them to update files

  flip1995

  committed
  98c30fe

• Don't filter lints in code generation functions

  flip1995

  committed
  a186d9f

• Make lint modules private

  flip1995

  committed
  d89bb50

• Run update_lints

  flip1995

  committed
  045722a

• Move matches test in matches module

  flip1995

  committed
  30503a9

Commits on Apr 4, 2020

• result_map_or_into_option: add lint to catch manually adpating Result -> Option

  Show description for 91d8a80
  nickrtorres

  committed
  91d8a80

• Rename rustc -> rustc_middle in doc links

  flip1995

  committed
  2481d3c

• Update CONTRIBUTING.md

  flip1995

  committed
  fac5a41

• Downgrade unreadable_literal to pedantic

  dtolnay

  committed
  be34bc4

• Downgrade new_ret_no_self to pedantic

  dtolnay

  committed
  560c8c9

• result_map_or_into_option: explicitly note absence of known problems

  nickrtorres

  committed
  91759a7

• result_map_or_into_option: add good and bad examples

  nickrtorres

  committed
  3a29aed

• result_map_or_into_option: destructure lint tuple or return early

  nickrtorres

  committed
  d0738bd

• result_map_or_into_option: add opt.map_or(None, |_| Some(y)) test

  nickrtorres

  committed
  fb276dc

• result_map_or_into_option: move arg checks into tuple assignment

  nickrtorres

  committed
  acc3bc1

• result_map_or_into_option: fix cargo dev fmt --check errors

  nickrtorres

  committed
  2533f56

• CONTRIBUTING.md: fix broken triage link

  nickrtorres

  committed
  fecdb72

• result_map_or_into: fix dogfood_clippy error => {h,l}int

  nickrtorres

  committed
  325d0b6

Commits on Apr 5, 2020

• result_map_or_into_option: fix syntax error in example

  nickrtorres

  committed
  5d54fbb

• Include OpAssign in suspicious_op_assign_impl

  jpospychala

  committed
  9c9af1d

Commits on Apr 6, 2020

• Make epsilon note spanless when comparing arrays

  marcin-serwin

  committed
  f8fd4ac

• Indicate when arrays are compared in error message

  marcin-serwin

  committed
  7294acb

• Split check_fn function

  marcin-serwin

  committed
  16b4003

• Make the epsilon note spanless

  marcin-serwin

  committed
  4348af2

• Lint on opt.as_ref().map(|x| &**x).

  xiongmao86

  committed
  4f14826

Commits on Apr 7, 2020

• Refine lint message.

  xiongmao86

  committed
  d7056f8

• Rollup merge of rust-lang#5345 - Toxyxer:add-lint-for-float-in-array-comparison, r=flip1995

  Show description for acd4342
  flip1995

  authored
  acd4342

• Rollup merge of rust-lang#5406 - flip1995:update_lints_fix, r=flip1995

  Show description for 3da43d0
  flip1995

  authored
  3da43d0

• Rollup merge of rust-lang#5409 - dtolnay:letunit, r=flip1995

  Show description for 52ca269
  flip1995

  authored
  52ca269

• Rollup merge of rust-lang#5410 - dtolnay:trivially, r=flip1995

  Show description for e26c922
  flip1995

  authored
  e26c922

• Rollup merge of rust-lang#5412 - dtolnay:tostring, r=flip1995

  Show description for 5afb882
  flip1995

  authored
  5afb882

• Rollup merge of rust-lang#5415 - nickrtorres:master, r=flip1995

  Show description for 0c63766
  flip1995

  authored
  0c63766

• Rollup merge of rust-lang#5417 - flip1995:doc_update, r=flip1995

  Show description for 858bfd4
  flip1995

  authored
  858bfd4

• Rollup merge of rust-lang#5419 - dtolnay:unreadable, r=flip1995

  Show description for 642d743
  flip1995

  authored
  642d743

• Rollup merge of rust-lang#5420 - dtolnay:newret, r=flip1995

  Show description for 3ef6b9b
  flip1995

  authored
  3ef6b9b

• Rollup merge of rust-lang#5422 - nickrtorres:contributing-triage, r=flip1995

  Show description for e55ec76
  flip1995

  authored
  e55ec76

• Rollup merge of rust-lang#5424 - jpospychala:suspicious_op_assign_impl, r=flip1995

  Show description for 1242808
  flip1995

  authored
  1242808

• Rollup merge of rust-lang#5425 - xiongmao86:issue5367, r=flip1995

  Show description for 635518f
  flip1995

  authored
  635518f

• Run fmt

  flip1995

  committed
  f663da1