Skip to content

Commit

Permalink
auto merge of #17948 : jakub-/rust/issue-17933, r=alexcrichton
Browse files Browse the repository at this point in the history
Fixes #17933.
  • Loading branch information
bors committed Oct 13, 2014
2 parents a6e0c76 + fdc1eea commit 70d8b8d
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/librustc/middle/resolve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5073,10 +5073,15 @@ impl<'a> Resolver<'a> {
Some(def @ (DefFn(..), _)) |
Some(def @ (DefVariant(..), _)) |
Some(def @ (DefStruct(..), _)) |
Some(def @ (DefConst(..), _)) |
Some(def @ (DefStatic(..), _)) => {
Some(def @ (DefConst(..), _)) => {
self.record_def(pattern.id, def);
}
Some((DefStatic(..), _)) => {
self.resolve_error(path.span,
"static variables cannot be \
referenced in a pattern, \
use a `const` instead");
}
Some(_) => {
self.resolve_error(path.span,
format!("`{}` is not an enum variant, struct or const",
Expand Down
19 changes: 19 additions & 0 deletions src/test/compile-fail/issue-17933.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

pub static X: uint = 1u;

fn main() {
match 1u {
self::X => { },
//~^ ERROR static variables cannot be referenced in a pattern, use a `const` instead
_ => { },
}
}

0 comments on commit 70d8b8d

Please sign in to comment.