Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the diagnostic for static variables in patterns better #17948

Merged
merged 1 commit into from Oct 13, 2014
Merged

Make the diagnostic for static variables in patterns better #17948

merged 1 commit into from Oct 13, 2014

Conversation

ghost
Copy link

@ghost ghost commented Oct 11, 2014

Fixes #17933.

@ghost
Copy link
Author

ghost commented Oct 12, 2014

@alexcrichton Unused variable warning, could we try again?

bors added a commit that referenced this pull request Oct 13, 2014
@bors bors closed this Oct 13, 2014
@bors bors merged commit fdc1eea into rust-lang:master Oct 13, 2014
@ghost ghost deleted the issue-17933 branch October 16, 2014 22:27
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 29, 2024
…kril

fix: Wrong `Self: Sized` predicate for trait assoc items

Again while implementing object safety like rust-lang#17939 😅

If we call `generic_predicates_query` on `fn foo` in the following code;
```
trait Foo {
    fn foo();
}
```
It returns implicit bound `Self: Sized`, even though `Self` is not appearing as a generic parameter inside angle brackets, but as a parent generic parameter, "trait self".

This PR prevent pushing "implicit" `Self: Sized` predicates in such cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintelligible error for statics in pattern position
1 participant