-
Notifications
You must be signed in to change notification settings - Fork 12.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #80707 - oli-obk:stability_hole_const_intrinsics, r=Ral…
…fJung Stability oddity with const intrinsics cc `@RalfJung` In #80699 (comment) `@usbalbin` realized we accepted some intrinsics as `const` without a `#[rustc_const_(un)stable]` attribute. I did some digging, and that example works because intrinsics inherit their stability from their parents... including `#[rustc_const_(un)stable]` attributes. While we may want to fix that (not sure, wasn't there just a MCPed PR that caused this on purpose?), we definitely want tests for it, thus this PR adding tests and some fun tracing statements.
- Loading branch information
Showing
8 changed files
with
130 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
#![feature(intrinsics, staged_api, const_intrinsic_copy)] | ||
#![stable(feature = "core", since = "1.6.0")] | ||
|
||
#[stable(feature = "rust1", since = "1.0.0")] | ||
#[rustc_const_unstable(feature = "const_intrinsic_copy", issue = "80697")] | ||
#[inline] | ||
pub const unsafe fn copy<T>(src: *const T, dst: *mut T, count: usize) { | ||
// Const stability attributes are not inherited from parent items. | ||
extern "rust-intrinsic" { | ||
fn copy<T>(src: *const T, dst: *mut T, count: usize); | ||
} | ||
|
||
unsafe { copy(src, dst, count) } | ||
//~^ ERROR calls in constant functions are limited to constant functions | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
error[E0015]: calls in constant functions are limited to constant functions, tuple structs and tuple variants | ||
--> $DIR/intrinsic_without_const_stab.rs:13:14 | ||
| | ||
LL | unsafe { copy(src, dst, count) } | ||
| ^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0015`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#![feature(intrinsics, staged_api, const_intrinsic_copy)] | ||
#![stable(feature = "core", since = "1.6.0")] | ||
|
||
extern "rust-intrinsic" { | ||
fn copy<T>(src: *const T, dst: *mut T, count: usize); | ||
} | ||
|
||
#[stable(feature = "rust1", since = "1.0.0")] | ||
#[rustc_const_unstable(feature = "const_intrinsic_copy", issue = "80697")] | ||
#[inline] | ||
pub const unsafe fn stuff<T>(src: *const T, dst: *mut T, count: usize) { | ||
unsafe { copy(src, dst, count) } //~ ERROR calls in constant functions are limited | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
error[E0015]: calls in constant functions are limited to constant functions, tuple structs and tuple variants | ||
--> $DIR/intrinsic_without_const_stab_fail.rs:12:14 | ||
| | ||
LL | unsafe { copy(src, dst, count) } | ||
| ^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0015`. |