Stability oddity with const intrinsics #80707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
force-pushed
the
stability_hole_const_intrinsics
branch
from
0626088
to
7da07bf
Compare
|
r? @RalfJung |
bjorn3
reviewed
Jan 5, 2021
|
The job Click to see the possible cause of the failure (guessed by this bot) |
oli-obk
force-pushed
the
stability_hole_const_intrinsics
branch
from
14e2c38
to
074a69b
Compare
RalfJung
reviewed
Jan 6, 2021
Oh, that's interesting. For normal intrinsics this makes sense (when declared inside a |
So... should I try to fix it in this PR? |
RalfJung
reviewed
Jan 13, 2021
|
I think it should be fixed... and that makes the tests added in this PR a bit odd since they test behavior that I consider buggy. But I'd also be okay with opening an issue and having a comment in the test saying that this is testing buggy behavior and should be adjusted once there's a fix. |
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Jan 17, 2021
RalfJung
reviewed
Jan 17, 2021
RalfJung
reviewed
Jan 17, 2021
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Jan 17, 2021
library/core/src/intrinsics.rs
Outdated
| @@ -1849,6 +1849,7 @@ pub(crate) fn is_nonoverlapping<T>(src: *const T, dst: *const T, count: usize) - | |||
| #[inline] | |||
| pub const unsafe fn copy_nonoverlapping<T>(src: *const T, dst: *mut T, count: usize) { | |||
| extern "rust-intrinsic" { | |||
| #[rustc_const_unstable(feature = "const_intrinsic_copy", issue = "none")] | |||
There was a problem hiding this comment.
Looks like we have another case of this a few lines down, around line 1940, according to CI.
There was a problem hiding this comment.
yea, I had to rebase first ^^
|
r=me with CI fixed and the commits squashed a bit. |
oli-obk
force-pushed
the
stability_hole_const_intrinsics
branch
from
84e414c
to
2a412ae
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
stability_hole_const_intrinsics
branch
from
2a412ae
to
5bac1c9
Compare
|
@bors r=RalfJung |
|
📌 Commit 5bac1c9 has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jan 18, 2021
…sics, r=RalfJung Stability oddity with const intrinsics cc `@RalfJung` In rust-lang#80699 (comment) `@usbalbin` realized we accepted some intrinsics as `const` without a `#[rustc_const_(un)stable]` attribute. I did some digging, and that example works because intrinsics inherit their stability from their parents... including `#[rustc_const_(un)stable]` attributes. While we may want to fix that (not sure, wasn't there just a MCPed PR that caused this on purpose?), we definitely want tests for it, thus this PR adding tests and some fun tracing statements.
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @RalfJung
In #80699 (comment) @usbalbin realized we accepted some intrinsics as
constwithout a#[rustc_const_(un)stable]attribute. I did some digging, and that example works because intrinsics inherit their stability from their parents... including#[rustc_const_(un)stable]attributes. While we may want to fix that (not sure, wasn't there just a MCPed PR that caused this on purpose?), we definitely want tests for it, thus this PR adding tests and some fun tracing statements.