Stability oddity with const intrinsics #80707

oli-obk · 2021-01-04T23:40:02Z

In #80699 (comment) @usbalbin realized we accepted some intrinsics as const without a #[rustc_const_(un)stable] attribute. I did some digging, and that example works because intrinsics inherit their stability from their parents... including #[rustc_const_(un)stable] attributes. While we may want to fix that (not sure, wasn't there just a MCPed PR that caused this on purpose?), we definitely want tests for it, thus this PR adding tests and some fun tracing statements.

rust-highfive · 2021-01-04T23:40:06Z

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2021-01-05T00:04:04Z

r? @RalfJung

src/test/ui/consts/intrinsic_without_const_stab_fail.rs

rust-log-analyzer · 2021-01-05T14:44:52Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

.................................................................................................... 9000/11246
.................................................................................................... 9100/11246
.................................................................................................... 9200/11246
...........................................i.....i.................................................. 9300/11246
.................................................................................iiiiii..iiiiii.i... 9400/11246
.................................................................................................... 9600/11246
.................................................................................................... 9700/11246
.................................................................................................... 9800/11246
.................................................................................................... 9900/11246
---
.....................................i.............................................................. 11200/11246
..............................................
failures:

---- [ui] ui/consts/intrinsic_without_const_stab_fail.rs stdout ----


1 error[E0015]: calls in constant functions are limited to constant functions, tuple structs and tuple variants
-   --> $DIR/intrinsic_without_const_stab_fail.rs:15:14
+   --> $DIR/intrinsic_without_const_stab_fail.rs:12:14
3    |
4 LL |     unsafe { copy(src, dst, count) }


The actual stderr differed from the expected stderr.
The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/intrinsic_without_const_stab_fail/intrinsic_without_const_stab_fail.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args consts/intrinsic_without_const_stab_fail.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/intrinsic_without_const_stab_fail.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/intrinsic_without_const_stab_fail" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/intrinsic_without_const_stab_fail/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error[E0015]: calls in constant functions are limited to constant functions, tuple structs and tuple variants
  --> /checkout/src/test/ui/consts/intrinsic_without_const_stab_fail.rs:12:14
   |
LL |     unsafe { copy(src, dst, count) } //~ ERROR calls in constant functions are limited

error: aborting due to previous error

For more information about this error, try `rustc --explain E0015`.
---

Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "ui" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-9/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "9.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:16:03

compiler/rustc_mir/src/transform/check_consts/validation.rs

RalfJung · 2021-01-06T14:15:42Z

hat example works because intrinsics inherit their stability from their parents

Oh, that's interesting. For normal intrinsics this makes sense (when declared inside a fn they anyway cannot be used from the outside), but since const stability has this extra property of being recursive (stable things may not call unstable things), IMO this makes less sense.

oli-obk · 2021-01-11T11:09:49Z

since const stability has this extra property of being recursive (stable things may not call unstable things), IMO this makes less sense.

So... should I try to fix it in this PR?

compiler/rustc_mir/src/transform/check_consts/validation.rs

RalfJung · 2021-01-13T18:33:18Z

I think it should be fixed... and that makes the tests added in this PR a bit odd since they test behavior that I consider buggy. But I'd also be okay with opening an issue and having a comment in the test saying that this is testing buggy behavior and should be adjusted once there's a fix.

compiler/rustc_mir/src/transform/check_consts/validation.rs

compiler/rustc_passes/src/stability.rs

RalfJung · 2021-01-17T13:18:56Z

library/core/src/intrinsics.rs

@@ -1849,6 +1849,7 @@ pub(crate) fn is_nonoverlapping<T>(src: *const T, dst: *const T, count: usize) -
 #[inline]
 pub const unsafe fn copy_nonoverlapping<T>(src: *const T, dst: *mut T, count: usize) {
    extern "rust-intrinsic" {
+        #[rustc_const_unstable(feature = "const_intrinsic_copy", issue = "none")]


Looks like we have another case of this a few lines down, around line 1940, according to CI.

yea, I had to rebase first ^^

RalfJung · 2021-01-17T13:19:07Z

r=me with CI fixed and the commits squashed a bit.

oli-obk · 2021-01-18T16:30:09Z

@bors r=RalfJung

bors · 2021-01-18T16:30:11Z

📌 Commit 5bac1c9 has been approved by RalfJung

…sics, r=RalfJung Stability oddity with const intrinsics cc `@RalfJung` In rust-lang#80699 (comment) `@usbalbin` realized we accepted some intrinsics as `const` without a `#[rustc_const_(un)stable]` attribute. I did some digging, and that example works because intrinsics inherit their stability from their parents... including `#[rustc_const_(un)stable]` attributes. While we may want to fix that (not sure, wasn't there just a MCPed PR that caused this on purpose?), we definitely want tests for it, thus this PR adding tests and some fun tracing statements.

bors · 2021-01-18T20:54:42Z

⌛ Testing commit 5bac1c9 with merge d98d2f5...

bors · 2021-01-19T00:00:14Z

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing d98d2f5 to master...

rust-highfive assigned petrochenkov Jan 4, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2021

oli-obk force-pushed the stability_hole_const_intrinsics branch from 0626088 to 7da07bf Compare January 4, 2021 23:40

rust-highfive assigned RalfJung and unassigned petrochenkov Jan 5, 2021

bjorn3 reviewed Jan 5, 2021

View reviewed changes

src/test/ui/consts/intrinsic_without_const_stab_fail.rs Outdated Show resolved Hide resolved

oli-obk force-pushed the stability_hole_const_intrinsics branch from 14e2c38 to 074a69b Compare January 5, 2021 15:46

RalfJung reviewed Jan 6, 2021

View reviewed changes

compiler/rustc_mir/src/transform/check_consts/validation.rs Show resolved Hide resolved

RalfJung reviewed Jan 13, 2021

View reviewed changes

compiler/rustc_mir/src/transform/check_consts/validation.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

RalfJung reviewed Jan 17, 2021

View reviewed changes

compiler/rustc_mir/src/transform/check_consts/validation.rs Outdated Show resolved Hide resolved

RalfJung reviewed Jan 17, 2021

View reviewed changes

compiler/rustc_passes/src/stability.rs Outdated Show resolved Hide resolved

RalfJung reviewed Jan 17, 2021

View reviewed changes

compiler/rustc_passes/src/stability.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

RalfJung reviewed Jan 17, 2021

View reviewed changes

oli-obk added 2 commits January 17, 2021 13:40

Remove an unnecessary field from a NonConstOp

ad5aa23

Add regression test

949bdd8

oli-obk force-pushed the stability_hole_const_intrinsics branch from 84e414c to 2a412ae Compare January 17, 2021 13:40

This comment has been minimized.

Sign in to view

Only inherit const stability for methods of impl const Trait blocks

5bac1c9

oli-obk force-pushed the stability_hole_const_intrinsics branch from 2a412ae to 5bac1c9 Compare January 18, 2021 11:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2021

m-ou-se mentioned this pull request Jan 18, 2021

Rollup of 10 pull requests #81171

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 19, 2021

bors merged commit d98d2f5 into rust-lang:master Jan 19, 2021

rustbot added this to the 1.51.0 milestone Jan 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stability oddity with const intrinsics #80707

Stability oddity with const intrinsics #80707

oli-obk commented Jan 4, 2021

rust-highfive commented Jan 4, 2021

petrochenkov commented Jan 5, 2021

rust-log-analyzer commented Jan 5, 2021

RalfJung commented Jan 6, 2021

oli-obk commented Jan 11, 2021

RalfJung commented Jan 13, 2021

This comment has been minimized.

This comment has been minimized.

RalfJung Jan 17, 2021

oli-obk Jan 17, 2021

RalfJung commented Jan 17, 2021

This comment has been minimized.

oli-obk commented Jan 18, 2021

bors commented Jan 18, 2021

bors commented Jan 18, 2021

bors commented Jan 19, 2021

Stability oddity with const intrinsics #80707

Stability oddity with const intrinsics #80707

Conversation

oli-obk commented Jan 4, 2021

rust-highfive commented Jan 4, 2021

petrochenkov commented Jan 5, 2021

rust-log-analyzer commented Jan 5, 2021

RalfJung commented Jan 6, 2021

oli-obk commented Jan 11, 2021

RalfJung commented Jan 13, 2021

This comment has been minimized.

This comment has been minimized.

RalfJung Jan 17, 2021

Choose a reason for hiding this comment

oli-obk Jan 17, 2021

Choose a reason for hiding this comment

RalfJung commented Jan 17, 2021

This comment has been minimized.

oli-obk commented Jan 18, 2021

bors commented Jan 18, 2021

bors commented Jan 18, 2021

bors commented Jan 19, 2021