Skip to content

Commit

Permalink
Rollup merge of #128402 - oli-obk:checked_attrs, r=compiler-errors
Browse files Browse the repository at this point in the history
Attribute checking simplifications

remove an unused boolean and then merge two big matches into one

I was reviewing some attributes and realized we don't really check this list against the list of builtin attributes, so we "may" totally be missing some attributes that we should be checking (like the `coroutine` attribute, which you can just apply to random stuff)

```rust
#![feature(coroutines)]
#[coroutine]
struct Foo;
```

just compiles for example. Unless we check that the fallthrough match arm is never reached for builtin attributes, we're just going to keep forgetting to add them here, too. I can do that without the changes in this PR, but it seemed like a nice cleanup
  • Loading branch information
matthiaskrgr committed Jul 31, 2024
2 parents 5c63363 + 67a08b5 commit e2d8f1a
Showing 1 changed file with 179 additions and 367 deletions.
Loading

0 comments on commit e2d8f1a

Please sign in to comment.