Attribute checking simplifications #128402

oli-obk · 2024-07-30T15:09:34Z

remove an unused boolean and then merge two big matches into one

I was reviewing some attributes and realized we don't really check this list against the list of builtin attributes, so we "may" totally be missing some attributes that we should be checking (like the coroutine attribute, which you can just apply to random stuff)

#![feature(coroutines)]
#[coroutine]
struct Foo;

just compiles for example. Unless we check that the fallthrough match arm is never reached for builtin attributes, we're just going to keep forgetting to add them here, too. I can do that without the changes in this PR, but it seemed like a nice cleanup

remove an unused boolean and then merge two big matches into one

rustbot · 2024-07-30T15:09:43Z

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler-errors

r=me when green

compiler-errors · 2024-07-30T17:10:24Z

@bors r+

bors · 2024-07-30T17:10:26Z

📌 Commit 67a08b5 has been approved by compiler-errors

It is now in the queue for this repository.

…errors Attribute checking simplifications remove an unused boolean and then merge two big matches into one I was reviewing some attributes and realized we don't really check this list against the list of builtin attributes, so we "may" totally be missing some attributes that we should be checking (like the `coroutine` attribute, which you can just apply to random stuff) ```rust #![feature(coroutines)] #[coroutine] struct Foo; ``` just compiles for example. Unless we check that the fallthrough match arm is never reached for builtin attributes, we're just going to keep forgetting to add them here, too. I can do that without the changes in this PR, but it seemed like a nice cleanup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127830 (When an archive fails to build, print the path) - rust-lang#128151 (Structured suggestion for `extern crate foo` when `foo` isn't resolved in import) - rust-lang#128161 (nested aux-build in tests/rustdoc/ tests) - rust-lang#128387 (More detailed note to deprecate ONCE_INIT) - rust-lang#128388 (Match LLVM ABI in `extern "C"` functions for `f128` on Windows) - rust-lang#128402 (Attribute checking simplifications) r? `@ghost` `@rustbot` modify labels: rollup

…errors Attribute checking simplifications remove an unused boolean and then merge two big matches into one I was reviewing some attributes and realized we don't really check this list against the list of builtin attributes, so we "may" totally be missing some attributes that we should be checking (like the `coroutine` attribute, which you can just apply to random stuff) ```rust #![feature(coroutines)] #[coroutine] struct Foo; ``` just compiles for example. Unless we check that the fallthrough match arm is never reached for builtin attributes, we're just going to keep forgetting to add them here, too. I can do that without the changes in this PR, but it seemed like a nice cleanup

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#128151 (Structured suggestion for `extern crate foo` when `foo` isn't resolved in import) - rust-lang#128162 (Cleanup sys module to match house style) - rust-lang#128402 (Attribute checking simplifications) - rust-lang#128404 (Revert recent changes to dead code analysis) - rust-lang#128417 (Add `f16` and `f128` math functions) r? `@ghost` `@rustbot` modify labels: rollup

…errors Attribute checking simplifications remove an unused boolean and then merge two big matches into one I was reviewing some attributes and realized we don't really check this list against the list of builtin attributes, so we "may" totally be missing some attributes that we should be checking (like the `coroutine` attribute, which you can just apply to random stuff) ```rust #![feature(coroutines)] #[coroutine] struct Foo; ``` just compiles for example. Unless we check that the fallthrough match arm is never reached for builtin attributes, we're just going to keep forgetting to add them here, too. I can do that without the changes in this PR, but it seemed like a nice cleanup

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#128151 (Structured suggestion for `extern crate foo` when `foo` isn't resolved in import) - rust-lang#128162 (Cleanup sys module to match house style) - rust-lang#128402 (Attribute checking simplifications) - rust-lang#128417 (Add `f16` and `f128` math functions) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#126454 (bump-stage0: use IndexMap for determinism) - rust-lang#127681 (derive(SmartPointer): rewrite bounds in where and generic bounds) - rust-lang#127830 (When an archive fails to build, print the path) - rust-lang#128151 (Structured suggestion for `extern crate foo` when `foo` isn't resolved in import) - rust-lang#128387 (More detailed note to deprecate ONCE_INIT) - rust-lang#128388 (Match LLVM ABI in `extern "C"` functions for `f128` on Windows) - rust-lang#128402 (Attribute checking simplifications) - rust-lang#128412 (Remove `crate_level_only` from `ELIDED_LIFETIMES_IN_PATHS`) - rust-lang#128430 (Use a separate pattern type for `rustc_pattern_analysis` diagnostics ) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#128402 - oli-obk:checked_attrs, r=compiler-errors Attribute checking simplifications remove an unused boolean and then merge two big matches into one I was reviewing some attributes and realized we don't really check this list against the list of builtin attributes, so we "may" totally be missing some attributes that we should be checking (like the `coroutine` attribute, which you can just apply to random stuff) ```rust #![feature(coroutines)] #[coroutine] struct Foo; ``` just compiles for example. Unless we check that the fallthrough match arm is never reached for builtin attributes, we're just going to keep forgetting to add them here, too. I can do that without the changes in this PR, but it seemed like a nice cleanup

Assert that all attributes are actually checked via `CheckAttrVisitor` and aren't accidentally usable on completely unrelated HIR nodes based on rust-lang#128402 After this PR, adding a new attribute will ICE on any use of that attribute unless it gets a handler added.

Assert that all attributes are actually checked via `CheckAttrVisitor` and aren't accidentally usable on completely unrelated HIR nodes `@oli-obk's` rust-lang#128444 with unreachable case removed to avoid that PR bitrotting away. Based on rust-lang#128402. This PR will make adding a new attribute ICE on any use of that attribute unless it gets a handler added in `rustc_passes::CheckAttrVisitor`. r? `@nnethercote` (since you were the reviewer of the original PR)

Assert that all attributes are actually checked via `CheckAttrVisitor` and aren't accidentally usable on completely unrelated HIR nodes ``@oli-obk's`` rust-lang#128444 with unreachable case removed to avoid that PR bitrotting away. Based on rust-lang#128402. This PR will make adding a new attribute ICE on any use of that attribute unless it gets a handler added in `rustc_passes::CheckAttrVisitor`. r? ``@nnethercote`` (since you were the reviewer of the original PR)

Rollup merge of rust-lang#128581 - jieyouxu:checked-attr, r=nnethercote Assert that all attributes are actually checked via `CheckAttrVisitor` and aren't accidentally usable on completely unrelated HIR nodes ``@oli-obk's`` rust-lang#128444 with unreachable case removed to avoid that PR bitrotting away. Based on rust-lang#128402. This PR will make adding a new attribute ICE on any use of that attribute unless it gets a handler added in `rustc_passes::CheckAttrVisitor`. r? ``@nnethercote`` (since you were the reviewer of the original PR)

Attribute checking simplifications

67a08b5

remove an unused boolean and then merge two big matches into one

rustbot assigned estebank Jul 30, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 30, 2024

compiler-errors approved these changes Jul 30, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2024

matthiaskrgr mentioned this pull request Jul 30, 2024

Rollup of 6 pull requests #128411

Closed

matthiaskrgr mentioned this pull request Jul 31, 2024

Rollup of 5 pull requests #128423

Closed

matthiaskrgr mentioned this pull request Jul 31, 2024

Rollup of 4 pull requests #128428

Closed

matthiaskrgr mentioned this pull request Jul 31, 2024

Rollup of 9 pull requests #128435

Merged

oli-obk mentioned this pull request Jul 31, 2024

Assert that all attributes are actually checked via CheckAttrVisitor and aren't accidentally usable on completely unrelated HIR nodes #128444

Closed

bors merged commit e2d8f1a into rust-lang:master Jul 31, 2024
6 checks passed

rustbot added this to the 1.82.0 milestone Jul 31, 2024

jieyouxu mentioned this pull request Aug 3, 2024

Assert that all attributes are actually checked via CheckAttrVisitor and aren't accidentally usable on completely unrelated HIR nodes #128581

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attribute checking simplifications #128402

Attribute checking simplifications #128402

oli-obk commented Jul 30, 2024

rustbot commented Jul 30, 2024

compiler-errors left a comment

compiler-errors commented Jul 30, 2024

bors commented Jul 30, 2024

Attribute checking simplifications #128402

Attribute checking simplifications #128402

Conversation

oli-obk commented Jul 30, 2024

rustbot commented Jul 30, 2024

compiler-errors left a comment

Choose a reason for hiding this comment

compiler-errors commented Jul 30, 2024

bors commented Jul 30, 2024