Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Heuristica" WOFF in documentation is corrupted #15527

Closed
mernen opened this issue Jul 8, 2014 · 0 comments · Fixed by #15530
Closed

"Heuristica" WOFF in documentation is corrupted #15527

mernen opened this issue Jul 8, 2014 · 0 comments · Fixed by #15530

Comments

@mernen
Copy link
Contributor

mernen commented Jul 8, 2014

The documentation pages are supposed to use a serif font named Heuristica for body text, but all browsers tested failed to render it.

Most browsers were silent, but Firefox gave me these two helpful console messages:

Interestingly, Heuristica-Bold.woff is also damaged, but the two italic versions seem fine.

Additionally, the page style declares Helvetica Neue, Helvetica, Arial, sans-serif as fallbacks. Since Heuristica is a serif font, shouldn't we use serif fallbacks? (That said, the docs look fine with the sans fonts to me, I wouldn't mind keeping the current looks.)

bors added a commit that referenced this issue Jul 9, 2014
- Treat WOFF as binary files so that git does not perform newline normalization.
- Replace corrupt Heuristica files with Source Serif Pro — italics are [almost in production](adobe-fonts/source-serif#2) so I left Heuristica Italic which makes a good pair with SSP. Overall, Source Serif Pro is I think a better fit for rustdoc (cc @thehydroimpulse). This ought to fix #15527.
- Store Source Code Pro locally in order to make offline docs freestanding. Fixes #14778.

Preview: http://adrientetar.legtux.org/cached/rust-docs/core.html

r? @alexcrichton
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant