-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webfonts: fixes #15530
webfonts: fixes #15530
Conversation
So that we have freestanding docs.
👍 on fixing the Not so sure about replacing Heuristica. I don't know what led to that font being chosen, but it seems like replacing that with Source Serif Pro should be an intentional decision and not something done purely because the Heuristica WOFF files are corrupt. Surely we can get non-corrupted Heuristica WOFF files? That's not to say that using SSP is a bad idea. Perhaps it's a better fit, I don't know. |
Of course, but there were a few negative opinions towards Heuristica during the original merge, then with the corrupt files and the fact that some people were willing to plain revert all rustdoc design changes there hasn't been a sheer discussion on the subject, through I expect that Source Serif Pro will be easier on the eye for that kind of use-case so I am proposing that unless people prefer Heuristica. |
To quote @brson from IRC:
I'm not personally familiar with these fonts, but do you know what sort of license they come under? |
In fact, SIL OFL has been for long the de-facto standard for free and open-source fonts. |
I'll add that. |
@alexcrichton What I added in that last commit is basically four times the SIL modulo the different copyright statements. Is it fine to combine them together in one file? |
I'm not entirely sure, I would defer that question to @brson. |
@@ -52,7 +58,7 @@ | |||
body { | |||
margin: 0 auto; | |||
padding: 0 15px; | |||
font-family: "Heuristica", "Helvetica Neue", Helvetica, Arial, sans-serif; | |||
font-family: "Source Serif Pro", "Helvetica Neue", Helvetica, Arial, sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're changing this line, wouldn't it be better if the fallback fonts were also serif? (Just "Source Serif Pro", serif
would be enough, IMO)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably; I haven't tested default serifs on all major platforms just now through.
- Treat WOFF as binary files so that git does not perform newline normalization. - Replace corrupt Heuristica files with Source Serif Pro — italics are [almost in production](adobe-fonts/source-serif#2) so I left Heuristica Italic which makes a good pair with SSP. Overall, Source Serif Pro is I think a better fit for rustdoc (cc @thehydroimpulse). This ought to fix #15527. - Store Source Code Pro locally in order to make offline docs freestanding. Fixes #14778. Preview: http://adrientetar.legtux.org/cached/rust-docs/core.html r? @alexcrichton
…llaumeGomez Rustdoc: update Source Serif Pro and replace Heuristica italic When Source Serif Pro was used to replace Heuristica in rust-lang#15530, the italic variant was not ready yet, but now it is. This PR updates the Source Serif Pro font files to the [latest release](https://github.com/adobe-fonts/source-serif-pro/releases/tag/2.007R-ro%2F1.007R-it) which includes an italic variant, and replaces Heuristica italic with Source Serif Pro italic. Fixes rust-lang#57363.
Preview: http://adrientetar.legtux.org/cached/rust-docs/core.html
r? @alexcrichton