Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::sync::mpsc doesn't implement fmt::Debug for Sender, Receiver etc. #30563

Closed
antrik opened this issue Dec 26, 2015 · 3 comments
Closed

std::sync::mpsc doesn't implement fmt::Debug for Sender, Receiver etc. #30563

antrik opened this issue Dec 26, 2015 · 3 comments

Comments

@antrik
Copy link
Contributor

antrik commented Dec 26, 2015

All public types should implement Debug.

Per conversation on #rust-internals, there might be some useful information that could be printed for these types -- but even just "Sender { .. }" etc. would be a start.
@antrik antrik mentioned this issue Dec 26, 2015
Merged
antrik added a commit to antrik/rust that referenced this issue Jan 14, 2016
@antrik
std::sync::mpsc: Add fmt::Debug stubs
0e3fb18 
Minimal fix for rust-lang#30563

This covers all the public structs I think; except for Iter and
IntoIter, which I don't know if or how they should be handled.
@antrik antrik mentioned this issue Jan 14, 2016
Merged
bors added a commit that referenced this issue Jan 20, 2016
@bors
Auto merge of #30894 - antrik:debug-mpsc, r=brson
7561466 
Minimal fix for #30563

This covers all the public structs I think; except for Iter and
IntoIter, which I don't know if or how they should be handled.
@apasel422
Copy link
Contributor

Was this closed by #30894?

@antrik
Copy link
Contributor Author

antrik commented Feb 6, 2016

@apasel422 probably.

It has been suggested that way more useful info could actually be printed instead of the opaque placeholders -- but that would be more of a wishlist item than a bug...

The patch is sufficient to fix the actual problem I was running into: not being able to #[derive(Debug)] on any structure containing mpsc Senders/Receivers.

@alexcrichton
Copy link
Member

Ok, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antrik @alexcrichton @apasel422