std::sync::mpsc: Add fmt::Debug stubs #30894
Conversation
Minimal fix for rust-lang#30563 This covers all the public structs I think; except for Iter and IntoIter, which I don't know if or how they should be handled.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Yay! I just ran into this problem. Glad to see a fix 😄. |
|
cc @rust-lang/libs This seems reasonable to me. Do these implementations follow existing conventions for |
brson
added
the
relnotes
|
I don't think I've never seen the |
|
I'm fine with this, and at least in my opinion I don't think that the exact output of A quick grep shows up one other instance of this. |
|
Another convention says that debug impls don't need to indicate type information. These seem like sensible implementations anyway, just empty braces would just bring confused issue reports. |
|
@bors r+ |
|
📌 Commit 0e3fb18 has been approved by |
Minimal fix for #30563 This covers all the public structs I think; except for Iter and IntoIter, which I don't know if or how they should be handled.
|
⌛ Testing commit 0e3fb18 with merge 7561466... |
Minimal fix for #30563
This covers all the public structs I think; except for Iter and
IntoIter, which I don't know if or how they should be handled.