Tracking issue for RefCell::{try_borrow, try_borrow_mut} #35070
Comments
alexcrichton
added
B-RFC-approved
alexcrichton
added
B-unstable
Implement `RefCell::{try_borrow, try_borrow_mut}`
CC #35070
r? @alexcrichton
|
The error types do have a lifetime parameter now. Can we go to FCP and bikeshed the naming in that period? (I think the naming is fine.) |
|
This nomination didn't come in before our meeting yesterday, but I'd be fine adding it. Proposing FCP with inclination to stabilize. Libs team, please signal your agreement below or leave comments with concerns: |
|
It looks like I'm being asked to sign off on stabilization before the design is complete ("Can we go to FCP and bikeshed the naming in that period?"). I don't agree to that. |
|
@brson As I see it, the design is complete and there was just some mild reservation about the naming in the RFC discussion. It’s been a month since this was implemented and merged, and two months since the RFC was first submitted. I don’t think new information is likely to appear if we wait more. |
|
@SimonSapin understood, but I think this is a bug in the new process. Me checking that box is my final decision as a member of the libs team, and the design is not final. |
|
Per discussion with @aturon I've checked the box and we'll discuss the process mechanics later. |
alexcrichton
added
final-comment-period
|
🔔 The library team has decided to move this into final comment period for stabilization 🔔 |
|
The libs team discussed this during triage yesterday and the conclusion was to stabilize We also figured that the type/lifetime parameter on the errors returned aren't worth it, so they'll get removed. |
This commit is intended to be backported to the 1.13 branch, and works with the following APIs: Stabilized * `i32::checked_abs` * `i32::wrapping_abs` * `i32::overflowing_abs` * `RefCell::try_borrow` * `RefCell::try_borrow_mut` * `DefaultHasher` * `DefaultHasher::new` * `DefaultHasher::default` Deprecated * `BinaryHeap::push_pop` * `BinaryHeap::replace` * `SipHash13` * `SipHash24` * `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map` module Closes rust-lang#28147 Closes rust-lang#34767 Closes rust-lang#35057 Closes rust-lang#35070
std: Stabilize and deprecate APIs for 1.13 This commit is intended to be backported to the 1.13 branch, and works with the following APIs: Stabilized * `i32::checked_abs` * `i32::wrapping_abs` * `i32::overflowing_abs` * `RefCell::try_borrow` * `RefCell::try_borrow_mut` Deprecated * `BinaryHeap::push_pop` * `BinaryHeap::replace` * `SipHash13` * `SipHash24` * `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map` module Closes #28147 Closes #34767 Closes #35057 Closes #35070
This commit is intended to be backported to the 1.13 branch, and works with the following APIs: Stabilized * `i32::checked_abs` * `i32::wrapping_abs` * `i32::overflowing_abs` * `RefCell::try_borrow` * `RefCell::try_borrow_mut` * `DefaultHasher` * `DefaultHasher::new` * `DefaultHasher::default` Deprecated * `BinaryHeap::push_pop` * `BinaryHeap::replace` * `SipHash13` * `SipHash24` * `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map` module Closes rust-lang#28147 Closes rust-lang#34767 Closes rust-lang#35057 Closes rust-lang#35070
Tracking issue for rust-lang/rfcs#1660
Stabilization of these functions should be contingent on confirming the conventions around naming of this style of methods.
Another idea I've had recently is we perhaps want to connect the lifetime of the
RefCellto the error type as well, but we can always do that later as well.The text was updated successfully, but these errors were encountered: