-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: Stabilize and deprecate APIs for 1.13 #36815
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
ba3cf9c
to
1b3eb49
Compare
r=me after fixing tidy failure |
☔ The latest upstream changes (presumably #36818) made this pull request unmergeable. Please resolve the merge conflicts. |
c5209c3
to
0cdd570
Compare
@bors: r=aturon |
📌 Commit 0cdd570 has been approved by |
0cdd570
to
546c052
Compare
@bors: r=aturon |
📌 Commit 546c052 has been approved by |
⌛ Testing commit 546c052 with merge ce57a05... |
💔 Test failed - auto-win-msvc-64-cargotest |
/me shakes fist at |
This type is being deprecated in rust-lang/rust#36815, so allow use of the deprecated type for now. We can fix this later once new APIs have landed.
Allow deprecated use of SipHasher This type is being deprecated in rust-lang/rust#36815, so allow use of the deprecated type for now. We can fix this later once new APIs have landed.
546c052
to
7c86a2b
Compare
@bors: r=aturon |
📌 Commit 7c86a2b has been approved by |
⌛ Testing commit 7c86a2b with merge ec3fc8e... |
💔 Test failed - auto-linux-musl-64-opt |
This commit is intended to be backported to the 1.13 branch, and works with the following APIs: Stabilized * `i32::checked_abs` * `i32::wrapping_abs` * `i32::overflowing_abs` * `RefCell::try_borrow` * `RefCell::try_borrow_mut` * `DefaultHasher` * `DefaultHasher::new` * `DefaultHasher::default` Deprecated * `BinaryHeap::push_pop` * `BinaryHeap::replace` * `SipHash13` * `SipHash24` * `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map` module Closes rust-lang#28147 Closes rust-lang#34767 Closes rust-lang#35057 Closes rust-lang#35070
7c86a2b
to
10c3134
Compare
@bors: r=aturon |
📌 Commit 10c3134 has been approved by |
std: Stabilize and deprecate APIs for 1.13 This commit is intended to be backported to the 1.13 branch, and works with the following APIs: Stabilized * `i32::checked_abs` * `i32::wrapping_abs` * `i32::overflowing_abs` * `RefCell::try_borrow` * `RefCell::try_borrow_mut` Deprecated * `BinaryHeap::push_pop` * `BinaryHeap::replace` * `SipHash13` * `SipHash24` * `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map` module Closes #28147 Closes #34767 Closes #35057 Closes #35070
Is there any plan to split |
There is already a sip hash crate.
…On Sun, Feb 19, 2017 at 11:58 AM Skyler Hawthorne ***@***.***> wrote:
Is there any plan to split SipHasher into its own crate, for those who
specifically want a stable SipHash hasher?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#36815 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABY2UcnpUwTU86DE5K9YzdXWmt5owYHMks5reJ8BgaJpZM4KJdab>
.
|
I guess I should clarify: since users of |
Is there anything lacking/problematic with https://crates.io/crates/siphasher? |
I don't know; I haven't tried it. I just need a stable SipHash implementation, and I'd just like to know how to proceed. If there's going to be an official SipHash crate in the relatively near future, then I'd rather wait for that, but if not, then I can try out the available community crates. |
This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:
Stabilized
i32::checked_abs
i32::wrapping_abs
i32::overflowing_abs
RefCell::try_borrow
RefCell::try_borrow_mut
Deprecated
BinaryHeap::push_pop
BinaryHeap::replace
SipHash13
SipHash24
SipHasher
- useDefaultHasher
instead in thestd::collections::hash_map
module
Closes #28147
Closes #34767
Closes #35057
Closes #35070