Tracking issue for unstable sort in libcore #40585
Labels
B-unstable
Blocker: Implemented in the nightly compiler and unstable.
final-comment-period
In the final comment period and will be merged soon unless new substantive objections are raised.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
alexcrichton
added
B-RFC-approved
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this issue
Mar 16, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Mar 17, 2017
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Mar 17, 2017
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Mar 17, 2017
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Mar 17, 2017
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Mar 17, 2017
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
This was referenced Mar 17, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Mar 18, 2017
…e, r=steveklabnik Add docs for sort_unstable to unstable book Tracking issue for the feature: rust-lang#40585 r? @steveklabnik
bors
added a commit
that referenced
this issue
Mar 21, 2017
Implement feature sort_unstable Tracking issue for the feature: #40585 This is essentially integration of [pdqsort](https://github.com/stjepang/pdqsort) into libcore. There's plenty of unsafe blocks to review. The heart of pdqsort is `fn partition_in_blocks` and is probably the most challenging function to understand. It requires some patience, but let me know if you find it too difficult - comments could always be improved. #### Changes * Added `sort_unstable` feature. * Tweaked insertion sort constants for stable sort. Sorting integers is now up to 5% slower, but sorting big elements is much faster (in particular, `sort_large_big_random` is 35% faster). The old constants were highly optimized for sorting integers, so overall the configuration is more balanced now. A minor regression in case of integers is forgivable as we recently had performance improvements (#39538) that completely make up for it. * Removed some uninteresting sort benchmarks. * Added a new sort benchmark for string sorting. #### Benchmarks The following table compares stable and unstable sorting: ``` name stable ns/iter unstable ns/iter diff ns/iter diff % slice::sort_large_ascending 7,240 (11049 MB/s) 7,380 (10840 MB/s) 140 1.93% slice::sort_large_big_random 1,454,138 (880 MB/s) 910,269 (1406 MB/s) -543,869 -37.40% slice::sort_large_descending 13,450 (5947 MB/s) 10,895 (7342 MB/s) -2,555 -19.00% slice::sort_large_mostly_ascending 204,041 (392 MB/s) 88,639 (902 MB/s) -115,402 -56.56% slice::sort_large_mostly_descending 217,109 (368 MB/s) 99,009 (808 MB/s) -118,100 -54.40% slice::sort_large_random 477,257 (167 MB/s) 346,028 (231 MB/s) -131,229 -27.50% slice::sort_large_random_expensive 21,670,537 (3 MB/s) 22,710,238 (3 MB/s) 1,039,701 4.80% slice::sort_large_strings 6,284,499 (38 MB/s) 6,410,896 (37 MB/s) 126,397 2.01% slice::sort_medium_random 3,515 (227 MB/s) 3,327 (240 MB/s) -188 -5.35% slice::sort_small_ascending 42 (1904 MB/s) 41 (1951 MB/s) -1 -2.38% slice::sort_small_big_random 503 (2544 MB/s) 514 (2490 MB/s) 11 2.19% slice::sort_small_descending 72 (1111 MB/s) 69 (1159 MB/s) -3 -4.17% slice::sort_small_random 369 (216 MB/s) 367 (217 MB/s) -2 -0.54% ``` Interesting cases: * Expensive comparison function and string sorting - it's a really close race, but timsort performs a slightly smaller number of comparisons. This is a natural difference of bottom-up merging versus top-down partitioning. * `large_descending` - unstable sort is faster, but both sorts should have equivalent performance. Both just check whether the slice is descending and if so, they reverse it. I blame LLVM for the discrepancy. r? @alexcrichton
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Mar 22, 2017
…e, r=frewsxcv Add docs for sort_unstable to unstable book Tracking issue for the feature: rust-lang#40585 r? @steveklabnik
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Mar 22, 2017
…e, r=frewsxcv Add docs for sort_unstable to unstable book Tracking issue for the feature: rust-lang#40585 r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Mar 22, 2017
…e, r=frewsxcv Add docs for sort_unstable to unstable book Tracking issue for the feature: rust-lang#40585 r? @steveklabnik
48 tasks
|
Is there any work needed here before stabilization? |
|
@scottmcm There isn't. The feature is implemented and documented. The final stabilization PR will just have to add one sentence to the docs, that's it (see the FIXMEs in the code). |
|
@rfcbot fcp merge |
alexcrichton
added
B-unstable
|
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
added
the
final-comment-period
|
The final comment period is now complete. |
ghost
mentioned this issue
bors
added a commit
that referenced
this issue
Jul 2, 2017
Stabilize feature sort_unstable Closes #40585
ghost
mentioned this issue
|
I'm curious if I compile it to native and wasm. I'll get the same ouput? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tracking issue for rust-lang/rfcs#1884
The text was updated successfully, but these errors were encountered: