Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize feature sort_unstable #43010

Merged
merged 4 commits into from Jul 3, 2017
Merged

Stabilize feature sort_unstable #43010

merged 4 commits into from Jul 3, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2017

Closes #40585

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum
Copy link
Member

Looks like Travis failed.

[00:03:24] tidy error: /checkout/src/liballoc/slice.rs:1273: different stability level than before
[00:03:24] tidy error: /checkout/src/liballoc/slice.rs:1273: different `since` than before
[00:03:24] tidy error: /checkout/src/liballoc/slice.rs:1273: different `tracking_issue` than before

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 2, 2017
@alexcrichton
Copy link
Member

Thanks @stjepang! r=me other than the tidy error

@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 2, 2017
@ghost
Copy link
Author

ghost commented Jul 2, 2017

The tidy errors have been fixed.

@Mark-Simulacrum
Copy link
Member

Travis appears to still be failing.

@ghost
Copy link
Author

ghost commented Jul 2, 2017

All right, should be good to go now. :)

@Mark-Simulacrum
Copy link
Member

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 2, 2017

📌 Commit 66f8cdd has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 2, 2017

⌛ Testing commit 66f8cdd with merge 1d2db7b...

bors added a commit that referenced this pull request Jul 2, 2017
@bors
Copy link
Contributor

bors commented Jul 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1d2db7b to master...

@bors bors merged commit 66f8cdd into rust-lang:master Jul 3, 2017
@ghost ghost deleted the stabilize-sort-unstable branch July 3, 2017 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants