Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious failure in test_process_output_fail_to_start #43283

Closed
alexcrichton opened this issue Jul 17, 2017 · 2 comments
Closed

Spurious failure in test_process_output_fail_to_start #43283

alexcrichton opened this issue Jul 17, 2017 · 2 comments
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) A-testsuite Area: The testsuite used to check the correctness of rustc C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. O-android Operating system: Android T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

First seen at #43271 (comment) logs are https://travis-ci.org/rust-lang/rust/jobs/254360556 and ends with:

[01:11:23] test process::tests::test_add_to_env ... ok
[01:11:23] test process::tests::test_finish_once ... ignored
[01:11:23] test process::tests::test_finish_twice ... ignored
[01:11:23] test process::tests::test_inherit_env ... ok
[01:11:23] test process::tests::test_interior_nul_in_arg_is_error ... ok
[01:11:23] test process::tests::test_interior_nul_in_args_is_error ... ok
[01:11:23] test process::tests::test_interior_nul_in_current_dir_is_error ... ok
[01:11:23] test process::tests::test_interior_nul_in_env_key_is_error ... ok
[01:11:23] test process::tests::test_interior_nul_in_env_value_is_error ... ok
[01:11:23] test process::tests::test_interior_nul_in_progname_is_error ... ok
[01:11:23] test process::tests::test_override_env ... ok
[01:11:23] test process::tests::test_process_output_error ... ignored
[01:12:23] test process::tests::test_process_output_fail_to_start ... test process::tests::test_process_output_fail_to_start has been running for over 60 seconds


No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

Note that this is in QEMU emulation, so there could just be something funky going on there...

@alexcrichton alexcrichton added the A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) label Jul 17, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Jul 28, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 15, 2018
I don't think we're getting much benefit from having a flaky test fail on us
every now and then. Unfortunately it seems like we have no idea why this is
flaky and infinitely blocking sometimes, so let's ignore it for now on Android
but continue to run it on other platforms.

cc rust-lang#43283
@kennytm kennytm added the O-android Operating system: Android label Aug 18, 2018
@jonas-schievink jonas-schievink added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. A-testsuite Area: The testsuite used to check the correctness of rustc labels Nov 26, 2019
@jonas-schievink
Copy link
Contributor

Triage: Looks like this didn't really happen anymore in 2019. The test is still being run on all platforms (I think?):

rust/src/libstd/process.rs

Lines 1786 to 1792 in c34472b

#[test]
fn test_process_output_fail_to_start() {
match Command::new("/no-binary-by-this-name-should-exist").output() {
Err(e) => assert_eq!(e.kind(), ErrorKind::NotFound),
Ok(..) => panic!()
}
}

Should this be closed?

@Mark-Simulacrum
Copy link
Member

Yes, I think this is likely fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) A-testsuite Area: The testsuite used to check the correctness of rustc C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. O-android Operating system: Android T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants