-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: move net specific file descriptor methods #43900
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Move the implementations of net specific file descriptior implementations to net. This makes it easier to exclude net at all if not needed for a target.
1622b57
to
2ccaeff
Compare
@bors: r+ Thanks! |
📌 Commit 2ccaeff has been approved by |
⌛ Testing commit 2ccaeff with merge c13aea02549e8e4f4aaad3ed62d6fa6c2866affc... |
💔 Test failed - status-travis |
@bors retry #43283 on
|
⌛ Testing commit 2ccaeff with merge 85cdc54543978fffd351644a571e59b4ff0fb0c1... |
@bors retry The macOS 64-bit dist job stuck at the "Job received" stage for over 3 hours and never start. |
↑ https://travis-ci.org/rust-lang/rust/builds/265581807 (not editing to prevent sending a bors command) Problem on Travis side probably caused by the recent update https://www.traviscistatus.com/incidents/kdvnlc4w3n67. cc #40672 |
Refactoring: move net specific file descriptor methods Move the implementations of net specific file descriptor methods from io to net. This makes it easier to exclude net at all if it is not needed for a target.
☀️ Test successful - status-appveyor, status-travis |
Move the implementations of net specific file descriptor methods from
io to net. This makes it easier to exclude net at all if it is not needed
for a target.