Make ".e0" not parse as 0.0 #48235
Make ".e0" not parse as 0.0 #48235
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@alexcrichton can we get a review on this PR? |
|
r? @rkruppe |
src/libcore/tests/num/dec2flt/mod.rs
Outdated
| @@ -99,6 +99,8 @@ fn fast_path_correct() { | |||
| fn lonely_dot() { | |||
| assert!(".".parse::<f32>().is_err()); | |||
| assert!(".".parse::<f64>().is_err()); | |||
| assert!(".e0".parse::<f32>().is_err()); | |||
| assert!(".e0".parse::<f64>().is_err()); | |||
There was a problem hiding this comment.
This doesn't really match the test name IMO. Better create a new test with an appropriate name (or issue_40654 if you, like me, can't think of a good succinct name).
This forces floats to have either a digit before the separating point, or after. Thus ".e0" is invalid like ".", when using `parse()`.
varkor
force-pushed
the
parse-float-lonely-exponent
branch
from
7210f4a
to
c0e87f1
Compare
alexcrichton
added
the
T-libs-api
|
Looks good to me, thanks! Let's get a signoff from other libs members on the breaking change aspect, but I'm personally comfortable with a change like this. @rfcbot fcp merge |
|
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
the
proposed-final-comment-period
alexcrichton
added
the
relnotes
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
added
final-comment-period
|
@bors: r+ Ok! |
|
📌 Commit c0e87f1 has been approved by |
bors
added
S-waiting-on-bors
… r=alexcrichton Make ".e0" not parse as 0.0 This forces floats to have either a digit before the separating point, or after. Thus `".e0"` is invalid like `"."`, when using `parse()`. Fixes rust-lang#40654. As mentioned in the issue, this is technically a breaking change... but clearly incorrect behaviour at present.
This forces floats to have either a digit before the separating point, or after. Thus
".e0"is invalid like".", when usingparse(). Fixes #40654. As mentioned in the issue, this is technically a breaking change... but clearly incorrect behaviour at present.