Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the checks for Self type parameters #50125

Closed
cuviper opened this issue Apr 20, 2018 · 0 comments · Fixed by #63463
Closed

Clean up the checks for Self type parameters #50125

cuviper opened this issue Apr 20, 2018 · 0 comments · Fixed by #63463
Labels
A-type-system Area: Type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@cuviper
Copy link
Member

cuviper commented Apr 20, 2018

per @eddyb in #49889 (comment)

I don't think we should need is_self and has_self_ty (or the gensym hack altogether), and instead we should rely on knowing that e.g. the item in scope is a trait and thus index 0 is Self.
@cuviper cuviper added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-type-system Area: Type system T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2018
@cuviper cuviper mentioned this issue Apr 20, 2018
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 20, 2018
@alexcrichton
Paper over a bug on master
b00f39b 
This commit papers over rust-lang#49889 (introducing a fixme pointing at rust-lang#50125) for a
bug that was introduced with rust-lang#49695. This workaround is taken from rust-lang#49891.
@eddyb eddyb mentioned this issue Aug 24, 2018
Closed
@eddyb eddyb mentioned this issue Aug 24, 2018
Closed
bors added a commit that referenced this issue Aug 24, 2018
@bors
Auto merge of #53677 - eddyb:not-my-self, r=<try>
9a46196 
rustc: remove Ty::{is_self, has_self_ty}.

Fixes #50125 by replacing special-casing of `Self` (and the gensym hack) with getting the type for the `Self` parameter from the trait, and comparing types with that, instead.

**NOTE**: this is part of #53661, split out to independently check performance impact.
@matthewjasper matthewjasper mentioned this issue Aug 11, 2019
Merged
bors added a commit that referenced this issue Aug 13, 2019
@bors
Auto merge of #63463 - matthewjasper:ty_param_cleanup, r=<try>
bbd6744 
Don't special case the `Self` parameter by name

This results in a couple of small diagnostic regressions. They could be avoided by keeping the special case just for diagnostics, but that seems worse.

closes #50125
cc #60869
@bors bors closed this as completed in a807902 Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-type-system Area: Type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't special case the Self parameter by name matthewjasper/rust
1 participant
@cuviper