-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use InternedString instead of Symbol for type parameter types (2) #49695
Conversation
@bors try |
Use InternedString instead of Symbol for type parameter types Reduced alternative to #49266. Let's see if this causes a performance regression.
Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - status-travis |
Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #49045) made this pull request unmergeable. Please resolve the merge conflicts. |
d7357e2
to
f3aebe3
Compare
f3aebe3
to
4c4f9b9
Compare
@bors try |
Use InternedString instead of Symbol for type parameter types (2) Reduced alternative to #49266. Let's see if this causes a performance regression.
☀️ Test successful - status-travis |
@Mark-Simulacrum, would you mind doing a perf run for this? |
Perf run started. |
No real performance regression, it seems. Let's merge this version and treat the optimizations in #49266 in a separate PR, I'd say. |
@bors r+ |
📌 Commit 4c4f9b9 has been approved by |
⌛ Testing commit 4c4f9b9 with merge a7325fcf69e107fb6312d6ad93a76ee55b234732... |
💔 Test failed - status-appveyor |
@bors retry 3 hour timeout in Timings
The time spent on building LLVM is unusually long, at 18 minutes (usually it is about 5 minutes). |
…akis Use InternedString instead of Symbol for type parameter types (2) Reduced alternative to #49266. Let's see if this causes a performance regression.
☀️ Test successful - status-appveyor, status-travis |
(this should act as a workaround for issue #48923) |
In backporting this PR e31dae4 doesn't apply cleanly but it looks non-critical so I'm going to leave it out. |
This commit papers over rust-lang#49889 (introducing a fixme pointing at rust-lang#50125) for a bug that was introduced with rust-lang#49695. This workaround is taken from rust-lang#49891.
I'll backport that commit too. It's kind of important because otherwise we get rather hard to interpret ICEs in subsequent compilation sessions (and sometimes silent corruption). |
[beta] Backport - Improve assertion in Query::force(). Follow up to #49695 (comment) r? @alexcrichton
Reduced alternative to #49266. Let's see if this causes a performance regression.