[nll] do another crater run and check the results

[nikomatsakis]

We have almost fixed all the problems we found in the last crater run. We should do another cargo check run at some point. We need to have the -Zborrowck=mir -Ztwo-phase-borrows options supplied by default.

Once the crater run is done, we have to analyze the results.

cc @Mark-Simulacrum for advice on the best way to do that, do we need to make a PR with those options enabled by default?

[Mark-Simulacrum]

That's probably the easiest way to get what we want, yes.

[nikomatsakis]

I'm going to close this -- @lqd did the crater run, and we've analyzed the results and opened the requisite issues. The following links contain the analyzed results:

• hackmd document
• update existing crates to current results nikomatsakis/nll-crater-run-results#1
• ICEs are found in NLL ICEs from 3rd crater run #53482